From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64F0CC04A6A for ; Fri, 11 Aug 2023 08:50:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADCB46B0085; Fri, 11 Aug 2023 04:50:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8CD76B0087; Fri, 11 Aug 2023 04:50:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 956046B0088; Fri, 11 Aug 2023 04:50:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 838966B0085 for ; Fri, 11 Aug 2023 04:50:15 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 416291403F5 for ; Fri, 11 Aug 2023 08:50:15 +0000 (UTC) X-FDA: 81111201990.03.69C1D59 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by imf17.hostedemail.com (Postfix) with ESMTP id E42B64000B for ; Fri, 11 Aug 2023 08:50:12 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=aK8g64IU; spf=none (imf17.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691743813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1837SroPhBdBFH2Mb9diN0wSqw83ybIQiOMLyFI1lu0=; b=ibrrEzDfSF/4Z+XVkC8iRx5r158qOn9yuXpiUSwqr17hTh9yFEsPm5CIV5nwNLSzwFZ/U/ Ded43s/YM5nClBbJm6z4kPj9GuLg6SB0Vn/uZfRoO3/C3OIU0ASEQVVjOWIXhP5DePE+V4 FXJYPGQ8lQO/ZVVZPhvNN8Y3n4m8Zpk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691743813; a=rsa-sha256; cv=none; b=0/9bLtGqJZUAwfVWDSWwW5ysjWhEq8IUcUqFb/+a0Smp2Y5ICYgVa19DkJ1bpD1A2n2qyi 22AM4lNVCoT5sCq8xRkMAklqFOXdMZ9ul86UJ3KDyoD5fuZ3nbp4idqSx+M0nZhkD3VPnn AvsfsclXanTJ+h1jh46sE8i++erIGwQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=aK8g64IU; spf=none (imf17.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691743813; x=1723279813; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=T7eIZTizi/1+md1Xz2qj/FMgLHZOhIC+aHP88G90UUk=; b=aK8g64IUeX0iogalpm4ffLFZKg5QrebdMlwc1gabL3qp2pXunGU1nBz8 tBfWrZ3xB5PpOWu/gWdqdX7wiCRknkGTZjIQMyOixK2Bi4SdWRZ11Slg4 r+9dZvJSldpd6323kWDsffX8cKJoFE33/7z4TAaol4wnJ6G/2+NIKYcyF SeaVM0zim7VZpGLkXbOiR+HUbexbQUf4W/5Rpzz7EF42CCY22JsdJCxw+ /NHKzMxsd6OXeaPA6wZNHJ1fVaMLsWKvdPd7IbodIOyZEFZaDG9evreU/ LcC2pQ76PE3DV0LGO6V07YmY6z7+zuK3mQOTxz5C8wd9uFufyJAG8Gs0g A==; X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="371641870" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="371641870" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2023 01:50:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="735720466" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="735720466" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP; 11 Aug 2023 01:50:04 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qUNqL-007ENk-1T; Fri, 11 Aug 2023 11:50:01 +0300 Date: Fri, 11 Aug 2023 11:50:01 +0300 From: Andy Shevchenko To: Yury Norov Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar , Peter Zijlstra , Andrew Morton , Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Jacob Keller , Jakub Kicinski , Juri Lelli , Mel Gorman , Peter Lafreniere , Steven Rostedt , Tariq Toukan , Valentin Schneider , Vincent Guittot , shiju.jose@huawei.com, jonathan.cameron@huawei.com, prime.zeng@huawei.com, linuxarm@huawei.com, yangyicong@hisilicon.com, Rasmus Villemoes Subject: Re: [PATCH 2/4] sched/fair: fix opencoded numa_nearest_node() Message-ID: References: <20230810162442.9863-1-yury.norov@gmail.com> <20230810162442.9863-3-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230810162442.9863-3-yury.norov@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Queue-Id: E42B64000B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: xy3k89twea1ohmo5a7owt74xsbwaphy9 X-HE-Tag: 1691743812-454093 X-HE-Meta: U2FsdGVkX1+4MMxZ3Czw3VT5rC2hT336uLAObSvbbgDKahAnC1vCxLI6Y7uWVl9TsrrLNW5fL894Mf4P4NRyxyhGKvKEDtKKYVGMlDFDt/0Dgz9kLG3DjJ9MyRolVMmxn9I7ZBdvqGbOxhnPdVNMKObpsxQM1nGuoTTYStMGWWZqQUL941EcY8scrycx8nnWidUS9h9KDxMLrbOBuLi6CMjKUi1Haj0acFnmEUnXDQHUvmHVSuuJIP+xoR5riLScDPPi8kfhIefBcKOW7KVSQDpDAv1+Gap8pPl6SR1PlTQ0Vjq+FDvbPQpvk6GDW5G99NtpLhm6Gi5oubdfC1gBw1aMfxfC9ZltUULHCXCEyi77NY/CC3/hS65Mt/7koeAGSzjDqUCH9zNawd+cxh268HQyl38jfbiEr8ATVzRzoOn3D5VnYLAB0q7OvnXNIDQVk2JIZ08LwP8Ly/zXd7QqMBbpKklBAdW2NDbFH+ZxkZJohvbQTUZZd2JwInIrARFge4Frl2F87Lc6ZvqZida4XyY2C85V6KYB2KOVRMPaDFHGyv1SQjT9/ygI7CjB40YY2PrJ/U3jq/+NndZNNUHABc8HUwIkUMSRdhpCmhMU9Xt/JMqhRHuCeFXJz3InbcKZ4GPNBhCWkPG5Ai10XeMFAzY+Xh5ZdiHFuU6F1QQX9lvgfjHsrNzja7DZM7GGBjB9TFCVzZpv0hGX07hy4pV3I/EFvsx863ZwvFADOyMxBef1zW54ShUewSyyZ08HJhCd/LYc66nrpXUVVVKZ3ZVnCaSh/QskxOOEDjOpb7C+m5RED6awwflVQsKVwoHSJRJHBT0tOv5VbRizdjWv86YrBWlLG+5mytdI79qzw7EkUqq6TXvS/nnMSvhrvDAxQ7FIa9oj+DRAvIqLAymuWK3c7Gx+gBAPKgVzPjOmuzXGMeiNX5gBq+CSRcrMCyCBcl6NyZt8NhYu7fiY2k7Y0hq Qm+rUShS BrFbjoiA0UX39eTxW9YqgeGT7hW6DSdbON7n8I7KenYDXy2KAj58hktzQGpZ/a5JhsqKdGJrPdxVkCrQHQbWIBDpi+93LpuDoDKwDeRbMkJptwJLy6CDU3qb1IMdvtpDQWyAZcMMIBopmiWt+SdkAkuGnHES9jEbHMzIJY24GFloFU8peznrql2n1gsgn/iYyJSnsrhU6Ic+nyetWiZMmjJOS6i0Di6Z/ffyFbXw06J0ztEpTESdlIlvIcCr2YMlShSYpDSTMk/ZyS8cBJanwTnI+LboWEqn+RAwZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 10, 2023 at 09:24:40AM -0700, Yury Norov wrote: > task_numa_placement() searches for a nearest node by calling > for_each_node_state(). Now that we have numa_nearest_node(), switch to > using it. For better looking you may rewrap the above as ---8<--- task_numa_placement() searches for a nearest node by calling for_each_node_state(). Now that we have numa_nearest_node(), switch to using ---8<--- -- With Best Regards, Andy Shevchenko