From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5467AEB64DD for ; Fri, 11 Aug 2023 04:28:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B04B36B0071; Fri, 11 Aug 2023 00:28:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB4A56B0072; Fri, 11 Aug 2023 00:28:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A3696B0074; Fri, 11 Aug 2023 00:28:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8C6B86B0071 for ; Fri, 11 Aug 2023 00:28:50 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5D9E212036D for ; Fri, 11 Aug 2023 04:28:50 +0000 (UTC) X-FDA: 81110543220.24.0841D2D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 282381C0013 for ; Fri, 11 Aug 2023 04:28:47 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="MbI9sXS/"; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691728128; a=rsa-sha256; cv=none; b=FlKDkHKJTSM0T39NHB6UzuuT5ZraIWNp/JuoWxbErfZ/5NBl0Aqq36S8GKvBDc6NlXEMnt cYU4+GQvDJanQhqPOsU6+6mqMf3wY79n/+Nio91cPlwJWSnLY6XkLCrkP54bMqmkdTDIPh jzfTfPwLhrN699DKG6n5/kH/XBB6k0M= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="MbI9sXS/"; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691728128; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dgkXBhhGOK+N9g5kHizVj2PkllTyXLaTugwbboJFVoA=; b=xWLltxkku8FtF3eXJAsy4aFXqKp6S+oaHj5m3MT2crikwRED5xqq2pRRqt2wRnLNiVqGv2 6yXSknhMtfj1YFKc3u3/oVZsovUUTXuWAIJDT1qJjMAJV4Op4sFuUmKMDhhh8DnJT3MQgS OFlzslWLkFOPlmr0HnvH31fKjLk+G/k= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dgkXBhhGOK+N9g5kHizVj2PkllTyXLaTugwbboJFVoA=; b=MbI9sXS/mzMQEALl8vBmWra+io MmiHXgUQBJ21mfNebzgn9BpdN6QUqmZt5nuwcZsfijD7nWK38gUwZ6G+din5P84q8wxCOwOyXFeLn j7wVQ5DBC9tAMQpwzObMzv/7z1XwfIO418Ob+AT9Sdm8mgzszsh1j/6ApVKYA8cu0rYY8hKJWUZ+t YdbCxk5b0HyYvDr1RajyHzbXHTDa2bky5d1KsP0wERoo8wedIquFNJcylcJdW3410szCV5ORPQHyh dQaNXFwHrwIXk9/ronjbkOCjb+HHawNGyjDr3Oq3ylhRyX83oGyKzdLgGGdWHBFOYXvn9JztbBDkj XRUrFt9w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qUJlT-00Gdqa-BP; Fri, 11 Aug 2023 04:28:43 +0000 Date: Fri, 11 Aug 2023 05:28:43 +0100 From: Matthew Wilcox To: Kemeng Shi Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com Subject: Re: [PATCH 1/2] mm/page_alloc: remove unnecessary inner __get_pfnblock_flags_mask Message-ID: References: <20230811115945.3423894-1-shikemeng@huaweicloud.com> <20230811115945.3423894-2-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230811115945.3423894-2-shikemeng@huaweicloud.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 282381C0013 X-Stat-Signature: wgbh3ndkinsg59s4yto8i5hdxwmu3i7e X-Rspam-User: X-HE-Tag: 1691728127-517310 X-HE-Meta: U2FsdGVkX1/pGG2PxvQntTX+h7+NvbTEbJ/cT6I81BRcxeyJz+mwV9ZbDlhLW70/koSEeh8tnpIH/tB+SPAqnZLRoYh9EMM+LJG1K6v/LXKVCxNkB4CTe+cnerslHg6yGCvSw+6uo/+5HRPK8M+8Xf+64ZF4+ZAY/3TdDIg3a/upAUjUZkGHLl5ELYgEglx3ZPNJ5Y4/+0lo24b3l33RL19TZhyXm2+ogEKYz4CjNY9deepWnOTjLRauh+P9+hsizcwwpxpOVz3mlH/nZgDtyiBiF3br3HxSrw2VgDhOQ4+Wrn8BnIJ00jfsvfXys9tVzmvMo2P6eQ5mwejZewHp9ULVUcS8R7BgY/DNT0QA6keyuvoCt1eHVyJPpLhkmweIjXCYSp3JDVFVQbiqIEeQEK8DjPrY/sjn0k2OB/qMERfQOunsZyBanXelt9+Tf7SK/xlzoxXNeQSrgMlYKE+5PcQp6TGbhi2MPOQNj5CyfGjfl7qM9A8vgpKzhp/wrbGs9nHkCqLb9+Ir2jZdnZVQPgvODBdMsO1a/ji8U9VHhWxo51DoodC5OxxNeDsYeNA+Gjf90Oy8JwoiNDHb7m0o4r1GmoJS1SzGCEv7GZscpPY0D1Fc2pm8kJOx2zqtGgxG9kJdpzEbf5BvmiKT58evvTxquCZ+k9aNeKQtiWNyxWwtjyKDAbgkAVLaGbvf7TxmsgW46flBDF/r+spU2OhcEDCLif32ysg8+X874L8mW7NjYeKdtbMxJRwSjjVmBXVjjFigHUVeoNeh2fmtJ8u/4WzvoOf4NfM/GuZJjhIeALZ60ZRKkj7pqYkOV/Wpd179RMRSlI6g+gNtjznBdS0mzTEDxDeBiGESRbr4TP1r16DPPHhJHFgVML1srTf7MIX/ZLsEP8+A33nxNlLb9VxdZMCKlBfDocgNUcFwWPGy94sShdyr7G/b6bS265nNbaTs/pKmmqp6ImeRxWKP2YU 8VhR6wFr 3nmoJJ/T6sMp/s1dy4iMDlJy+hC6DeqKaUAGeyeUvFgvvQOL0YqMTFhbestsjFSv3aagt8bQ1XRoB6LXYtgq1U4Ou6C2ZQKBAkp8+r/J6SJx7aA8xPvYmjDJyL1pBu1rwXmXZBNh2Sro+J6Ss/N79yWdJV2tyEIxc4Lajoyhsg22Z3AFlKd9nYp6v9aqfz/TraLoYd4EatX5Q+SwoD9VXM9N+0To35kco3pEzv1EIF+7FN8It57GynhA5nfYxt2aELB7/aazME7wUIxykHE7to2fa50apuV/flDz6nzqriVFXfjE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 11, 2023 at 07:59:44PM +0800, Kemeng Shi wrote: > Function get_pfnblock_flags_mask just calls inline inner > __get_pfnblock_flags_mask without any extra work. Just opencode > __get_pfnblock_flags_mask in get_pfnblock_flags_mask and replace call > to __get_pfnblock_flags_mask with call to get_pfnblock_flags_mask to > remove unnecessary __get_pfnblock_flags_mask. > > Signed-off-by: Kemeng Shi Reviewed-by: Matthew Wilcox (Oracle) This could have happened at any time after 535b81e20921 (and arguably should have happened as part of it)