From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FAFBC04A6A for ; Thu, 10 Aug 2023 13:27:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3CEC6B0071; Thu, 10 Aug 2023 09:27:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC5896B0078; Thu, 10 Aug 2023 09:27:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93ED86B007B; Thu, 10 Aug 2023 09:27:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8111A6B0071 for ; Thu, 10 Aug 2023 09:27:36 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 38F63161040 for ; Thu, 10 Aug 2023 13:27:32 +0000 (UTC) X-FDA: 81108272112.21.53770A8 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by imf09.hostedemail.com (Postfix) with ESMTP id EA81A140026 for ; Thu, 10 Aug 2023 13:27:33 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fWrjWW2o; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf09.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691674054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UFBYT5tzI4z4icu73XhQu5b0aU+HQ5Kc9/dN5xSAkyM=; b=lWFoFp3PK/triOVnKDPxnRfR9USebzcEFxLuF5f1ALXwPkrZ1oJRNR9Haw1pfyLVN0txY4 ZKwGD/KEnwDenJa+Iw//UYrBzcHuMUCW2XyuGeFkG8etn1Wo2yE9bSG80Fpvs4kO7D+5WT 8SPfZ45Uz0HKyE5unRb6DtryF4FDMu4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fWrjWW2o; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf09.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691674054; a=rsa-sha256; cv=none; b=HQRU6zd/ujTucPz6Dji75l9xCG+lS9UodUkwXn6yeb6SwJRx2JQ5bvR9JP43TufC+FWmaj FvHs2uIwD3QdJLK/fV56FjGgRCUN1ybTMdgMVBoSceCK1eRqc9nXTT1Lw3AWGw8c/6X5Zj RI/sOgTo6QXZh8NDR4MDa+AS/OnAwnw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691674054; x=1723210054; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=CX/8PWwRlzjURvCQeMfP60m3SD6Gi3s5IWlgF68o6U0=; b=fWrjWW2owEiahVxd+0986qf8PHfrvC39ncSyR4muStUp5QaDdqg5e8IF tVfVjZRFST/Zu/U0P8wFRDzH5PD9SuqkHiCm0LjMVIa6Bwoh1xZpcyn+5 eKsihXdhcv5i26wDst4N4oSPsHXguyPQ09UUM9yJPSL2tMwM36BbzFK9W HTyq0I30WxxTNC7VvDtKZ1aiS4WCg6H6aunEp80U8lQ89voBos4euuBFU KI/h3p5KjcJtdYaIcjtEH1QYgI30gzHFQ/dFj81e2j5zhrSgruiEqThGa B8Q1QxkUoJ7evw09v/5cflAcu1kq4p9Ap5WH2zKjyB4JaqHdcosrx7ckZ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="370298869" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="370298869" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2023 06:17:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="875714029" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP; 10 Aug 2023 06:17:40 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qU5Xj-002PH0-0V; Thu, 10 Aug 2023 16:17:35 +0300 Date: Thu, 10 Aug 2023 16:17:34 +0300 From: Andy Shevchenko To: Rasmus Villemoes Cc: Petr Mladek , Marco Elver , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Steven Rostedt , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Subject: Re: [PATCH v2 2/3] lib/vsprintf: Split out sprintf() and friends Message-ID: References: <20230805175027.50029-1-andriy.shevchenko@linux.intel.com> <20230805175027.50029-3-andriy.shevchenko@linux.intel.com> <67ddbcec-b96f-582c-a38c-259234c3f301@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <67ddbcec-b96f-582c-a38c-259234c3f301@rasmusvillemoes.dk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspam-User: X-Stat-Signature: 67g6omn6op53oji8zsbytnze31youys4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EA81A140026 X-HE-Tag: 1691674053-63725 X-HE-Meta: U2FsdGVkX1+nKpVPgdkxssI/a7xQPpHdo6dHvcIinxdJ/FyJNT5HJUR4Uji2o6u0JnptR4OzoUaiSGSNpr1rDXV1lU9oVep5NKnViNQ190oj04VAfFJrES+sX9cWuZb3hPUyaALoU3z++eEYlZTiU9EFmUE4y6j37arAlv3dmw+t72GShGQ0/+AZDWO77eXscTTuHllsOQ2CZoiJTQ3EXH5DhJLKr6r7GJ4295/sYsxfVbDJAo0daDA/8si2fmG9X9fWOriVK3ScEJ5CGclEL209vgNS9DyHndRjNJAWTl2oUOFodynzWbo0JlrLHXcNb97qVvr/cM1uTbWhpCpFF4SoJaNooUWo1OMy4xAGNOJEXf2/MKFrJLamCMzpIEaKwMkN0mqOr5Mr5Q41nZRSob1pkSCfi+j7nJtlF+PjSWdA5pR4B4/1SUE4JKyMkotn6vkeqaeRxky6oPflhSTXaNP8Ionl5HfR/vvBy7vypsdy3Y5tCTfMxQEBbcrmLdtusjY3orOBVHi7VR7yvnBrkm3IkWGOH+aiYVNjgNJX8rIoforHPSg81cYFzE3cNcc9UjBSgd/aW4Lwk94kM/SO/uKcjhBQPYleTzK0wBwu0fqIb83braePqvwIHGr2fF4J1aogBpnUoeBLVoOu+5giGRbS+dNrOf+59z2dWFjSrDJE7NTQ+6UBHuBq4DEggOJ1pnGF9Mi5IFWprUwXM3EHgEYWzNeMYyx3vmc3p2WrmNLjDooywrLEVJ8SSNTveS5XL7WV1P/F1BDe9F6VkpdEN278XmwkEtW9+DIxJla+7GnpOaBJ+mWzxN7LIS5N0VKpVOkDRednblyNxabSATibWdBEw82cQOiL+dxBIuZXMHUo9pkwrKBe5wNUIKFtsgWJrtwBz27CUOKGkEBdECtEatR/POzXWtRVUarn4bAnOMqvuc326/MGf2byh1lvlZTXU7qEg41i8b2wzl4Zp9x lLYdXxUH i11xa00nKn6QPpqJYCeywB691njLSZLNyyQtAUgZCzAxuVLX1rC2dDGbITDYTuPMx/yQUjZQ9o24nTpfEUw7SkPXCjwkrDw+crjsX6I5fGRotX8eDTf3JhSz+5a28M8gFGgRcEiQ4ViGpcgERKBJvl27xTVPnDglMSKbYqW3XMvUxsUw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 10, 2023 at 11:09:20AM +0200, Rasmus Villemoes wrote: > On 10/08/2023 10.15, Petr Mladek wrote: ... > > + prolonging the list of #include lines in .c file. It will > > not help with maintainability which was one of the motivation > > in this patchset. > > We really have to stop pretending it's ok to rely on header a.h > automatically pulling in b.h, if a .c file actually uses something > declared in b.h. [Of course, the reality is more complicated; e.g. we > have many cases where one must include linux/foo.h, not asm/foo.h, but > the actual declarations are in the appropriate arch-specific file. > However, we should not rely on linux/bar.h pulling in linux/foo.h.] Btw, it's easy to enforce IIUC, i.e. by dropping #ifndef _FOO_H #define _FOO_H #endif mantra from the headers. -- With Best Regards, Andy Shevchenko