From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE613C001B0 for ; Thu, 10 Aug 2023 13:20:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E2BA6B0072; Thu, 10 Aug 2023 09:20:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 591B46B0075; Thu, 10 Aug 2023 09:20:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4332C6B0078; Thu, 10 Aug 2023 09:20:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 28D046B0072 for ; Thu, 10 Aug 2023 09:20:05 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EB9FC140170 for ; Thu, 10 Aug 2023 13:20:04 +0000 (UTC) X-FDA: 81108253128.09.2570203 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by imf10.hostedemail.com (Postfix) with ESMTP id 37475C0017 for ; Thu, 10 Aug 2023 13:20:01 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=if+AKfB4; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf10.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691673602; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fmp0NCAT0sso9F3HDosxXjpBSPmGlaxJewcguxYp9Uo=; b=Q8OmatqPlnHDeaT4GiGR2HYf+icVJ5TZ1DfgGg3I6YPuq5bTusafK3ns5T5xVw3SoINTDK Qt5C+47hij112nK4HZ1aDUJNg3ep2T7/Gp/KFD0NIbJ5jxmxbA7ajFlvC8PETHBsJt/h7O tEXHf888LUNvV+++vOfwE1K8ohZhAFs= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=if+AKfB4; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf10.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691673602; a=rsa-sha256; cv=none; b=VWhI08xO8qLOoSB34qJz0+sOZqRuuZ/XM3pkPPQaGp7JpKRPtAFY8YuIBDf7On6kbRYgCm ZYbfdesssBlHumRdlO69kLSMsvc+VCGRWkf4lhFmnD4W/QYHeeHsMpTbeYDRq0wzuW/qAt 2aJeFQn6urIWfqumDefVeuPHC5gNvjg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691673602; x=1723209602; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xfr9hoyCdvcjawUTmlAUi0ntlYKYSB2P93/w2GOAF+4=; b=if+AKfB4IbMeqamW+mjTUu1fATRyLXvQhBkXt2s+fNOxp7IPWFH/vNly fTpy+TDSXXtCtdAB2NpUlVBkMm34J3bHPOxgRPq3Yy0fw5zKPKSbjT6ep 2lM2vQOcnctTlQiLdG9NlAJO2iicnl9nXM29gRO8DPJnoiQh+8efTHo5Z tcCWYov880xSRHFcJ/wbEhhrgwAFozFKGAX9+Qgpgkdk2GOEJZiBrKzXN qk/S5aAISgVEB1DDd3Lf6n23BSRDTXHvkC2ykkIuhZj7HbqyDWEvuK/C0 gzKQORLuUQCL6EcqxTRQjEBHTsm+z8U+khIME6Ko7LZHdEohvL3NQWYrD A==; X-IronPort-AV: E=McAfee;i="6600,9927,10797"; a="371393061" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="371393061" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2023 06:13:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10797"; a="822244413" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="822244413" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 10 Aug 2023 06:13:34 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qU5To-002GtZ-1Y; Thu, 10 Aug 2023 16:13:32 +0300 Date: Thu, 10 Aug 2023 16:13:32 +0300 From: Andy Shevchenko To: David Laight Cc: 'Petr Mladek' , Marco Elver , "linux-kernel@vger.kernel.org" , "kasan-dev@googlegroups.com" , "linux-mm@kvack.org" , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Subject: Re: [PATCH v2 2/3] lib/vsprintf: Split out sprintf() and friends Message-ID: References: <20230805175027.50029-1-andriy.shevchenko@linux.intel.com> <20230805175027.50029-3-andriy.shevchenko@linux.intel.com> <900a99a7c90241698c8a2622ca20fa96@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <900a99a7c90241698c8a2622ca20fa96@AcuMS.aculab.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Queue-Id: 37475C0017 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: i4xinft6xt36umqun53w4pu6q4xj1oza X-HE-Tag: 1691673601-205938 X-HE-Meta: U2FsdGVkX18iqoywomOBxviCpH/gf8aKRgQvnJmsCov9PU6B6lx9unSLzceExFvKQVE96fJpXXXR1cSoIYSZaDYkFjpqxY2N/8fkBv3hpFC6hQs3rhnOc4nhUFPHSIRcv1/ltzmyBN5/G2FbxwkiSNev7RFLt2ThqCOD6ATUHegASn3DUy2yFtNqF4viBPymMPpTJdaaC+ezun5sXcKb72e9bINtpxN5CJIa/lh/62k7z9h+63m9Z+wzcRXQ3BA1UfnJKSWH9A6IbiozmO3hsTeMLqJhGUGhUVR+gG3ba5RSiMQEXZwJgf4+4K+vPqMc/NJ1Hov6Gg5qxkQyIp7g6ZNk3bxli3oqZfBNjg2Eu0L8Mnhgm8I9jc3fPUWxXay2SgS6PjWxYxuazU5AQlIswGbjePsBZH4GEzaLA+3nnSfzP/xIWyxvFTU0nHCjX69npUbA30YzI3CyTXMETqmQEVcjw0aTUHxMqSgYjumB/9TyFglexleZnR4Dp2vFbjoG2eDG2B5Ftz7GKhwo8ZTjIYWAhN6Zo9ze3FgmKfiOoWgCUetnuu701R+c6ZyERT1anB3LW6Tx/S1ApvIzxvD3FmcgvSsWHEox9wFc9A59wXKoGBngzzWZG8cGGOeYAQUJvEpz4HN6UL8Wz2Rm1YRBp/hFSWrXfZHb712RjcEKA2tyzgdGfMiTzIkc5/7bfDs9q8LDIpQ94Jrt+maHZx1HOIE5NfHdErUxkykuZiL8JkbCBkWzDWnWPf/RBV0opcCmldEdbzcdS6hCPu2rBQjpXB0yjd3e5ZjFYNO1HJeK+Y+1Nf7pAt9yT0ogD62iRaeGX4FM2zs43pb5ahVzj4NUCnPhvKuiLrIAOhAs2/dkK48Que+8zpMwjSOsxAUh3kimALir85b1N1N+1naBq/uvui7g1IoTjS2aRWRVv2nSduCCyRhFn5uZAF4kIAGJPQQYGk4t2i/NOg4Wh39ccDN PQzXW95G LxPuTGYF83ndpXUNeimiH264pBYGjB4kG0CIHbYT9t8LOZR4Vhg1z0LPL1hj1lTVSVE2S/MPRxH7cW8rT0IH/Q5y9jpvIWIbrxzqL22SzWtIWOfBE34eIw6FPehJdTfAugEgAjAU6xOYpkJ/kOLWIvzttCn5/M/CSS2FaYlCwEefhyb5vq8wuUVnmERWEN4+k/8ZIkiwhg/6/4qipoVdqox9xiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 09, 2023 at 08:48:54AM +0000, David Laight wrote: > ... > > If you split headers into so many small pieces then all > > source files will start with 3 screens of includes. I do not see > > how this helps with maintainability. > > You also slow down compilations. Ingo's patches showed the opposite. Do you have actual try and numbers? > A few extra definitions in a 'leaf' header (one without any > #includes) don't really matter. > If a header includes other 'leaf' headers that doesn't matter > much. > > But the deep include chains caused by a low level header > including a main header are what causes pretty much every > header to get included in every compilation. > > Breaking the deep chains is probably more useful than > adding leaf headers for things that are in a header pretty > much everything in going to include anyway. > > The is probably scope for counting the depth of header > includes by looking at what each header includes. -- With Best Regards, Andy Shevchenko