From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23B77C001B0 for ; Wed, 9 Aug 2023 22:25:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C34D6B0071; Wed, 9 Aug 2023 18:25:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 372746B0074; Wed, 9 Aug 2023 18:25:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2397D6B0075; Wed, 9 Aug 2023 18:25:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 10BC36B0071 for ; Wed, 9 Aug 2023 18:25:28 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CE87BC0F0A for ; Wed, 9 Aug 2023 22:25:27 +0000 (UTC) X-FDA: 81105998694.15.793D839 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf23.hostedemail.com (Postfix) with ESMTP id 4094A140012 for ; Wed, 9 Aug 2023 22:25:24 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=5Fk7ox2Q; dmarc=none; spf=none (imf23.hostedemail.com: domain of BATV+3b1992ddb53268d8dbb7+7290+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3b1992ddb53268d8dbb7+7290+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691619925; a=rsa-sha256; cv=none; b=K0yJX51PqH54YgFODHjVFVVODQIItiD4sOz96wLQlanUiWXEnWGOYWG0q4YKW9Tq9VNi4l KAvJra8Mc6zgMm3886gvKmrXP+60quP5cvSbTJcqzMl8vrE7akJQx6cFM+ciBqGfCW8IPu WmqkpDH3HDyvG0vMhsyg2vhjk8zJiKE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=5Fk7ox2Q; dmarc=none; spf=none (imf23.hostedemail.com: domain of BATV+3b1992ddb53268d8dbb7+7290+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3b1992ddb53268d8dbb7+7290+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691619925; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3GN7LGqdTr6CnPW49m5sqS19cT6QuH9Su23vIXkae5w=; b=4fgFAXrh0yglWeV6GbjHBSvL8oQo7hcqX9hNpx941IHWTCyXylopfLhIbyiMT3jLF9kL6I 11oVbOiyvWm2MPGocjX0d+0Yn9TZDG+QAlhP5f//ec1uoMpGHFnHzwUYO/Kg8ove8pmmxx VNGy9m766eG0u5wIGdbNkkGBGiig9NM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3GN7LGqdTr6CnPW49m5sqS19cT6QuH9Su23vIXkae5w=; b=5Fk7ox2QmkiMrKU0ZB8zJUPTYo 3WYsHKPT/uZuXI8/Y+uOeJxlN3kWfZLRXEI/kzk0VXO7aqmoGqjokWX2sTffmaKJ4gHYTWaBxoRr9 cyTz27W1C1FGj44jDUKLVBp2C4PiCry3ZlzmBOa4r4XIDl/Xahr/96c60GoNlYaXkrLr7byGjt0FO /HZwh2zEirA+Olxz+Vl1bjIqZmYjUl22a/ILFZrNOZWAeEkZ5EvecldCNhv4YhZH6EBOlgmOviQnq SQ85bIR5WlOpUlv4Jce0PLiDUgvPrslN2dMSdSLcJzq6odEXxDD8RnSUHX2TtcR82G4GhAmRodwXx JDX8Xa8g==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qTrcF-005zKr-2x; Wed, 09 Aug 2023 22:25:19 +0000 Date: Wed, 9 Aug 2023 15:25:19 -0700 From: Christoph Hellwig To: Alexandre Ghiti Cc: Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dylan Jhong Subject: Re: [PATCH -fixes] mm: Add a call to flush_cache_vmap() in vmap_pfn() Message-ID: References: <20230809164633.1556126-1-alexghiti@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230809164633.1556126-1-alexghiti@rivosinc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4094A140012 X-Stat-Signature: n8o8gkatnfo1ujxg5e7515ogfcahbj1j X-HE-Tag: 1691619924-64050 X-HE-Meta: U2FsdGVkX1++ttdATMixdmtFwRFMSxduvlU8cEobdrwfoqrnnxyK9xnTTuQuDx04t8k5m1C93kOJoKo33Sf+0kmCxfA/J29+eA6osmUXsp8EGOy6FsX8eCT3b2rZNhZrI7Y1jMo8RkHIwNAC5vHruUumyVCR3WUOb2dJDBXufbLoFdleAxVeZiE7Z43sXNTEZAGLFNdFHoUTnvvDGX0l4Sjk/WkcJQMCbPe/qfjlzK5Op66ovN1DanMxIbYB36mi4MttkqAl7+zSOPYVWMI+dGa43LHNmPRCLgxp4eopqACxlalTuTHfe5931u9lfohL6yrShQmcCKOT8OdcmG6OzPfVZdbgXQKxxwR1DuJFndoEf+O2FQY3XBy/3VgLLaJONHH6DV+F70VBvEfS4IRCGMnFnfWsx+Edhp339xDsoLmUYbKuDBnKDPe9InOfttM/6lWBFXSZYh3mRTxqWeB24rm38sE1jtD3I+SRaBI0h1UVcjdCQ7cTDk/CYMupGtmSUIkYSB3mhuVwp7Je2HHR60SDTLyjjeFPOwyR5Yy6cWnqV6lxUmODc6I/JXtcpzD0QBtsFourWuGyvgQwQ5Zzq+NiXqNNBl0onz2yDCqtnE7M8LTF2POAK7lMHBM9QYO+kBL4Icdeln+4NjnkDJaL0YxuW6HDYgxaCpjgrmPsu2K+l4HzKnT0OPttAoMe2i5QDBBjtwDii+TgMDQik5TRY6l4VY8ySsi/ZzYqqz6uf9nYS8GOdyrXKsqqBpm1VeKNi1NsroVF4FzmVqvYhCBIdVl5VLIQsLpID59zpSn7zKQnoO2Mt/Cp207F9XSfIsVbfIdfvhA8XCi6EHyCnDjBo4WHMEYN8JUILm2kPuzR5ubU+yLjgrVOOqi7v0n7wtWJzuzBr6dhY05MZBt8eQNobXN7BYBv5jgBxSE/P7LnGGBPq+k4wXaXOVbDl3Bc+nYX3IfyjIN6C2i9vqSriTz e2obkJRP MT7ehg111hdxl8ELjnO4/Ev2nbHLCI7osW/aPMo4Ryp2fjP0rc+JtkrPfY3F2k+7Vz8Ufffa4SbKTTxP7ucpsc71AyqjAZL1RkKHD3wjXACnbM52ZriYMto1rmTO7cohnJCpevQz2dziK7zVuH6m6hotHHLzqz4JnJ9SebbSCLs+eaW52Ovgi1ELDdpqqWqb87dV3dur/eik4lW8yXyGtfHzPGUfhKWYLTrLPov2nyguBfZYcOuz3+x1FBgqLghNAHmaAEwZkEPKw85nxMiYdFM78hjgmBwXO6fHhHVlYsy1RIpgzjyNmt+6NY64o0umCSdU8V1VvULh0JseDMMfTJClTA9FEM5x7zgWGUuaqmFf0QEjzZKecI+NtCBaJCP8oeL7HXXF5pNeS7N0HW6AtxeRWHqu/+O/xjO/HZir0l7VxLHX1sKKGYypUdg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 09, 2023 at 06:46:33PM +0200, Alexandre Ghiti wrote: > flush_cache_vmap() must be called after new vmalloc mappings are > installed in the page table in order to allow architectures to make sure > the new mapping is visible. Looks good. I somehow vaguely remember seing a patch like this floating around before as part of a series, but if that didn't make it it certainly should now. Reviewed-by: Christoph Hellwig