From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46117C0015E for ; Wed, 9 Aug 2023 13:41:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A40C26B0071; Wed, 9 Aug 2023 09:41:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F01F6B0072; Wed, 9 Aug 2023 09:41:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B7ED6B0075; Wed, 9 Aug 2023 09:41:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7970A6B0071 for ; Wed, 9 Aug 2023 09:41:48 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 514F51C9EBA for ; Wed, 9 Aug 2023 13:41:48 +0000 (UTC) X-FDA: 81104679096.01.05B8F9E Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id F1FAB12000D for ; Wed, 9 Aug 2023 13:41:44 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Bd2Opyaj; dmarc=none; spf=none (imf29.hostedemail.com: domain of BATV+3b1992ddb53268d8dbb7+7290+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3b1992ddb53268d8dbb7+7290+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691588505; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3TRNqmcaEGWcqiDRqyA2b3ib5K8DQ6i1timI+5pEw34=; b=o7Z+MRV37ZSm7gT3opV9DxUBCrAbmgQq/YzApL0KsNdKpwOt2aj5S1mrIfpjEvUe6Vy7iT EVRFYLaRRnbLVYfGtEsxJfbHDPkVmQ98angYKufIcrHhgMkGtg7twqRKzqTplikq2ZkqAi 0fFoxYqbqMbrO6J2+qqMY1/x/QZYWEU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Bd2Opyaj; dmarc=none; spf=none (imf29.hostedemail.com: domain of BATV+3b1992ddb53268d8dbb7+7290+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3b1992ddb53268d8dbb7+7290+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691588505; a=rsa-sha256; cv=none; b=hQj+MWDmPt9ZNODMFaQRCLy9ztVy9CHqp6eKVYvWgv4ERS4WMJfqEOvMS2tXRCh2bS4Tbl p81/i4m4Q7As0xnZ0gwL7ac2DMQcjqO/66pVA+KIXqMXar/w2kX4Qg6eT1TIYHk5rNC2GO Ik9ckIwvXhdrIIJRFiXX8JGEeh7B+bg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3TRNqmcaEGWcqiDRqyA2b3ib5K8DQ6i1timI+5pEw34=; b=Bd2Opyajb45fFr2wKhQzsXDLu7 mnzwHp0JaARZ+eAmLjiv8nlwo14v4YA6lEdxQBGD6aBAjB0kflFxrzMBWTd4PGLn+1uxy4ncjbRH9 7hnljHdlosVjZWagAs1di2LuKBAe1c/LQD8CSI8SC0KiQ2MWBtY/CKJDsdx59LO7LmqRB3ufMiUH+ H4OtiIQUmeGBGr5lpdxbDs3+ynDbwCZb3eiaRW9pnIvDRXOWAlbEkbDp7+AwndTXtNkf38uVRifI3 WgtTOoS3ymngTQNcQHJz7da0B4s5U+/IeRhb/pgUxKzYzcEJNj0djhFfl1Uysu1jL4qABLDjFkwIi qUJMRQhA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qTjR7-0053pV-30; Wed, 09 Aug 2023 13:41:17 +0000 Date: Wed, 9 Aug 2023 06:41:17 -0700 From: Christoph Hellwig To: Hugh Dickins Cc: Christian Brauner , Andrew Morton , Oleksandr Tymoshenko , Carlos Maiolino , Jeff Layton , Chuck Lever , Jan Kara , Miklos Szeredi , Daniel Xu , Chris Down , Tejun Heo , Greg Kroah-Hartman , Matthew Wilcox , Christoph Hellwig , Pete Zaitcev , Helge Deller , Topi Miettinen , Yu Kuai , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH vfs.tmpfs 4/5] tmpfs: trivial support for direct IO Message-ID: References: <7c12819-9b94-d56-ff88-35623aa34180@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7c12819-9b94-d56-ff88-35623aa34180@google.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: F1FAB12000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 7ts6saqctsf44ortrnirrpg3xi3esmgm X-HE-Tag: 1691588504-864319 X-HE-Meta: U2FsdGVkX1++AIPdwVA9XN8fJGO6QDWico8iXiO2EieM6fA114uOgmads1xViGfira6rqMv4Yb/EFBSFnAzKF/7BvQqF5rHBVyl2Ta3nJ5dl5qouHGX9WzRZktFv2yiQn4K/KCPOjBQ9bhNBbIAINOXOvUyJ6iIoPrRjJU8mM+Fo1mwtlnl+zp5Gm01ZkbOmgF5qL8uw4HMaZgL1MHKO/NlslQxIIQaZzbLk1LKYwvP9mxj/FDTCfIIWtRjn0O6HCBoIMZGw9+DeGuWlzyhY+ZLGzPa/fRxjJCHspqX5y18mZ/JuuCiCGrQvePWyeGjB2lsI3zg2I5N1Pjk/tAb5OLec9JzN6FOT+zsTQRNJi5tsT24Ttk0P/1FZWAzY5TkhxjGXwYFNNULJaWuBq91Bh9FJKnKB+sWBSGQCdB8FbWRw/R3oEQtKLPSpTqd+7RMFcN9nwiOlQeecZZ7lxU9J+bX1LN6ht8eUh/0ZAb0EhZfaW93C8U1c+xEdg3Zj8flBlID6R1zyk4E9UGQ6/fmcEFGz21nSxFRio3JB3zQgoFd3xsWLtlbouJ8QjJsNNml6UakybELo82mm2F1atG5DMS7MSQVjoSXeP00kEzy18ydjSSoQFzp8lX+L911kVrRoWdjDbjWkKnu4oc9OWDRfCon/M5oFKNvNhh4dA3s8yYjimNl/SudoGUrbmO8SGiYdk2iUjqnwIMeblSMVODNYnxQK188+lmGlai/4+ZOqT+mug5pzPIQ3v0iQnCIZqiafohJAkpVrNwZGq2iA3cSjgd3oka/T2ovJ11Gf4p0wpRSJLA4bxf0Bl9zGDxBwi0OQMdwvWf/2JdI9XaPsW8LnC4Q9zZnjC4FusqN3rKF3vGMfDuXunRQA5+THCkJ/C9hnIHijYQb3rQRNWvSLE8WVzbIj8oIViEwuklu16qjmvQonUfK75UzwyGcOCvKU71hY+ozWiPg43lsQXx0Sbqm +ii8a8Gx pdvl3hFG2ayfJidPMges4edEARMvYlvakd7YVqyub713QjRmTUOUBqFSUcNYqrMVk67fqwgOtFNhMfphifE0+GjrsRuAeewVxufETEM32KZDLlYMWVQapHAiM3jaEUfzBqcMtCxalUsbK23hgJ7hA2b/uk9PZykMVHNGQPhHMSF4aplpX8TIrkyrkgxtZ4Bz8qQJztbKE2xWR4upWutulTAMK5A9VnoEU1AptfWsiwgLJLymJHKZMTVRWlmIfaIoyk655FNBluKKDircYTLAStGBGyO/SAXODGIssiB4OS14dknmkkiitWkvWBI6DEQGEewu8RNkepY3Nubp6IKYMPb/VdgRK9FLvuE+6GKgGa2Q6aZr5Cw5TMCmUDbx+b9p+tjPeqorFSjILRDdZzslJ85xULSbfdXeN8bj2mkcrl2Wc2jMSCeEyZR5N+I250MlKDvf2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Please do not add a new ->direct_IO method. I'm currently working hard on removing it, just set FMODE_CAN_ODIRECT and handle the fallback in your read_iter/write_iter methods. But if we just start claiming direct I/O support for file systems that don't actually support it, I'm starting to seriously wonder why we bother with the flag at all and don't just allow O_DIRECT opens to always succeed..