From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5F90C001DE for ; Tue, 8 Aug 2023 06:41:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CB0A6B0071; Tue, 8 Aug 2023 02:41:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37B4B6B0074; Tue, 8 Aug 2023 02:41:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 269928D0001; Tue, 8 Aug 2023 02:41:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 172F76B0071 for ; Tue, 8 Aug 2023 02:41:56 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D4296120965 for ; Tue, 8 Aug 2023 06:41:55 +0000 (UTC) X-FDA: 81099992190.29.4F82F58 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf26.hostedemail.com (Postfix) with ESMTP id B70EF14000F for ; Tue, 8 Aug 2023 06:41:53 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=jOO7Z6NL; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf26.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=pmladek@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691476914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fn8p9+Au+wVsN8+8boY+m/Rgvhm2LtPNdNtgtmsLtSc=; b=G9TjM1wg0OuIikBiP/1OxrSc8aOb7EySHITInYdIM/OZqEPqtyo/dlhJvWB5PI87qAr2UT 5cKqKksC+iJ+OdwGzCsFxDp+fgFBRGEqvs25nJ/2cxAgreEQv3/l/NmXF4KvWJlzMSi3Aw FPBTm9zTfD5hT88L/3yeu6uvodf+qa0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=jOO7Z6NL; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf26.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=pmladek@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691476914; a=rsa-sha256; cv=none; b=bdj7dAUaowUS0DDIwVj18nDv1CvOlBVGcFP9ts9q4LF6b0vfQCbwDtQqs9e5QErp6thMte UxBEkMcR1+96BYYdkR3hGLc/U0XKZRtZ2B8cHHwuKwqxd/u/BEiTEBk6r47UG7TexmURoF pw8LTrqYH0gGEgPjy9ajV1Qm8kszqnU= Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id ECAA622471; Tue, 8 Aug 2023 06:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691476911; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fn8p9+Au+wVsN8+8boY+m/Rgvhm2LtPNdNtgtmsLtSc=; b=jOO7Z6NLzc3q0XzXoZY6QPquzaGJhG/91JeTEmGVV/bplRZVFBhdLXHgDmVD37usC/5hxc 1sbFRFI+ee2skGmgpy4iC6KaC/XcArC2zNBk7u+4fnkDozwacTQSWfjY+wwVwn4YuPUmBb LeE3BO6jBuPTpBMSDFQGPj8XvYJeARQ= Received: from suse.cz (pmladek.tcp.ovpn2.prg.suse.de [10.100.208.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 5CECE2C142; Tue, 8 Aug 2023 06:41:51 +0000 (UTC) Date: Tue, 8 Aug 2023 08:41:49 +0200 From: Petr Mladek To: Andy Shevchenko Cc: Marco Elver , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Subject: Re: [PATCH v2 2/3] lib/vsprintf: Split out sprintf() and friends Message-ID: References: <20230805175027.50029-1-andriy.shevchenko@linux.intel.com> <20230805175027.50029-3-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: B70EF14000F X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: eckq31chh41k6bgpy448z1fhzd33xz4n X-HE-Tag: 1691476913-630798 X-HE-Meta: U2FsdGVkX18miBFtrPe181olNs6eF6oOCgA6T1EpcAWbMcl5jLs2TIanlICFIUDTLxdO3e7HIDR5jEyV7Zi5EFXO6M/Try0JmxCbwkcPNGu0NqIyDl0c8YSkxbrDClwvkXhComzWX3gIXbd3kUC4N/+B5ba9al74kSoH9q/1263lnACTeGK89lgSW2HmP2FEhimaEbO0c+v4TQIS7UmOcCCgPcGNhY10E0dL65PKb7KZsNnqj53l4bXbjxinWa5yk6EMPA8xnEo18cPYwBWQ/MnDRzBUQ4fuVAnENh3i0UKHWF8JMK9AsYmOO9SKYap1Bu4xXSAzheW7435HfqbSfKCUFnzTRSyzWdDkMCKIdpAq7d2nsqyPAP4lnv9skj1IQ4DkXOGaVcjQ3bo5LfzCXysm39SmcKFb2buEHHHI8mq/poIXoSWngY5PsI8sIb1N0iCpOOVPaVbFBLZR9aGdzuOx6D2+2tlDw6WdUxVLSIdecRydzufFicWbAAryw5UeRLjnLPeCm6L1sCzqbQU7PR4my1L8Sw0VN2RcMishKD4zG2wj6R5oGq4cqptxwUz4Ui5PZ2zx2a/VS7RLW0V1eQolTaoV7woDOgul9kqJCvQ54UuYGvtOSoTWd2uO6RTekevXXE9P2m/G1hPGOAl/W8AExB53m/8UOIKSwMpT11k5WgSMSKhvB/zJCUuwQet4Gt1Ey86IIKTk+5XxokgxAxe3Qki+1EYQJWWnnMydRzIfZJRuyGpJ98J5wYMcKRyxX7I+xdFqrtNOTtDGXwcqku4Yx5MJz5z5nU6ZOYekmqvU7xYDcxeFiMr1dIPtumZHYX+zYUVYrLL9NE8qBRET3FIdzZRqcfKoz3Q+DDUXgkpZs3Pnze0s7jMW/J9SQ/Khy/u1CCL2ao1lEt/FD4KCpvlenuM5sQvOJrzBD/lKnaw28ePCGqpQDx1PyrMDRsbreXxB2sPBBAkWJjL2TUh ZriM1ibK 2CZ8wAuhA+MlX/qeX597cVaOs/2nMRREMNjT/D2k0nQoCi6a1hoKuJbSzXdOXGeL5Q+q5dr2D66BXItVzp1zlcXa8MVg63z8ItMeOnbUdQbpeK1yDJbIbP/VwJ5YBQc/li+/hJpshozMUwagI/4fhHd4Iig== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 2023-08-07 18:13:57, Andy Shevchenko wrote: > On Mon, Aug 07, 2023 at 06:11:24PM +0300, Andy Shevchenko wrote: > > On Mon, Aug 07, 2023 at 06:09:54PM +0300, Andy Shevchenko wrote: > > > On Mon, Aug 07, 2023 at 05:03:19PM +0200, Petr Mladek wrote: > > > > On Sat 2023-08-05 20:50:26, Andy Shevchenko wrote: > > ... > > > > > How does this sound, please? > > > > > > Not every user (especially _header_) wants to have printk.h included just for > > > sprintf.h that may have nothing to do with real output. So, same reasoning > > > from me as keeping that in kernel.h, i.e. printk.h no better. > > > > (haven't check these, just to show how many _headers_ uses sprintf() call) > > > > $ git grep -lw s.*printf -- include/linux/ > > include/linux/acpi.h > > include/linux/audit.h > > include/linux/btf.h > > include/linux/dev_printk.h > > include/linux/device-mapper.h > > include/linux/efi.h > > include/linux/fortify-string.h > > include/linux/fs.h > > include/linux/gameport.h > > include/linux/kdb.h > > include/linux/kdev_t.h > > include/linux/kernel.h > > include/linux/mmiotrace.h > > include/linux/netlink.h > > include/linux/pci-p2pdma.h > > include/linux/perf_event.h > > include/linux/printk.h > > include/linux/seq_buf.h > > include/linux/seq_file.h > > include/linux/shrinker.h > > include/linux/string.h > > include/linux/sunrpc/svc_xprt.h > > include/linux/tnum.h > > include/linux/trace_seq.h > > include/linux/usb.h > > include/linux/usb/gadget_configfs.h > > Okay, revised as my regexp was too lazy > > $ git grep -lw s[^[:space:]_]*printf -- include/linux/ > include/linux/btf.h > include/linux/device-mapper.h > include/linux/efi.h > include/linux/fortify-string.h > include/linux/kdev_t.h > include/linux/kernel.h > include/linux/netlink.h > include/linux/pci-p2pdma.h > include/linux/perf_event.h > include/linux/sunrpc/svc_xprt.h > include/linux/tnum.h > include/linux/usb.h > include/linux/usb/gadget_configfs.h This is only a tiny part of the picture. $> git grep sc*n*printf | cut -d : -f1 | uniq | grep "\.c$" | wc -l 5254 $> find . -name "*.c" | wc -l 32319 It means that the vsprintf() family is used in 1/6 of all kernel source files. They would need to include one extra header. If you split headers into so many small pieces then all source files will start with 3 screens of includes. I do not see how this helps with maintainability. Best Regards, Petr