From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53C2CC41513 for ; Tue, 8 Aug 2023 08:21:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 991EE6B0071; Tue, 8 Aug 2023 04:21:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 943386B0074; Tue, 8 Aug 2023 04:21:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BB548D0001; Tue, 8 Aug 2023 04:21:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6BF646B0071 for ; Tue, 8 Aug 2023 04:21:50 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 26BC3160C00 for ; Tue, 8 Aug 2023 08:21:50 +0000 (UTC) X-FDA: 81100243980.17.78749D6 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2055.outbound.protection.outlook.com [40.107.8.55]) by imf26.hostedemail.com (Postfix) with ESMTP id 7B70A14000D for ; Tue, 8 Aug 2023 08:21:45 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=RgX4rGtK; dkim=pass header.d=armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=RgX4rGtK; spf=pass (imf26.hostedemail.com: domain of Szabolcs.Nagy@arm.com designates 40.107.8.55 as permitted sender) smtp.mailfrom=Szabolcs.Nagy@arm.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691482906; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WhR8nzJDi67Jj8GJ6kQuQ/Dk3+OOFzE7ipPT91oq0YY=; b=dfrtwfEznezloquVrL59s5Lzqcgr4FvYEh8hMOsIgRvD/IXlc62/2nD7Yf7dQRc34gMbuP 4KjXbxdHepTLjslYCL9AhYzEJPY3GQhtBWI8sd00ryVdAmszxzYtQGHGZR2Asf4FjOeKKJ i+7vca9lc/dMUGro5M1v+PWvkJm3Ab0= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=RgX4rGtK; dkim=pass header.d=armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=RgX4rGtK; spf=pass (imf26.hostedemail.com: domain of Szabolcs.Nagy@arm.com designates 40.107.8.55 as permitted sender) smtp.mailfrom=Szabolcs.Nagy@arm.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1691482906; a=rsa-sha256; cv=fail; b=KDmUNzHyBdyaF5jCuyAeLgJaCDiJ/TSWGPuYCc5jbbjcPWjmfDuDVQBzrmyVbvTfIG2ehB HS8QT4bwnygcgg1Pk0lUKiPxrVuJB3LMLyc5WvrzKgPXqVt6Ksx1VnWAG+rOvmLTBQLyto 1VYl55hUjC7CwyWWJZaWZvMgev/pijI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WhR8nzJDi67Jj8GJ6kQuQ/Dk3+OOFzE7ipPT91oq0YY=; b=RgX4rGtKfTMK3etolpqPr4/tFK/CapLJEqPkb2J5n52ZtSvlnig7vFKHqqkcxl7gYR8CyYGBcPoXMAtDOff/3IHRnhwPhi++yGGXSX4hOREFmpO/rV4Lkzl/UQ1E05FZewzrSg+bsaK3fpMBuYFlAmVSMpuP77BqWMLocCoPYTA= Received: from DUZPR01CA0252.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b5::22) by PAXPR08MB6703.eurprd08.prod.outlook.com (2603:10a6:102:138::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 08:21:29 +0000 Received: from DBAEUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b5:cafe::2e) by DUZPR01CA0252.outlook.office365.com (2603:10a6:10:4b5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27 via Frontend Transport; Tue, 8 Aug 2023 08:21:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT044.mail.protection.outlook.com (100.127.142.189) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.16 via Frontend Transport; Tue, 8 Aug 2023 08:21:28 +0000 Received: ("Tessian outbound f9124736ff4f:v145"); Tue, 08 Aug 2023 08:21:28 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ff87e41f44a6bd0b X-CR-MTA-TID: 64aa7808 Received: from ea06c7611131.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E6AD5EB6-09D2-41A7-AF28-C91632198147.1; Tue, 08 Aug 2023 08:21:22 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ea06c7611131.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Aug 2023 08:21:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=deQQipEitUkSFn+qABM+3WJnKbOU5xLfA4rGltgF06WPzotVuxQb0b6vfbMkE2lbaWmVn0HGAuL6KS+/gIwBENpL4GSJfG0Oy21Y/tPI5sqPunTzp+QblZmSvmF5EjkPzHEDe1LFCoVQoSV5DqzvaelVFq2z6kXNMM/gGiY91IStpya+IOE4GS2iN3waf1bvo0X2Mga0N27OIofr9YbIX0AoL0lHoy8ZIyVA3Sb3KawEdTJJEqtnKbp+Vj0mXX0GaZgx/1avFfP/f3UYTA4AxazDiysZEWb0FU78wxvqp8xEdld1QVTPoEBN6j/4i7OelpwV5irduEbbYAU833185A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WhR8nzJDi67Jj8GJ6kQuQ/Dk3+OOFzE7ipPT91oq0YY=; b=VdxkacirVL0JeQf/5A/MwPGoZjXZczXN/eDtyAa4beLBgsg+JNtmuBxDx4Ioih1KhUJQl3qgI2IspDKbFeqxPGVP5ml30q+iC+9CvwTbSf4oRCiHNaYwgE6Kyrf1zO8tS4bR31P+T/Ph0t0FM8HxWhTLKageiezMGXyoIP+78CaYiYTsnm/FVbVP6/PhYcM36EpYzL/OMSu0DGKWAvyC9dMekbkQDWpTGx+Bp2Yieid8fedT615urcJ06YRdOuFYF9OK2LISj95rC7vNzWqoSFgIc9L6lMc/iKuMOxr2pPeTdweC8WKHMbbK7XMzXG6pTKso4IkRWCPKLThMvGhKHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WhR8nzJDi67Jj8GJ6kQuQ/Dk3+OOFzE7ipPT91oq0YY=; b=RgX4rGtKfTMK3etolpqPr4/tFK/CapLJEqPkb2J5n52ZtSvlnig7vFKHqqkcxl7gYR8CyYGBcPoXMAtDOff/3IHRnhwPhi++yGGXSX4hOREFmpO/rV4Lkzl/UQ1E05FZewzrSg+bsaK3fpMBuYFlAmVSMpuP77BqWMLocCoPYTA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by AS8PR08MB8468.eurprd08.prod.outlook.com (2603:10a6:20b:566::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 08:21:19 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::adb0:61cb:8733:6db2]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::adb0:61cb:8733:6db2%7]) with mapi id 15.20.6652.026; Tue, 8 Aug 2023 08:21:19 +0000 Date: Tue, 8 Aug 2023 09:21:03 +0100 From: Szabolcs Nagy To: Mark Brown Cc: Catalin Marinas , Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Kees Cook , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v3 21/36] arm64/mm: Implement map_shadow_stack() Message-ID: References: <20230731-arm64-gcs-v3-0-cddf9f980d98@kernel.org> <20230731-arm64-gcs-v3-21-cddf9f980d98@kernel.org> <3a077ff3-8627-4337-9b4a-6a8828eda0e7@sirena.org.uk> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3a077ff3-8627-4337-9b4a-6a8828eda0e7@sirena.org.uk> X-ClientProxiedBy: LO4P265CA0197.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318::13) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|AS8PR08MB8468:EE_|DBAEUR03FT044:EE_|PAXPR08MB6703:EE_ X-MS-Office365-Filtering-Correlation-Id: 681246ad-20af-4a87-b2b4-08db97e87704 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Ft622fNMGkEQ6+U1Ce0LU6Aq4negHwuHPibsTTSdzyK+Biad/755YGKa6pq5qUSdpsqDafb6SVQuq6m2l8mMxammMVF15MqfMb20Nxehvrbijcx1bvFbWh6OW2HZn7dXVHozhsE3mUV49GJO1p7rSRGs6n7X4Oh2f4XiR/7agqAYyuRGajGpCMCsJTCaXed3m32sy3+gRTxkYZ4XdcIokUZoBL6c4EKdXlxPqK7LbLjCgL4IWsgzUZV+lOaLjhlxITZGXui0Ol+AcPS4mU+VEFwtvA5KLBQgsvDeTEyHCJWv21CG75G8tnlc0vMdlTBmBR9/iwLlGE40Tudyy2UonNpWVIjhnEbDK6esI9cYiWBBfeQrkA1kGjE4MMm0SujeI9qeHLrdGyeKOk9SVaalSF1DGh+JVWcdNDZXR+eCL91C3/CeCcCa2skQ9v30dgN162PgVDR87srpDLNiV+WIkZeOygyGwvRevGp4KUf7uQOGvzg5zLR25zrCDYgRYIhZpaNcvw2oWsxFFt9niZPBNdggshVvnaKYILWXR9ABo/AMsYoXn0IXCMuHccgzHO0xP6SUrClzkpHHrHMVJ6nWAFsHm8e1ZQMpnPL8sYMRDtZUux8pImG1zrbKxKrKCHRnw9IA6Sn+35V6vQxyzJHEpQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(396003)(39860400002)(366004)(376002)(186006)(1800799003)(90021799007)(90011799007)(451199021)(2616005)(26005)(6506007)(6512007)(6486002)(6666004)(478600001)(54906003)(38100700002)(36756003)(66476007)(66556008)(66946007)(4326008)(6916009)(316002)(41300700001)(8936002)(8676002)(5660300002)(7416002)(2906002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8468 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d408608a-4334-4b70-2817-08db97e87015 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6IjPAOriI97yamYIzt+1oCHXXQUxE8Z9HgoPrDhM1c5ZLBkvSgZDlwQHvRdniqA3sm7ofyj3p2FE+eelySkV7lPDECUtekQj7UxnRhmNvZM5DlK7DI9rL4FTt001+s8hDaELp2WAYI4kTz+K2zXtzBEwUD7lCdiLFEdbgfZktDbL1ukLaLYa6noerJTrl03Se8somAEd6/MV5Sh3DU5PPu5jT6VNKt5kACg7303t76z8PK0iOT3aHIzkBTUbMRaJfp0IYRzyhRhp1WR5JeAIoCsAzUubhHidei9sFplvfwpeJIsEjCzluqKXU8ZNmHjm0czPlx/8TIY3iYCZ/Q198xHnUb0Q2Un7ygBGu3O0HOCu12WoWwYp1jp4id6YqfNqyDBIOfsm2+od4Ux1h+sv4XM+03IiG/o+Mjdn63m40cb3j9qhnPYTZWPXeCQLCNw++gjXI9QQtRf7THocImoIVqLSi639Ize8oAX4lE7EX7sEhHnqrEADWK22CwTwlnOfLNSQOZ8w0ENHE01xzvVZg/rZ8pecFmJOTr61eAzni1Rblrnv3P5es8GJGuzu6bK1pxBcW0rswRJpcjIETCuhgqT2wXw23kmgOYjZpUYlFu2v9B/v/TrBuPe5E1gjw59wUCVu4yFdd9mlgFFwtHdisosyDiyXwhaBxyZMnQapJf3+dA2qfF2RCJ40l03SmFlgp1QyxkiMZ84YhU1+T/uIh+PrbXiYy2dvhmgtIPwHoY8AYUDsTflFlT1RZtoRXdSvPiW970yTcVldA0BV7m6BZnNEh3VU5gJAMTAlZKQHtyqc6t2I9e3xgCgttgsbYOln X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(136003)(346002)(376002)(82310400008)(451199021)(90021799007)(90011799007)(1800799003)(186006)(40470700004)(36840700001)(46966006)(47076005)(36860700001)(40480700001)(316002)(41300700001)(70586007)(70206006)(6506007)(4326008)(6862004)(8936002)(8676002)(26005)(6666004)(6486002)(5660300002)(6512007)(478600001)(54906003)(86362001)(2616005)(40460700003)(82740400003)(356005)(81166007)(336012)(36756003)(107886003)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 08:21:28.7904 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 681246ad-20af-4a87-b2b4-08db97e87704 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6703 X-Rspamd-Queue-Id: 7B70A14000D X-Rspam-User: X-Stat-Signature: a3ohxqmram5wph89nt7z39gsft8gywot X-Rspamd-Server: rspam01 X-HE-Tag: 1691482905-960384 X-HE-Meta: U2FsdGVkX1+aCFyEhJ9ua0DKyhc+h8U5PX05aEuGGSss1hAUNa0CcNxkIy5le/jkrWKPV3aVb+SUtoXoj3WYiq5PZsNoBfByR88W55XDgvj11GkUU2wNSCfslmbpNP1alwZdEahMtKoLoBhg/7+BFBQWtiq+Ocf5Yb3mZR40dE7Gf36P6qADaYk9gv0cHl+1M3k5xeTcbdMbNLTHlGvj2lh06nMaG6EHKU75MxN2qMuubnqx3CIZyXtrMHLBPMqSFlofmDLwGhZJXeqSQCa8G602ZmqnlCryxKHzoVN8HkyAKR3IbxGA/cSjEvx488Mem7V2+jm+nA9iL3pVStZqMLtCgrolTaIkpbhZOfDAA0380vSvBa8LIsDT2zhbFkJHY38bk0P59U/KsdFgkEK0sMCojFzvF4bUW6mHGkWiXBSfTVH26cNvSy7CIG+nz+icwyr3vA7MYZvB2yLxNSF6oIquEOjmMAvFLD9lI4eJ33DcFDR4lQH6Bxhk+weaK0rOY79snvF/vG976Xl7cjJS5p+XEO8vz/tMuOhGrdj+WETUiAVpICnT/+K8b+UPtXebB+3Ow/oeQIOvxvxDNUyxLQAEMiSGan7DqtrlBspC4UiBPfdLrwNLE3eUUjbCWEPNlQ8eqUFjD7ZuxMyDvIwrOrOBR0QbFuvt5FApjlYKeNsX4cVEsLWax7SrP29pTumHTQ1FneOyHsIH488RcO69n0eQfBGdsJFQIfXr3c4qTWKp+9Lov11KQX3DXp9xMSrgt488+suB+mLSNaeF1Oe77Dm2nv/8Xcspmrp3X8olpMByagKjpKOJAQ/SS/rHiYwOO3YyBz4X6WydeqjiNPFYbJ66G1gwSA+9LwaqxwVbQ/DG3PKhyRbSBhiRdMVvqO5wHWLyBMGHTghbFwII1sQbhFGozfpeonBva1zKeGfHuYXFw4VUDZhxwzo2CvpRqyjI0tN5p+YiaZgDiXgDOCt IsMEyhLG IA7WUEzH2Q+ND0SaVtjzIMO3gsazXYInqcShuM3Y7GKBhsQRfE+DyfRNswUlvGFweSzTopFGCRjj3sYkBO92vWjvMW4KWQm8CBMmPOlorfj6Hrg/B495TL3A1NjYJC6b31FPbqXy2oHLFjV1QOL77+WZ06I4UsTu2y4UY4LSVKlkLk20UD7pJ8c3wt0wT2UjWIrRPij5NpEF4CvAulz8NDuyR5UHxxocy6DL9UDU7SbltbYDACsotYZU+MWE4X0wnsIVzzvRC8vi7jjBnplYw+1s8wyaO7IX+KoHL7aSwRasDyqCI2ZwfnUn2EeTcHMxLK12VpEMb0sNsg0N5Mf2G775mEsm5hOZ0x6uGQS16Xa7hjQiTlXI709u1X5S+aHA6reSEpfJX5g/QVmFJCP097kfd2G7weC8YxdwGLf3stEGNYBWp9RTP40hCpz8preLYB2moMA7qOKlNK0YuMwGAWYh3QTSGbdkQ5yc2wrIy7WwuN5duJnqMdFcq5UL114De3AWCMlcIqTcx2eReSYg5uxWLChnkzRfiGaySUItcre/MPA1HEm9ibNn+38OJjaW/VhfSYeg8UvylcJKsuqvb6jr2Rw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The 08/07/2023 14:00, Mark Brown wrote: > On Mon, Aug 07, 2023 at 11:20:58AM +0100, Szabolcs Nagy wrote: > > The 07/31/2023 14:43, Mark Brown wrote: > > > +SYSCALL_DEFINE3(map_shadow_stack, unsigned long, addr, unsigned long, size, unsigned int, flags) > > > +{ > > > + unsigned long alloc_size; > > > + unsigned long __user *cap_ptr; > > > + unsigned long cap_val; > > > + int ret; > > > + > > > + if (!system_supports_gcs()) > > > + return -EOPNOTSUPP; > > > + > > > + if (flags) > > > + return -EINVAL; > > > + > > > + if (addr % 16) > > > + return -EINVAL; > > > mmap addr must be page aligned (and there is no align req on size). > > > i'd expect similar api here. > > That's not what the manual page or a quick check of the code suggest > that mmap() does, they say that the kernel just takes it as a hint and i should have said that i expect MAP_FIXED_NOREPLACE semantics (since the x86 code seemed to use that) and then the mapped address must match exactly thus page aligned. > chooses a nearby page boundary, though I didn't test. I'm not sure why > I have that alignment check at all TBH, and to the extent it's needed I > could just be 8 - this level of code doesn't really care. > > > > + if (size == 16 || size % 16) > > > + return -EINVAL; > > > why %16 and not %8 ? > > I don't think that's needed any more - there was some stuff in an > earlier version of the code but no longer. it's kind of important to know the exact logic so the cap token location can be computed in userspace for arbitrary size. (this is why i wanted to see the map_shadow_stack man page first but i was told that comes separately on linux..)