From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0574EEB64DD for ; Tue, 8 Aug 2023 03:17:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 775B46B0071; Mon, 7 Aug 2023 23:17:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 700AC6B0074; Mon, 7 Aug 2023 23:17:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C6C58D0001; Mon, 7 Aug 2023 23:17:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 49F176B0071 for ; Mon, 7 Aug 2023 23:17:02 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0E3AE1A023E for ; Tue, 8 Aug 2023 03:17:02 +0000 (UTC) X-FDA: 81099475884.16.7D8E8ED Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 42AEA1A0003 for ; Tue, 8 Aug 2023 03:17:00 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=R5FIPgJq; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691464620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ln9p3P23Q5cQA+r9dkQJP5+/EvnF6BLwETg6xCvhWkE=; b=2hHCadE/B6ZKvmd/bHhOrZ5JY6AsDdAmMVISGE9W8256LPnlkiVQpIJhqvP9TO6P8wQQoj UU3UXDl4Vo/MR8f7ryq0wcmexeMfwoeglZX8UXgkAtXjwD5KVRnzfA7KgA47c44XoK0Nqa 3tLS0ZowyltYGbsnEghjl5XSlAMHXrY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=R5FIPgJq; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691464620; a=rsa-sha256; cv=none; b=Kk6Ljh8TxbdtyTpjPVrCLObAhChT7ETqfAFjakAhSmO+okvYY3cMAkHEZyWxRi68XRxyr1 B3iN1u0BqpJFe77wfUgiO06YXYxOGbv94h/RyZPkgJv4FuZcUcDa+Xi/Qv6+qBdixJfbcL fJEVeeqlZdRhGrY5ONBlcOQdLPhrSgQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ln9p3P23Q5cQA+r9dkQJP5+/EvnF6BLwETg6xCvhWkE=; b=R5FIPgJq6zOdG/CQzwebQ4Ms/P Jhu/sPlNgPitmuY1rrDtWWwFU9p2oeLEGmBjYUwu/+HRCNezUBbhlXdiyoF9KmHvakBRRNW2nWTKN tUpOrkyQ4loeruCnETQ8TazT/kZk2uwHCtqXzSQXyzFeVoR/K7Z7pzhattEJ/IRJJrVTxp7JCTLBm lv00soUJicxZnVJRk4Lka7t7u51BlP08u0NcTGHXxof5BxdMV+iR07sSiDmbuVsMj6dBrz7eUsGHG MyxRIqHHS5dI+JHfPuzlbxXD6kY6ak4C/wyakxy0gCFwZmXJhUmUODymInYulBUDs+t9j7TdfIFN4 UDYfI3Tw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qTDDN-00F3a3-3o; Tue, 08 Aug 2023 03:16:57 +0000 Date: Tue, 8 Aug 2023 04:16:57 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: remove unneeded __meminit annotation Message-ID: References: <20230808015831.608454-1-linmiaohe@huawei.com> <308f326d-c7ae-be49-22af-189a81a89aa2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <308f326d-c7ae-be49-22af-189a81a89aa2@huawei.com> X-Rspamd-Queue-Id: 42AEA1A0003 X-Rspam-User: X-Stat-Signature: ne96ty3otdoycg73mc14ypqohdmccm8o X-Rspamd-Server: rspam01 X-HE-Tag: 1691464620-136991 X-HE-Meta: U2FsdGVkX19j7qyblzQONkpD9y+idbOYvuUmcyqthVBIm1D5HQMJpFtlgqb0RTz1l7FUffVRIUyisGxOxTU1emui1vB/Zt+SqJxmkjSdNgUNrACvuKSHUkfmiPCfZrDE/sGtsFRaNC58y25H0Lkw7xUgmo3N8Yt4ZCZxO7RO2GfYTHHTPgXW1NTkt/VRXEf+5K2E4Tu1MLIHH1jrcL1NNGvtqpU1zgZ8LDpBDWXDfREf7RxwyIJxJrFsng3XEGNazz1H2hD9VZkYnO6zOuUKHFZ7y6XhHumqNHVQGu2xEKuIHVctMq1stJI/u5YIUqQgHWXtuqI0JYx76aoXkc9JLk5YsaOkTlRKDRGQUhzm2vpPCifYeqLjhC0n7V2OPnfjupPjWIeJCMQx4fxdwJc1spDgjyb6ykf0xgtHZqD/AQAEJMtHJb+lq9o6pOjB5bBSAkobfkg43Pk7WOXb4DFwwVNN2s54R2sg+WTKdN3JxPX6zyqmulRRiieo/VffkzvWrSIa7S6nnYMr11rL1S1YiiKjlZOR+m9lMivMTtyT5r0HoINn5uEQwkhsu4f1zxvQl72nRsaD2CfDEHQbTkXHZ5mVVZ8o2a1XSnz9oHgqykFZ8VApVH2jtGUXJkmH8IB3I2y5Jt+57uYGRftLmhFpCy5as1fysiWWC5YKErcd5/CVHmvYXbl4DWLmycP/FAoK/U11gaR1sYa4ZV/YiYKs8U0RMC3BP7iaX9AbImUpSg9xnrMF/fjAYJQJsKlZXjh9hOJhN+Ynp54MW0TfpcKfop1aNNBx7sDKcphqtn8X/DE5JIvSx8xxNMJcPKbxTPG+RZlfm75bX929a2JvzTxK6TI7R2uHVROv1IBY+NM9JgK71wQjRhaCNB3Yh6neWZxg09U6EQF+BAxXsOhn3Bw11A5qa6oZwWDcaRplZ8gvGrCM6v7eUJd9WAIe2HV7qV78XSmAYIP4jW9pW7vjFbu gpYrdzjE 8gn7Fb8iX2EnDLSg8mND7BQuqX/ijZHcV7PVGeG36TUjzfFmdcNDLJsn+lINR6hTjnWXkN1qeiLj6C1jTxN+YwCPmOWEUkjhtFvkdRTo4jZE2zdLojFQg6bJumTSqUHlT2Z3Hh8OJtGmuB0Jz+l0VhFRmebBxRMjpfRDptJbNJoyLgUze8hmyWcFJ9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 08, 2023 at 11:08:36AM +0800, Miaohe Lin wrote: > On 2023/8/8 10:31, Matthew Wilcox wrote: > > On Tue, Aug 08, 2023 at 09:58:31AM +0800, Miaohe Lin wrote: > >> kswapd_stop() and kcompactd_stop() are only called when MEMORY_HOTREMOVE > >> is enabled. So wrap them under CONFIG_MEMORY_HOTREMOVE and further remove > >> __meminit annotation. No functional change intended. > > > > I don't understand why this is an improvement. If CONFIG_MEMORY_HOTREMOVE > > is disabled, the linker drops this section (... right?) If it's enabled, > > When CONFIG_MEMORY_HOTREMOVE is disabled, without this patch: > > size mm/compaction.o > text data bss dec hex filename > 103164 30873 0 134037 20b95 mm/compaction.o > > size mm/vmscan.o > text data bss dec hex filename > 158775 49612 64 208451 32e43 mm/vmscan.o > > while with this patch: > > size mm/compaction.o > text data bss dec hex filename > 102915 30865 0 133780 20a94 mm/compaction.o > > size mm/vmscan.o > text data bss dec hex filename > 158534 49604 64 208202 32d4a mm/vmscan.o > > We can reduce each .o by ~250 bytes. But this is before the linker step! That will be where the meminit sections get dropped. Assuming they are; I haven't verified. You need to compare before/after of the vmlinux, not the individual .o files.