From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 959C7EB64DD for ; Tue, 8 Aug 2023 02:31:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 297556B0075; Mon, 7 Aug 2023 22:31:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 247786B0078; Mon, 7 Aug 2023 22:31:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 136248D0001; Mon, 7 Aug 2023 22:31:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 03F576B0075 for ; Mon, 7 Aug 2023 22:31:09 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C6AF5C0146 for ; Tue, 8 Aug 2023 02:31:08 +0000 (UTC) X-FDA: 81099360216.04.4BB9733 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 8898D80011 for ; Tue, 8 Aug 2023 02:31:06 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ei1FJsHc; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691461867; a=rsa-sha256; cv=none; b=wDMZs3poIKGuA7+Dqm4WIjvxnqehAMmrPqhfgRd1CZmvwFbr6IW+tqENlLMUjj4RYL6jBz +M2sdx2AhsLFvaomX4EGzuGVOV0jwkTG4+/Ax/yKcYsBTfMD/1YA/z88InpERbrFjqgp8e Xc6NZwJsRXjcMk0Qf36AuJVGx2jNw2Q= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ei1FJsHc; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691461867; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WHsJ5PGsU4+tfkyeNNQHPH4OunTTy5kmFE5MgCkPN04=; b=2cH73b4w9EowqokgzQ02nhkS3yphShnSUf0A3/tw5nm2Dl3rolLe6LmBNK3ekDG2aeBk7v om35ZvwCHrSvWam2gt2B0VwVDaXAz/ESkBvZTZkNMkqG0fFQ8+xxbPwXUdAGLQT1mQkKC/ XQL31BqmjHf6oTQgNxS+HbvN/2TsZaM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WHsJ5PGsU4+tfkyeNNQHPH4OunTTy5kmFE5MgCkPN04=; b=ei1FJsHcAD7Yw52EAxHZqGXK1h TAHwiPrB641GNDT1/jXUFn6ixPvzYWUXO7dJP4rnXTj53H7RM9CSPh9Plw4Zs6DjDlyzikvAbkhFR D06YMoJmEmYQWCFoBcZO2+U/Wez1wj3ZWZwpEotiPrcQYMz4tTRMf4C9qeJolJI/cDd6Rsu/AyWUj Le5mXggDMdIXahNr3B5ARePSKFyqL5jvh9Zs57leECNGarItFZ11mCFAIWz7IxUb1cH8/Az/gVkLf VZf3SmF6u2i8J3GbP/j/SpGZoJ3p9uknnGhmP1iV7wgOsOFVq7n09rJikBuJQ8kqvUzcplbXjRraR fhvwjdPA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qTCUv-00EqE4-Cv; Tue, 08 Aug 2023 02:31:01 +0000 Date: Tue, 8 Aug 2023 03:31:01 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: remove unneeded __meminit annotation Message-ID: References: <20230808015831.608454-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230808015831.608454-1-linmiaohe@huawei.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8898D80011 X-Stat-Signature: pgy8ii8inqi1qeh9ejcc66mxw7b7nze4 X-Rspam-User: X-HE-Tag: 1691461866-819434 X-HE-Meta: U2FsdGVkX1/NGMDlHNoL4cwvAksTuBfdMYS7z2yZdVK89cx8glbugNbGhWq8Z31kg+1CVzT6UjNcZ2Qw7MqJc2O0p4NdjarRVHeBE8KXCV5eqH3FbcpLv05prs7thzqSjo3ZDhksAoNuv8pZt2kTOlxONu3oiG+OwQd9glWt0vRIdLhJ423kxpMiv1Nj/LzKMsQ/4baFllMbYG0Q20pB0LdZ1qH2H++e+XQT8jfmfleenjET/RysUpx5Mwml7nvl9wBHJY3FkB38MAYiePlV5DE1FMA/JKqAeyvsT/8iPfMXRhg27NzW2PG88GvCrZUefD5N3yhLrqKxEQGWZ152SORZny4ydH49mGQy/RIAr1fLDb+U6jRBeVaAhyMqSKioP6v5HNj64BYxzC9QkcbOKoOy4u2qM+3zuHYCCW5J4+b4kwWClMmqB5vs6GUrf+SmhIjOSNj22qNcao1qNIIaZKO8aO20krr4tkIklqQgK06VysmUQj2Zvr8dB+lO+9pN/2orfiZ7fBMkLA1Zke1NafRZcdOH/OEUGxpjHPZfkW48Za47Vm0l4C/wCSzmGvko6EaqCDYpwQNvckyBEhs9njzUIWRtWj8PBHsTOu2yWTPSArdsXoNZneK/Ep+O8J8pDOnZR5avH5+oM1S4kTLOAI23zGyMcFrNVeOfzIMWVmx7YyXPBAWrHknEICPs2D8/0fAK8QpLwT3lvLw7NiLMsj+9i2TvMCa2UdDvCgOW0MOyuvDKqeUasHQbC5Vkv/HLdEbRs575GgmBucZIeSKlILLth6bBQtMCbVgrHK6YgIRkX7ujCnASJ3MbayLMcsZcEVA9rFqA4dTkR9OM9SKAV6zqK5YTyhHIIcgiD7BubzAU15NVWwyRpWMLbZ4hZao0TfDcBGr26VCoYpm7BOV7hZAqUiMGChIMf31PB7VZwNzKcbJEfD+5PU2PBDnf0jVn9veSNIx44pWwrbYkGAp oQFwDnup GsMntOgVXogEyUAT7I97qDfHi4gpLXbkiBidq3RLEx6jW2FV/ovYN5Q9zMDVna3JCA4G2PBIvQqX3z0r1/I2GEAjCizZRVKSnJ1TIyNtkBKty7ketYuVg/RoH/+KEIATLHO/+cazwshdUjeH8yLnwomDNm2FJ5idSfmdFDwIRUdbD/0sgV187RYVMFA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 08, 2023 at 09:58:31AM +0800, Miaohe Lin wrote: > kswapd_stop() and kcompactd_stop() are only called when MEMORY_HOTREMOVE > is enabled. So wrap them under CONFIG_MEMORY_HOTREMOVE and further remove > __meminit annotation. No functional change intended. I don't understand why this is an improvement. If CONFIG_MEMORY_HOTREMOVE is disabled, the linker drops this section (... right?) If it's enabled, then it gets shunted off into a cold section. So it seems like this patch strictly makes things worse. But maybe I misunderstood.