From: Matthew Wilcox <willy@infradead.org>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: remove unneeded __meminit annotation
Date: Tue, 8 Aug 2023 03:31:01 +0100 [thread overview]
Message-ID: <ZNGo5Y4vQ3rQn0vf@casper.infradead.org> (raw)
In-Reply-To: <20230808015831.608454-1-linmiaohe@huawei.com>
On Tue, Aug 08, 2023 at 09:58:31AM +0800, Miaohe Lin wrote:
> kswapd_stop() and kcompactd_stop() are only called when MEMORY_HOTREMOVE
> is enabled. So wrap them under CONFIG_MEMORY_HOTREMOVE and further remove
> __meminit annotation. No functional change intended.
I don't understand why this is an improvement. If CONFIG_MEMORY_HOTREMOVE
is disabled, the linker drops this section (... right?) If it's enabled,
then it gets shunted off into a cold section. So it seems like this
patch strictly makes things worse. But maybe I misunderstood.
next prev parent reply other threads:[~2023-08-08 2:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 1:58 Miaohe Lin
2023-08-08 2:31 ` Matthew Wilcox [this message]
2023-08-08 3:08 ` Miaohe Lin
2023-08-08 3:16 ` Matthew Wilcox
2023-08-08 3:26 ` Matthew Wilcox
2023-08-08 6:10 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNGo5Y4vQ3rQn0vf@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox