From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80288EB64DD for ; Tue, 8 Aug 2023 01:12:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D83B56B0071; Mon, 7 Aug 2023 21:11:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D33E06B0074; Mon, 7 Aug 2023 21:11:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C21CD8D0001; Mon, 7 Aug 2023 21:11:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B1FAE6B0071 for ; Mon, 7 Aug 2023 21:11:59 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 862758049D for ; Tue, 8 Aug 2023 01:11:59 +0000 (UTC) X-FDA: 81099160758.24.9E8822E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 932EE100011 for ; Tue, 8 Aug 2023 01:11:57 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="bdRUssl/"; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691457117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4hQm2gdZ65LTLHU7bja/ZjRmOL3/czAMitrNkR36dXs=; b=wL61eoPSWmClp0hxg0KnUf3BXi6bXVfLjZMHOK5JzPGBxj20DCQcwsqj1dr7UqTPVdcffK En0FPhaIre9Nv0PqiEFySQmPBsv0j2I3gyzne3ccgdaMcGYOZchjXwmIcYQBGcc/KZhKdI 0nV4FFxZos1cnBy9Bfwsd/fPb9KxFvA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691457117; a=rsa-sha256; cv=none; b=nm7UEVGlzETitmdDtMQ6yB2b7wNPNX5VYe9e+hIIzaZ7kE+vLNBEFE288WcJny2a5tAz6S vn2+wurPEiOvG/n2MN+lHamaywzx72TiJfijyblU6qgoSr+W+/s7wen1S4/ZibQcSJA5hY 3yDbFJ2H23GOSfcwo/rdJs58s6AkazE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="bdRUssl/"; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4hQm2gdZ65LTLHU7bja/ZjRmOL3/czAMitrNkR36dXs=; b=bdRUssl/s1IKjgXr91BgOuDN8r lKsJZUefso15U/IZD+LqcVJNG2H7WJ5bJBssROPxKJP7zrriBk+IKqO/Mx2a3ZgEk/VKdetJIxZiW 02hW09VOqzq07pu3jsMH36r6tOgBoL5d91ZTEh2BqxLWCCqFYXzFUh8vzrDngd5kWPCOGPDHtiJSH IINJRmwMhLkpLZBohIXVE2NExPU9mQniTnYITxdAgeHFhrDOZDFjK+xdXPqeDWsp+QoUJ/9GCzpqA 0HmvnR8mvEaA/xa8zFk5rBRmPjJ0sdtOju92VqGA3UHY/h2t1vjBRG12d4Ech7jxzRNDsZmIiGGAW 5mEbeEaQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qTBGC-00EV9R-7X; Tue, 08 Aug 2023 01:11:44 +0000 Date: Tue, 8 Aug 2023 02:11:44 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Mike Rapoport , Andrew Morton , Tomas Mudrunka , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] mm: memtest: convert to memtest_report_meminfo() Message-ID: References: <20230808012156.88924-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230808012156.88924-1-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: 932EE100011 X-Rspam-User: X-Stat-Signature: wrw61gso4xr7saib7bsocuc5bhc6hxci X-Rspamd-Server: rspam03 X-HE-Tag: 1691457117-138023 X-HE-Meta: U2FsdGVkX18c1AHuU/NElXlpPUfQ4O6kgHdPcJPQzVQCfGDUc4DLhzX+XErk1vbksgpca1GYPgaIT/EID7252pEDhvpchan2BMd/c4b5sZpUXX6UP9pT9OEkfOyeuD8YvaPJoBJBRuHlR3yPkL9H/bKVJ/uW+vOWg0qRE3MTQzvnucX09iqsenB66+ymN/XVOiaqEK6DyJXz86XN/R4DMmQbotjrgh0hJHyH2vScmpOYguT63MTQEcrtlNc+jyhjpprSrw1ruo+QyJeOxSQ5eLPZj4GGa2nSWuTrXxLrwh/z2nWxAkjwrwDh+D3a8zHEi0p969hjxP8HsDDGC4rCkU4pONp+i8B1Oa4HzEsK5JTJGqGJYWAlp5+6u0wBRMR27jh/d8IdwLzOPfvWvKhFCxF7JsvmmKyJcJC5fcfRoyDLjp9/c/XAvgScPRyby3jsorph/8hVN5RoigYx4351sNA+xQGR53dzuvgB9uy1+4olRhVZOv4LrrhJlnmu0oABdxPsP4DivaSKA8qZH2BWdc5v8QeJcAXtYChCrps2zDhbWWe764GX2aB6BwknamFJuQ9vG4PSPadb5/60qFnYUUypbuoI/QmPow58Ye2EHNwYPZwN0n8HRNHoIyuZjLyTn6eiZK4kbuRWB9igDzSSTAOFxPznRMZgyqLb1ky3sUr4/OvJDUqDvfk9EyMTcr48tzMvwqBm4t+CRrPTfvSMyaKQFWDDy0S///yNor/cTM3VTWcsdRLoNgCVCIvB+uG6iqFS+wO87L5Lw0zae66U1nrSSmL1UYMqKI9ivV2Fk9dig6ytdALbhdvyJxDSDOlcTtvzOgCnnNgIJQJSmTg/lEx0EUSIdZJTACOi0jSqtRqwDK0Wy4OBBUB4vdSxZUXxKQ6ZP2Gmn8lTGe1cuQcUkx6CNhfTJw1CVailNv8xZ9vDexYpp3S24zVh0ozMAc4KF0hLLO/Dtsx+9Nb8suf ApERGN2P 86iCuLBq6i4S+hB0OovyCTXNjGAuEusgbrsyPklNvxYJouyI/DD0FQeA+trGl6BfXQYiVytJNQU6zpN6R1zw32W7vZWfMZ3QI9J9eAIV7/jfMEYyMPWnSRyghPzC3AcH4XXVW7p+pI62kFSaX4HMw2qbCxLXXpGFD5GXbFcKRYtwiaG+eyZwhHTB6OQB2afhboIVyMsNofE3839T0TJPvHMUmL3AhgrUlwtlh5/EgaILM+TXWddpmzyMJqqi1g2ECLazB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 08, 2023 at 09:21:56AM +0800, Kefeng Wang wrote: > @@ -117,3 +118,17 @@ void __init early_memtest(phys_addr_t start, phys_addr_t end) > do_one_pass(patterns[idx], start, end); > } > } > + > +void memtest_report_meminfo(struct seq_file *m) > +{ > + unsigned long early_memtest_bad_size_kb; > + > + if (!early_memtest_done) > + return; > + > + early_memtest_bad_size_kb = early_memtest_bad_size >> 10; > + if (early_memtest_bad_size && !early_memtest_bad_size_kb) > + early_memtest_bad_size_kb = 1; > + /* When 0 is reported, it means there actually was a successful test */ > + seq_printf(m, "EarlyMemtestBad: %5lu kB\n", early_memtest_bad_size_kb); > +} Doesn't this function need to be under CONFIG_PROC_FS ?