From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3199C001B0 for ; Tue, 8 Aug 2023 04:00:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32A546B0071; Tue, 8 Aug 2023 00:00:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D8FE6B0074; Tue, 8 Aug 2023 00:00:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A14F8D0001; Tue, 8 Aug 2023 00:00:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0BFAA6B0071 for ; Tue, 8 Aug 2023 00:00:11 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CD20D120204 for ; Tue, 8 Aug 2023 04:00:10 +0000 (UTC) X-FDA: 81099584580.30.CDB0C96 Received: from out-102.mta0.migadu.com (out-102.mta0.migadu.com [91.218.175.102]) by imf16.hostedemail.com (Postfix) with ESMTP id CABB3180019 for ; Tue, 8 Aug 2023 04:00:07 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Cp0f1StK; spf=pass (imf16.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.102 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691467209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sez3/qKAzyH76xRy/KhqNgZqSUAZnWdnTT8oqdhcXFU=; b=yFcrMwO0ISHljUrxUJi9nQQoN7QwC5CnwhelvNDVyg2r7pIDhNujByugrIbyTnx8RWcJKO 9+k+T5zyp9FCZopShnG8/c21mpGBv/CDDInzzHchfmIAA4kpKeGj21jUpnJcgOyJMQYRCl 8zjr59FX6r0As5SislSO5i4ucer7foQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691467209; a=rsa-sha256; cv=none; b=m28RRHaHlocX7/BA6vzIy6khQqv4MCBGdJP5EwY+nBZXMvLHxbFGwNMLDTRQvC0eIpAuYZ QGG3dMp4xzADBJLFSu9qUfw+F9T0v+TaekLAxvE9OgrGTUVFWHBDAUeJuIJ1fYe6dXVd5D 0rObhkfatfAuVHVdOp9U2wIpiJdZHXg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Cp0f1StK; spf=pass (imf16.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.102 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Mon, 7 Aug 2023 20:59:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1691467205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sez3/qKAzyH76xRy/KhqNgZqSUAZnWdnTT8oqdhcXFU=; b=Cp0f1StKAVL+rMJfbIbWcxpNVTgUYc6wQudKaze3wIjc5BC5XVXMk0mpSZhp3Wt/mYHEee YI4Sm7tEAnDW2LteipyOYEHK1B+WOjylDTJ5aOQDsBoX/ClxtVQAA2GoO9Q+OAfd27HcbQ 9S3NIwPXnMBZ/gyDlHHFOXzZB1IjJl0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: xiongwei.song@windriver.com Cc: hannes@cmpxchg.org, mhocko@kernel.org, shakeelb@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/memcontrol: add tips for kmem.slabinfo Message-ID: References: <20230808022229.1560559-1-xiongwei.song@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment In-Reply-To: <20230808022229.1560559-1-xiongwei.song@windriver.com> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: bac336868qndpuk8uqzbdy9hzc4js9bj X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: CABB3180019 X-Rspam-User: X-HE-Tag: 1691467207-823901 X-HE-Meta: U2FsdGVkX1/N7pOLto1ImsrNMSo80xk1qDosDXkqQek2LMI/NKDIJHOlHsnqGYnR7D/jcxl3bPHU1ebTJQqdjP0gzDZ9/VB9PfpAJv/Vlp5CayHg+4vM3XOhioD8v4g006mX66et5vpJrs6anXxlKy4en+/YPUc6daF1do/j4ANteJ9rxqok+AEkapeGm5Hbzpft5IZ7GEa6AvmItRBZW2RJeKtaKE4h2auXEwzdZunFAyiUjHFE62u4syu9yhfdtf9vbwAGCn4/k/TEIXdajdNDnqnn2cCUSVSbhxtOxWqDSz8uFzpRO7IGY7brIo8/tMophUXUP0IgkwfSvMdERGc4X9gn6qFnGB5MNU8HieUgOyCGNVzTULaUuqEhLm4bX00JmdbK6z/4xHM0iEu2v6gkSP26nDK9naccjkaq9etPzPTal3uaDexjHEO9zWQ4X2q7kYOmQKCtHZK+sijsz0I6Pw3H01U6JIuYGGMIHuokYyR3PiJgKHfQNrvx9KI8pj1Sg+7MRAO1MSDpY8/QqyHbk2D/WgSgTLQXzjh0QxhBl8mMeRXUnuTjCEqf/v5uc4mA2OxnrVVizfQxGmCiK24Lfry75hX5j8Iqr39j+/Oe3dUgE1RV2vOl/JueyVq51czMysrk0z10EdTUk/Sou7cTcRIx3TVa8ePYeCHsjWL3rtxQk/lxrf/FlZ9HVvcwuf80OqaSA8M+Ni+i9d46zVcDK0jlCORGvkfF92C3q/IuXnF6/omgS8R8gQ55IudOFFErUnetyHsP9DqFhYtj1CCQOzrEqw3I4FiUtlImUn5VDf7ViB1h//9PmHgj+F9sGyj1FHKLu+ur1Cc/lXM9MRiSwM6GKSG+jn0pAioI4M+e4NcVvq+4x9TT59k056vv78/O+mYvg+mZUWISQD9QKeKlA07wkCdlL1pmB0D/c3GdefRsm8+ao3AJy8B6j21tFUv4wgNare1mqlmaz7C PoMyDpv9 J1slPHSSqQqyHnQpNa5Y+97Ov/pAEOdzESd3GioPsqnMUhuQLtxbgDha7Q4TugTcBcpSWYU9EXAzmfv668MANxENHaCpPo3HaW3Ep/Yk2xZvjrm0ZgtNnVC11SmVdrfFsLEzPK6koLRshcmRCmTbWJgwmpQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 08, 2023 at 10:22:29AM +0800, xiongwei.song@windriver.com wrote: > From: Xiongwei Song > > No any output from kmem.slabinfo, which is not friendly. Adding > tips for it. > > Signed-off-by: Xiongwei Song > --- > mm/memcontrol.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index e8ca4bdcb03c..58d3bd93890b 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5002,10 +5002,8 @@ static ssize_t memcg_write_event_control(struct kernfs_open_file *of, > #if defined(CONFIG_MEMCG_KMEM) && (defined(CONFIG_SLAB) || defined(CONFIG_SLUB_DEBUG)) > static int mem_cgroup_slab_show(struct seq_file *m, void *p) > { > - /* > - * Deprecated. > - * Please, take a look at tools/cgroup/memcg_slabinfo.py . > - */ > + seq_puts(m, "This file is deprecated.\n" > + "Please use tools/cgroup/memcg_slabinfo.py, which is in kernel source.\n"); It'll break the ABI. The only possible option here is to use WARN_ON_ONCE(), which will print once to dmesg. But honestly I'm not sure we need it. Thanks!