From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A268BC04A6A for ; Mon, 7 Aug 2023 15:27:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22D1B6B0071; Mon, 7 Aug 2023 11:27:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B67E6B0072; Mon, 7 Aug 2023 11:27:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 030818D0001; Mon, 7 Aug 2023 11:27:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DF8996B0071 for ; Mon, 7 Aug 2023 11:27:38 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6DB4A1A0B41 for ; Mon, 7 Aug 2023 15:27:38 +0000 (UTC) X-FDA: 81097688196.21.FC0874E Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by imf25.hostedemail.com (Postfix) with ESMTP id 9F417A000B for ; Mon, 7 Aug 2023 15:27:35 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OFQ71Mz+; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf25.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691422056; a=rsa-sha256; cv=none; b=7qvtRC2sOAyj25Fy+rJ2B9Q8RHvqd+3VfA9EVCiSCgu2K2mm4/fkC/a9oD2j5KGYR+Cuq1 /FGYdiKaXhOdPNxiy8dRd2KocXEC8KmTv81yhWF3/sLA17yHV6FAZTVXVtGiQgkDx14Awh 2JCZAUy59/bd1xh+XJHv/hVkP7wBW18= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OFQ71Mz+; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf25.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691422056; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EQHdJgeW2bCy5W4P4owC4ODkkeUwBtsAu6PjxPwsmjo=; b=4BuAkLFTHX1b7+l/EOukD1YIESLpStE2o8eVvkTGqIbLeeH2BKs1hfJ3tzu9N6a1jlRUe9 OltKfZEXGT7ityBNLXLmPC904Th9hynVxUT1Z1omhy2FQM6y2zbNckaGlsHwZUi2VzdiNi DyzcNORXZc1J6GLTHSDa55TGOXTef40= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691422055; x=1722958055; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=sbOg8ZUo93mja+laQ8iw2rg2Pe9WY4tNS13a+NRdJq8=; b=OFQ71Mz+5bk0UDe7+hYQqlJy5b6Cp81PEywxWovNgZJgsuD7KUu6v3ww TkuNm3dXMN3g4cH4G7FmXoxrg4kK7fEW94rVZbAY4RkOQwoCe0n5YxpTj ePbKqcPUFeswUWd8shs4ht+MjegkZhjyLtBDk0243Ah/HhjpsLe+zsF8J jKp5fnYwEFOsDUIms7FFJFvO5rT8mv4BuEyy339IaB8uzvhz1F/aIz1Dp N0ki9FbVlFcCRwomZRkfrAZlJQnZtNZaOD2mhUTG4Kp0kEm940fiO/Hjg eW5aOFHCSMyWEZJe8JOMJS0S88gIHRS6JyLX3vKiwECyiJ4J4lGK5/4RP A==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="355513453" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="355513453" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2023 08:27:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="854698024" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="854698024" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP; 07 Aug 2023 08:27:31 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qT28n-00HLi1-14; Mon, 07 Aug 2023 18:27:29 +0300 Date: Mon, 7 Aug 2023 18:27:28 +0300 From: Andy Shevchenko To: Petr Mladek Cc: Marco Elver , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Subject: Re: [PATCH v2 3/3] lib/vsprintf: Declare no_hash_pointers in sprintf.h Message-ID: References: <20230805175027.50029-1-andriy.shevchenko@linux.intel.com> <20230805175027.50029-4-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9F417A000B X-Stat-Signature: 8ixz655qg6n6yrx95rqwmdqeh4prdyaf X-HE-Tag: 1691422055-224920 X-HE-Meta: U2FsdGVkX1/s/JFaDUzrJ1ZlDs3V2ixHudqNZHFi9UezrvnNJmncbiusCfr2DzO65cmhiYYKVvOEyBsti+1zWGYQDhApwtHo0foiFrFdL1uBb4b6i9LjCqQPfo7VPvFRZyaHfD9T+Bfm5H4PfJCjhhp4nvuX618KBqud92LUPgiuf2D/GIyyIPwZ072K0FypnpGYI16vLEsLKdvCYja7Xn3RQfDlSOR9oCuDLMqoOAGEZtRm0atqp5lUfUW+jOl/SOY9Nmq/5La+ZktvRXftkSKSh72CjEUc+WyixkBPLBg/6NwXOjSyRKUmgBhPQlwUUWX4/pQj/TiZFvcQDAX/6k0Hd8bbN1nE+xdL/j9yy7gEstUXHwa/69oW791Gk57+wxmVQaoL+6+uqUWy5xvP38YKrLQkIIJyXESaGjOQGwl/42V7lJt8lAxHjXaoGeBWAp8VIubkCeXBrPUAnTUUUMEcXRr2cuny5Bc/gC9FSeVB3CfvGYkOmZ1WHqoSmQ+9RTv8tEoCVXtCUGsu0lLjSKsAfNVjFRbXDy0la5pgJX0eu0hY2zb1mA+xr3VZ3lGIEfnAJJgcThygy0fxhFTdZR+uET0Uxt+mD49iaFKLjzbAs8ZNhTtFz4L5ihhP5GoERLZt/qW8RDklmsqjqTDZslOi110HRwkdkFsCFlaxWBmu8QxvFC2OoJ6L5EZYHjWjKs06JnSyp7E4TmCq28xbb7YANXkiBHF6D85knDLDDlxTBbKORiSwM3awPV9TBQb4UBF8VsCI//yvJ5fceLnSzrsSJZv8YbPwQ9RTv3wUQBWKKRGT8CLA3pzLz6NN+xbgnRDyp+zHUf+i1v0mlv36McpFJlAO7fiJARaQS9OBOF/Z6omsLQXK1hrhat5pCWpnWmMJbLzcjz6D81t6kX0oM+LeZJt+ecILuHXvhjKMKqt/IrZFk5FdFqXqA/aO7S2aHE36+zhXc1pi8NGZ8rj TjxpxE2C D8IyQAXZ67i5kotZwC/prB3L9bUetg16APRa+PCuVk/Mt+/oBQYSN74suolCBwfa5SxoielER2/0zaMuhWewAu3GJdv3H+eqFSBd1PYwhRPmmrV9Zq1xzRMpDKpRNx+qq4DcHliOpFb+TL7NV0oEbywc4jFSZdcf6IWyXKOIuFMszHiDfnBAnGpzDsF4GBZrr4TKxCBGUojqSPq+ZLmGwze7uvg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 07, 2023 at 05:06:33PM +0200, Petr Mladek wrote: > On Sat 2023-08-05 20:50:27, Andy Shevchenko wrote: > > Sparse is not happy to see non-static variable without declaration: > > lib/vsprintf.c:61:6: warning: symbol 'no_hash_pointers' was not declared. Should it be static? > > > > Declare respective variable in the sprintf.h. With this, add a comment > > to discourage its use if no real need. > If we agreed to move sprintf() declarations into printk.h > then this might go to printk.h as well. Sure, but I disagree with printk.h approach (as I explained why in the reply to the suggestion). -- With Best Regards, Andy Shevchenko