From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98E3BC001DB for ; Mon, 7 Aug 2023 15:14:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35B806B007B; Mon, 7 Aug 2023 11:14:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E4EB8D0003; Mon, 7 Aug 2023 11:14:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15E898D0001; Mon, 7 Aug 2023 11:14:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 02B4C6B007B for ; Mon, 7 Aug 2023 11:14:07 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CE747405E9 for ; Mon, 7 Aug 2023 15:14:06 +0000 (UTC) X-FDA: 81097654092.12.D04F010 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by imf19.hostedemail.com (Postfix) with ESMTP id 546701A0003 for ; Mon, 7 Aug 2023 15:14:03 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=W5KfPEjZ; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf19.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691421244; a=rsa-sha256; cv=none; b=AmBeSVzqRCVKcH5H504KZ74gHKqIGevuncOCtHC3zVkzZ9C7iob8vcH5iobHWImD1pFmOI 0e99AKyfgyMJzPurj5ex63wm6OfK1G+zc9RXT93dxuZK1RjQ/wh8pjnSXHlkYsghWDTsiY zl4z25PIOhGshf8qlOFgxEZm3qYT8K4= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=W5KfPEjZ; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf19.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691421244; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QxjPwDRQeTvf2hrdzupU6NMittQpDDd8u4E+jcGgjYU=; b=DE1u1rlhUqaSe6suis4uYfS/9fNhHhBbOXlgkichFJY4sQifib5sXNDhKUSoQjr3Cwx/jZ TrmJ6PzYA3COBz7ZL3qFpKLGG8lZUxob0T6UPpMiavNhLH/CYySe2WhAPppTNaCFbk39GN jo7PbdEH0IWst93bs2Zrpmd1tWQq+Bo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691421244; x=1722957244; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=1SxUmllyrZYOqY+hP7Ch9lDxmaUl+LSb6ThFxH7GYGU=; b=W5KfPEjZZ+kxBzYIVxAFCHlsCYCGRhORDFQIfmz2EsD5WTrRp8pd6fVZ kwpIlAicmNQNe+5s2FT0jVjgyxLlJ45p8/1JbJcbB64+yapLCXHqWrElk Bpl+E8G3Jfh+wnpaBtCCjmUQn5+FgoLqTIMWa54DIaV3yA+BLolj7dMWB eCZ2nmLOk2P6bGnprrUY9smXfnuXCgVFw13gfmmRSMbTzy2jQrYWqyz/2 zreiJuX9BBaAkvRp5UIAIDlCd1sJeGM92zB5dEG5NDjiCUPQp1kG3u+rb rrHMGuWeI8XnNSbQj3KnfvPQ3nIEQJ5KTu9bew+rXD6IYAJppUOUOrg8B A==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="360656653" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="360656653" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2023 08:14:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="760531465" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="760531465" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 07 Aug 2023 08:13:59 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qT1vh-00GtLP-22; Mon, 07 Aug 2023 18:13:57 +0300 Date: Mon, 7 Aug 2023 18:13:57 +0300 From: Andy Shevchenko To: Petr Mladek Cc: Marco Elver , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Subject: Re: [PATCH v2 2/3] lib/vsprintf: Split out sprintf() and friends Message-ID: References: <20230805175027.50029-1-andriy.shevchenko@linux.intel.com> <20230805175027.50029-3-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 546701A0003 X-Stat-Signature: ab5fa1izey99w7smfhdsx164rzffhnba X-HE-Tag: 1691421243-308511 X-HE-Meta: U2FsdGVkX19DsHv4nI7jI9BKbxYXcGDBKBnPfNZIUbV/O5ZeFiRJhpWga9pUIKeJI4eVAUiMJkraajT8P5SgpI+YWU/A+368Pfog8UtMkK1llsO1Oc1lsKg+mtyjSFJj1AqlHE9KmxV+TAUAWwiGk0OlZW7an5EssKSMalD2VEwLfgWM2aDXUUT7wDY5kDlTaaVv61Tyc2pFF5yeMVSxEodYSyGyVnSxi3IgLL2Tf4HYDMUAJLCCrIYoE/UM+o8c/VyORT4wBXSRu1aLd8TIp+f869lZm38FT+Hn90/a3m2+pnYBETVGLbAFtCMXiH+wH0rDeBfiuum2WwgPZqImuvGTfy9yWZieOCHbeN9JqzPWYK5819zn7X01aUWS+SSl9VbN5tsa6fSxOaouHoP8RP6wlCcz3DrG/2o04AYe+8byYOiZ41/qtqHa8Q9xYYcrTPWpQLkQS3e2CeY9MJpJGQL8V8JST+d9ZkIHv10qGab9XrPjc+8ipqFxXWOb3zCqIH9WplS3Zdsz8h6VwXjgrSrcUuHyByyc3P7LKTPzxI8iNo/oKUd0QD3y/kSfw5fPfRxDR8cQgk9LwowaWhtFHXwPpovFp2KOP35N5vqudOhkyvb+F2n4vDQfNQDKHPJUIT1Db7pzPXgM21jZZy9hcCkOCXYIpBwr5xnaLBMbcIY+fQDeKMKX0hppNjXRPUKM1+Qxywe8P72ljaGDtChCAWla8S0/GImC8poh3kt1mNEt1ofwSItvOb4LU/LwHhfl7JuzyTFp4a5fDOYnQncKPnnPftPGKPCWbht82TaTJh1lqmApiadvux9kZnV14JlyyEkEJqVbpPj/cf+8ovlM4D+JJwDx8K1m/aeiT1XPu0jgSpblxJ1CDnJ+jiXxSFRfE3o3mYYOIUS1wrmhKxmpNoQmcmpDFPcYZaBwkLo1KwUGXS0uMY/B6x9WnhySY9U6qnUXQrS5VgrQmL01KSt lwzgT7s3 eUavaDBCgKBnRpD3Xhv2TeuQvQhYdEL2XnxWuaWtN4Ujl0P2a8EiuQXN5x3B4TvDFBKlC3Z0+oiv/fvC8o7n72fVbTHMHQIALZcaeK2RYCJy/9AnBXzpPXO+dDASJPRej9o3wqLaZbsadtoHgl99/5F4DRYY9vgUWA12hCAf3Zygd2mU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 07, 2023 at 06:11:24PM +0300, Andy Shevchenko wrote: > On Mon, Aug 07, 2023 at 06:09:54PM +0300, Andy Shevchenko wrote: > > On Mon, Aug 07, 2023 at 05:03:19PM +0200, Petr Mladek wrote: > > > On Sat 2023-08-05 20:50:26, Andy Shevchenko wrote: ... > > > How does this sound, please? > > > > Not every user (especially _header_) wants to have printk.h included just for > > sprintf.h that may have nothing to do with real output. So, same reasoning > > from me as keeping that in kernel.h, i.e. printk.h no better. > > (haven't check these, just to show how many _headers_ uses sprintf() call) > > $ git grep -lw s.*printf -- include/linux/ > include/linux/acpi.h > include/linux/audit.h > include/linux/btf.h > include/linux/dev_printk.h > include/linux/device-mapper.h > include/linux/efi.h > include/linux/fortify-string.h > include/linux/fs.h > include/linux/gameport.h > include/linux/kdb.h > include/linux/kdev_t.h > include/linux/kernel.h > include/linux/mmiotrace.h > include/linux/netlink.h > include/linux/pci-p2pdma.h > include/linux/perf_event.h > include/linux/printk.h > include/linux/seq_buf.h > include/linux/seq_file.h > include/linux/shrinker.h > include/linux/string.h > include/linux/sunrpc/svc_xprt.h > include/linux/tnum.h > include/linux/trace_seq.h > include/linux/usb.h > include/linux/usb/gadget_configfs.h Okay, revised as my regexp was too lazy $ git grep -lw s[^[:space:]_]*printf -- include/linux/ include/linux/btf.h include/linux/device-mapper.h include/linux/efi.h include/linux/fortify-string.h include/linux/kdev_t.h include/linux/kernel.h include/linux/netlink.h include/linux/pci-p2pdma.h include/linux/perf_event.h include/linux/sunrpc/svc_xprt.h include/linux/tnum.h include/linux/usb.h include/linux/usb/gadget_configfs.h -- With Best Regards, Andy Shevchenko