From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F094C001DB for ; Mon, 7 Aug 2023 15:10:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D43F56B007B; Mon, 7 Aug 2023 11:10:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF4408D0003; Mon, 7 Aug 2023 11:10:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE2A28D0001; Mon, 7 Aug 2023 11:10:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AFC256B007B for ; Mon, 7 Aug 2023 11:10:21 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6A7F8140A72 for ; Mon, 7 Aug 2023 15:10:21 +0000 (UTC) X-FDA: 81097644642.21.77A24F7 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by imf17.hostedemail.com (Postfix) with ESMTP id A69734000B for ; Mon, 7 Aug 2023 15:10:18 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Z81dPEGj; spf=none (imf17.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.65) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691421019; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DBoloknsgWCBv8GQFCwXllkjZBxlmNHMZzvDZYgVj+U=; b=V0ii4g8FwO233/h2eE7zawBg4O9E4NM9+afSx0qCaWofrVcX5UnZcxRCYDAgK+etJQN9cU oOuYH/xEEe6We8OrQ3WhHmb5dFzi5fgBAWpyC3Gn6zCq0c0Ie5+wbaarPBLXkok6mG2jCl laUBmmm73Q56OCHIieMtljG8GqjWce8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691421019; a=rsa-sha256; cv=none; b=Jntb/DKR7AWx1Ki9kGy07qC/Wa35ic13VoLcWEiVebGbDplZKi/en8/bM+WY+ni7iqg+cy gF41Xj3Bka/0pSXA1rk8w5IEP0x6bZILVaiIIkDlXrHUjKbMpwNQD4mf6uwTyq6U8/kLnF fysAHVimkEIQLXcsihCPFZ4qMZ0u9gw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Z81dPEGj; spf=none (imf17.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.65) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691421018; x=1722957018; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=XE7lAmwu44QiLaUDvsnQL76XBEMqgW2TS+j1d7xf+c0=; b=Z81dPEGjXX3WJWYYqb1FVnzNr6O2z4R09Rl6BQTfmSGfLrL1XwaWHAec hUzS7TkBH+25nGxeRLMCh33mju+aNY0UxbxOjPCBmkxd1GX8fKI9pgPug O+kvvmbnGmqGtwWCymNbBtwxoPM5Nu/uWB9dRS6Tew9EJFo4hOXwDi34z IrG0DV9rpyQy1E0sYWSEzxB3uTlIkd7U9qkcO458Zq/7Po5Dt2DEPta7f q6/uk0NNCdToOeFeak2OHbZ3B7H/JXJ6BydHNsC+/aGBrwt/gBeNlWFah rib1hV0PLyl1WYNd6fMCG64RzjhBTzCo9uF1TUT2EXzbVQSN78seaoxYw g==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="374246596" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="374246596" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2023 08:10:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="904797907" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="904797907" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 07 Aug 2023 08:09:56 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qT1rm-00Gkcv-2K; Mon, 07 Aug 2023 18:09:54 +0300 Date: Mon, 7 Aug 2023 18:09:54 +0300 From: Andy Shevchenko To: Petr Mladek Cc: Marco Elver , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Subject: Re: [PATCH v2 2/3] lib/vsprintf: Split out sprintf() and friends Message-ID: References: <20230805175027.50029-1-andriy.shevchenko@linux.intel.com> <20230805175027.50029-3-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Stat-Signature: xwbhzhbpdfj51mirsnsyoiks6e5mftdz X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A69734000B X-Rspam-User: X-HE-Tag: 1691421018-77685 X-HE-Meta: U2FsdGVkX1/h1PqxQ/lbqAGMhd6q9SAAbW041D8uaKTXII4bVGz25AhKxYbQTaxVr/5PcBM0hZzk9SJw2gLLLYbK9gD8P95kFimNvdg5zrFQ0FOSIl1Wea6PZIaIa8tvOjZbxFUF98ik/+VIrwFABR8DtzmSsD0Li6zEXfVIGb1bGFTjp/1cwHqzjgpQu2sgzXsPKVtjtO+Hm+Ikv0Q5vJ+qJKim6WMRzejHbNI8fqBIpYDWJWGgv1Kvmzg7vXy8KPg5r4nEfFu0e72biyE4DaOZJoalF9roDabLjJqWg3h62eXDk6xj28GzBCdxWpoSU0UJsJKKHw4/XfkKgkdRVT3CobVUaKVxBbt5/tjSeTTEO3UrPrUj+BhJt1VYy1wwa2zjsrPaPSWRyGkkWtJh1updOLXLa11IEkZE0wpfkyG654A2l8vVHbUglB8FGU6HSxio8vtpWmbGejZ1OaNvFwql3/BGC4ZteKpxHsLx7vbihPh562uXVP7qhd3YmmjD3pSJg2sUyAYclrBxVavk8ys0rXZw60d6ww/9/Toi0n5BuJVZ1tNs9tT2z9Hj1ZYEOR+e2zw3qCAyBnjxM+jy6hXAsbsq14fLK9pAZdZAPjnhT/MKPpo2T8++/UgkoeoF7VKCmhLcavxyUO4NVFx9/vWSlO/+HyqE4OLrZ4FYuiTdOhNil4AvsXWW28Ku7BiOoS1472Oym2INM3PboKY+Hs+tUTYFxUxgFRH43/zZSjOdAAiSxsbW8DEiQNT9TmoR0PVD7XQxDUtmAZ2Hf9exA+vEGQrPBdx6SJWl5XffsESSvGMOb+g2aTJxQYBK//tdMe8zE8p6giTrhNq6jRVxRmz+xZWQo7BGc3tmgqKSlmqfkMfvO5EezPJVU3IZDowRL5OxiroOjcckQ72kbNtqC0KxgHEaNm07layBxBe2r50dn8PKrMSb/6EB6wytyaK6l12i/IhkUmP9wijbkuS 4RQpLrej fqVMzpno49FAnOPqxRUpsxvTbseJ0chi/IIY8athyJkyPcu8mO9ccAq/Fmv/zqFIsCf9pE9hGy4HuUAfPGpmS8qXi6H1LsiywEJz5QJzjLIHYUC2XrdW61WP90saihgjSuVH83IurqQJpTgA+Os9H57jD2wLU52+jbO5rgS0rv0SIITU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 07, 2023 at 05:03:19PM +0200, Petr Mladek wrote: > On Sat 2023-08-05 20:50:26, Andy Shevchenko wrote: > > kernel.h is being used as a dump for all kinds of stuff for a long time. > > sprintf() and friends are used in many drivers without need of the full > > kernel.h dependency train with it. > > > > Here is the attempt on cleaning it up by splitting out sprintf() and > > friends. ... > I agree that kernel.h is not the right place. But are there any > numbers how much separate sprintf.h might safe? > Maybe, we should not reinvent the wheel and get inspired by > userspace. > > sprintf() and friends are basic functions which most people know > from userspace. And it is pretty handy that the kernel variants > are are mostly compatible as well. > > IMHO, it might be handful when they are also included similar way > as in userspace. From my POV printk.h is like stdio.h. And we already > have include/linux/stdarg.h where the v*print*() function might > fit nicely. > > How does this sound, please? Not every user (especially _header_) wants to have printk.h included just for sprintf.h that may have nothing to do with real output. So, same reasoning from me as keeping that in kernel.h, i.e. printk.h no better. -- With Best Regards, Andy Shevchenko