From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C369C00528 for ; Mon, 7 Aug 2023 15:06:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37D498D0002; Mon, 7 Aug 2023 11:06:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32CCD6B007E; Mon, 7 Aug 2023 11:06:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21BC48D0002; Mon, 7 Aug 2023 11:06:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 11EC66B007D for ; Mon, 7 Aug 2023 11:06:39 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AD26080B2C for ; Mon, 7 Aug 2023 15:06:38 +0000 (UTC) X-FDA: 81097635276.21.3CD5E64 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf27.hostedemail.com (Postfix) with ESMTP id 54B1740015 for ; Mon, 7 Aug 2023 15:06:35 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=hfz9kNXX; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf27.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=pmladek@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691420796; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ORrKyaZwOQ/jexEB7RQEGSlaUvsbs8g0ZAVVA+oTshk=; b=hp0rmF2k4E8nMLKeexOxGZYiHYvuH3dh7j3xCa/9VVAUlAPTwb2IS9/BgnCfbiAT9qZzmZ teWN2gMhENeuNuXF3OY6L/r+c28/ab0Svz/7sPRG/HV6QCPg/ZtY6sMN38MPjNzEKIRvFy SYxeFaxldKR+ODmoI35LmDMEm8Pq4YM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=hfz9kNXX; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf27.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=pmladek@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691420796; a=rsa-sha256; cv=none; b=rk7l0aYv9L9C8WF3GjpmmPkidrc03qkMxag4CpiAgNYhpm81DEH/dRKnMnlRceFBfvGbS5 nUA9i2WYCCvCs7fZyw/LGgQGxYNxpIF10/4ohMqXGhHLTVbEl646VfZXV/1b0wiKQaMFpe 18gvW5+ysZkzvcQo+bEn0mqXXMf4pco= Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 8C89E1FE4E; Mon, 7 Aug 2023 15:06:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691420794; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ORrKyaZwOQ/jexEB7RQEGSlaUvsbs8g0ZAVVA+oTshk=; b=hfz9kNXXkapTsezKRcdELtbZ/iGUbk2GzklyeRXMsp8YDzh+QM6+vBI0ntKmmV8hjvizgA w1dok8drbOzeDmfcIxRzIeKZpgcziKPoYB3M9/PHKRBY2iu3tyiDOOH6djF/x2xKU+MWs7 dFDnnZcjHZcLXJy8LP6KDOlqA48Gy6g= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 4E9952C142; Mon, 7 Aug 2023 15:06:34 +0000 (UTC) Date: Mon, 7 Aug 2023 17:06:33 +0200 From: Petr Mladek To: Andy Shevchenko Cc: Marco Elver , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Subject: Re: [PATCH v2 3/3] lib/vsprintf: Declare no_hash_pointers in sprintf.h Message-ID: References: <20230805175027.50029-1-andriy.shevchenko@linux.intel.com> <20230805175027.50029-4-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230805175027.50029-4-andriy.shevchenko@linux.intel.com> X-Rspam-User: X-Stat-Signature: n7qiw8yezziddkomb3ze4kppqwo8oora X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 54B1740015 X-HE-Tag: 1691420795-68816 X-HE-Meta: U2FsdGVkX18XV33pWlJ4M1jIieWb9JS31X1qkwUPQNvYWhJqWENYAeUhRwSgqIkpyBoxKes69J3hwLBD34gRkFT0exeqqMB1q4M0WVwkA8MifvR+Yqu+0IQWyR3Y2uIBSBOOehTFV7Sw2rVlSe40wheyDgWf13reZqgKY/O5R4t3uQ9egl67ZNnD+7uHj0d380rE+fCXB6U6Gjpw1k2MtbI9qduu/uAyfspFQlA+esYi684XpEQf/VoYQOrM8YJC/T7Gxd2uaZUu5KCeHbe7bzOa1qWKbd+uvJBYuXLyQuM6njgZ0uR7mADQ9Q+XtZg9H7fxYL0YKYHheSx3oPiNp7pjf+ZEwwraH1RM2tIzZctKL2bQS68ojocO2Pu1JVXvpaNoYf4+lkcoWj84jFYrUoZKWeK+cdqiNdeK7+e3JVvcxoaEF6oqCaHl9mt4CCxRy1+RiIS3WTjg6CHREVaaKVOC6q3gC5g4ooz5MA+1mn8q57iNvDUqHL0eOG7OQrF+RD1aRgeWWsnECc+1q6eZhItsCd3plQFdRKI/+wayQvNOVKDohj25/YXjSwmeXtPRC8p9TBbtGftmTw1wypyMurrTkdYzLxBoTSJOwiwr5uxbi3Uhb8ry3zaiE2XtfHcclzy548+2F6Y2Ppk54AZfxB/E+iaLLsAzmQv39m+ede7skuK3VWrmiSL+qU/StWQke4WbqP1XEoaqiUTqCaN2F8k9oo9x5FSD4JeK+7tJ6epZTs7qfdiPB7k+nBOr4VXk/h/Wcin/SHnIwGVev7bE7WPAzujKSawfrTkZdsE/pBJ24YE68eJx1dQ6xjaa5QaEptVwj2wowSPI8Hltj20ZCZEtgacIl/9U4y5QDSMSLZTajSYBkkopfvDv2caMNbEcN4YPFyDQ5oopfMUNT5SFN21/8Zo2JnHpFw/c1GFL5jGAZzC6ejNVsdZ1e4R9zXQf3KsaEXVrtLllR6zjFw1 xqZrB/Oa hY/l7KVvbeUoornxNPFMPA5EJbjaFgZzn+okm8MZ09ccyHFeqE9uFVWc2TxUO1Y855rm5brvD7XfCba1WNSDij+21Dmglv85IVB7dRPGOFnT2nLumznqH798lF/CfS1eH+gvmXpes9PUPoVB+beoK8NaqOYeBLOmkz2mBWStBYem08KQUS8GtQjTGKZoUL0RnnmfZAjdtFzu8qEZI5Jn2ilrZwQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat 2023-08-05 20:50:27, Andy Shevchenko wrote: > Sparse is not happy to see non-static variable without declaration: > lib/vsprintf.c:61:6: warning: symbol 'no_hash_pointers' was not declared. Should it be static? > > Declare respective variable in the sprintf.h. With this, add a comment > to discourage its use if no real need. > > Signed-off-by: Andy Shevchenko > --- > include/linux/sprintf.h | 2 ++ > lib/test_printf.c | 2 -- > mm/kfence/report.c | 3 +-- If we agreed to move sprintf() declarations into printk.h then this might go to printk.h as well. Best Regards, Petr