From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1362C00528 for ; Mon, 7 Aug 2023 15:04:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 529F16B007B; Mon, 7 Aug 2023 11:04:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D9DD8D0003; Mon, 7 Aug 2023 11:04:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A0C18D0002; Mon, 7 Aug 2023 11:04:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2740E6B007B for ; Mon, 7 Aug 2023 11:04:45 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BFDE4120B34 for ; Mon, 7 Aug 2023 15:04:44 +0000 (UTC) X-FDA: 81097630488.14.8F77CFA Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf01.hostedemail.com (Postfix) with ESMTP id D09A84008D for ; Mon, 7 Aug 2023 15:03:22 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=e6SNj8R7; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf01.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=pmladek@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691420603; a=rsa-sha256; cv=none; b=L9fTUFcZ82/Q8NgJ/GWc1FtTpEDMg7mV1wXYAFJLh/DUCxhPIB4IN/6mvVL3oXC/GyJA0/ Lxn9T6afkUtiPZgEqzzcxOGu+qjcbjft/cU1OxBUWwCWs0/isdNpikNtxXz71+A3zJ8646 fTEw4ipVTKbufPe61ge4puL9VQk39+o= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=e6SNj8R7; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf01.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=pmladek@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691420603; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X3A2NsvXpmNRnd8PNau9KuaPdja1LGVqq+oucwV7B34=; b=Q/1cYEms/dgh0SKyyZtD5cf1cMfZZvaqv19IHwMvzuG9M2hVUcFqisUxShpmxqaKktyoPy xtV0hsqAeOkjzV3M8hUJVif/ySH9fGI9KrFRtXw/DHMdkEApXRsgA+WgkhA4syK0fqAy9/ DNr6fa7IRAMEPragT6MMDicYdiFzBBo= Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id DE1E91FE49; Mon, 7 Aug 2023 15:03:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691420600; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X3A2NsvXpmNRnd8PNau9KuaPdja1LGVqq+oucwV7B34=; b=e6SNj8R713ZAAtu9DcuUfZqEtfKTl8DeMypsLAoGTGdfqcoR4T2yEVzvjrykJiB1+VmeYO vcmcyfr/xYigmi95BOsdYOgMbOC+xj8cZff8BI/GiNnTw8pgUn9StcWccERojMAS69TpnF SqkgvXce6Ob9uND7M59kPc3u1X0maqI= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 5ADD22C142; Mon, 7 Aug 2023 15:03:20 +0000 (UTC) Date: Mon, 7 Aug 2023 17:03:19 +0200 From: Petr Mladek To: Andy Shevchenko Cc: Marco Elver , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Subject: Re: [PATCH v2 2/3] lib/vsprintf: Split out sprintf() and friends Message-ID: References: <20230805175027.50029-1-andriy.shevchenko@linux.intel.com> <20230805175027.50029-3-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230805175027.50029-3-andriy.shevchenko@linux.intel.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D09A84008D X-Stat-Signature: w8tp68qn7w74gkenisnqfn3pxq6ig7mt X-HE-Tag: 1691420602-6710 X-HE-Meta: U2FsdGVkX1/zty6uCfXiWfKUtyEcU4uXp6dSW+2jKZ4B9s33Ck2CV67/KjswCTqaKDaE5EmrBE3QGPZykph7Cza7lHCH5GOduc38Kr7b/t7FZI5RAfI581JrWH/TQ5aPZvN4DK8aYgM0K2Z7KlPvQEDfkmBiKgwmtGt+lwNvcpdprtpGpsnGYv+FS65VsJebjexSa7S7Gbeh4L+Ye6gMEiAaASY9WtL4qsL25UOCLnqZVG1+MoGxXtfFX0t2dY4H3nUverXByR1eb14SJLOn45+E0V9oPz0EVYynEFvkgoggkEuEacb97tr+UxZC6hBdcHp4uuo1KuUGy+1pWbIPetpkMm8hs6NVdroC/reWbsFcetL1zR/FtcoRUxKXhUkzeHqo6KsnfZxgcZ/zEj9nyyf05mVei8z6BYbx9lPTlnO2Hr/mVHSJ94+GkTAi3IyxXQX35UYQ2KhcKKenTfusEhHOMpSv4euqOAFuoc4q9D/8FqxAjSrYGIhFFuTpo8lAMg0pqKtTRmPuQzNUYnQp4M3/MSb8o+LsHgNkqGo2FCrLr7pxmUMm7+LyXo2G/SHMFzIS0iM4enINwqVxHh6+b7vsWawWv1MHfdhZ4Vp8KWZiwcWP/uJqAnRHNrTXvGPRIQtB1utZAV30CWp6yXfo7J2x9OGWwoys2lm4yTyMXJ+fqLlIcaE9ZmHbAY8uw1cqxcnPTL2Gn7jmPYbng7gPMjJsHJhfqjwdLHyreyz6084hMx4/ygTpjnqb2xDk9jwjecFKTadurjtPLuJ7LbtZ8aWrWdtBrwv4rrf9WT3NGEqMO1+u2By6hsm/4zPyQ+4dEaHEnOxbxlO5FDbAIFpHn4d0XeMw9p/UkhEMCPFHaRx2TPnepErOUaADA4Dry74PqBwVBdE4C4ROxljQVHCk0GPtsQdkCaeXE5LeOljyzEWJm6G5ym2VHWstZP3/7PrDdtkfIS02h5ptKKJMsG3 spPxrgny UeKKVtn11bKugKTGShoM8YerTJJDldQB/hbmXF0fZY50ydXYcPfBlVEMXYtVtoKQfoDqT8/YHVCh8zmyMPlTirhxIRK3rbF1VfT1YDE0/NSMNBxQxSm7gb7o5FRKGXlTMHC5QTmfKwSK4n4RHeyjm2UB60PR81R6HMBCFyLgbnb6qNnA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat 2023-08-05 20:50:26, Andy Shevchenko wrote: > kernel.h is being used as a dump for all kinds of stuff for a long time. > sprintf() and friends are used in many drivers without need of the full > kernel.h dependency train with it. > > Here is the attempt on cleaning it up by splitting out sprintf() and > friends. > > Signed-off-by: Andy Shevchenko > --- > include/linux/kernel.h | 30 +----------------------------- > include/linux/sprintf.h | 25 +++++++++++++++++++++++++ > lib/test_printf.c | 1 + > lib/vsprintf.c | 1 + > 4 files changed, 28 insertions(+), 29 deletions(-) > create mode 100644 include/linux/sprintf.h I agree that kernel.h is not the right place. But are there any numbers how much separate sprintf.h might safe? Maybe, we should not reinvent the wheel and get inspired by userspace. sprintf() and friends are basic functions which most people know from userspace. And it is pretty handy that the kernel variants are are mostly compatible as well. IMHO, it might be handful when they are also included similar way as in userspace. From my POV printk.h is like stdio.h. And we already have include/linux/stdarg.h where the v*print*() function might fit nicely. How does this sound, please? Best Regards, Petr