From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F36F3C00528 for ; Mon, 7 Aug 2023 14:59:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7479E6B0072; Mon, 7 Aug 2023 10:59:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F7B26B0074; Mon, 7 Aug 2023 10:59:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BF6A8D0002; Mon, 7 Aug 2023 10:59:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4C2C66B0072 for ; Mon, 7 Aug 2023 10:59:04 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 15FF38052C for ; Mon, 7 Aug 2023 14:59:04 +0000 (UTC) X-FDA: 81097616208.02.136EE31 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by imf14.hostedemail.com (Postfix) with ESMTP id 6B0D4100016 for ; Mon, 7 Aug 2023 14:59:01 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=KdJmnK3t; spf=none (imf14.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.151) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691420341; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wncTibvFCPYKiKKeWBp/BRtDhPuU5ncFeaxhSgM3H9c=; b=yHBHYccWakvyY9DkKawzqSib0hyqp9Qr4OG0AtBoh0N9H0CF4aEJQluPx1rn+VgUI4Y8wp MVAQA8hlJbJLYdVQUPsK02E09LHyirY07USvCUdqM6A/HbFRFwiBSuuX5PucGWWOfvAEk/ CeGk74KjL1Bu5sax21p2Vhokkdli3VY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691420341; a=rsa-sha256; cv=none; b=hSmZQ8HrZh+uuWz0hE+a5Pof2PmK6TOON7p3ctIbJL1h0C3bP/sxfVdeS6Voeak3iwpjFz QjM2YwXcPzsMg1pJcQPu9sBcr6HRekbaNSCZFI5BXqk3g2z7CvM9Ct/eXeqMQqLQ57Gm+t NLDq55KCdwn0popoRDwvQISCCzJXaDM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=KdJmnK3t; spf=none (imf14.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.151) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691420341; x=1722956341; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6jKYcqoZbZb+y6bFjNGXgbrH6GTB4XHCuMLza1e1NpA=; b=KdJmnK3t04hNZIAyaI1jwQowuiqN1hkaXz0JbIx+aHRyC8v55ZNvTuwb ZF2cwlBDZ/4Dg/2qGjSBNASewXud4hNHmTBc1y8upGWdCIHbyNdTB2PVM Lz5Tbg73pxtPsrkweEsz1itrrnF/3ywQgHdz+sDgl8ZeXqvkqd4d1C5VS Y2kD6aBkZbpdhgNjzhFcAIQ3HVLAd0t4gy+Qp2QhEH+VNRGDSWgAVk4eu p6jZ7LNscrfvnHtsH66YBxwBpewKYemZF8eVIxA6wbUmzK3kmrPWQSnPy ZGoY9SQSsE/9bglrjq4ptITK23/OMTO0iN+vz/eRTYFXIDZemeD/ATsNp A==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="350872885" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="350872885" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2023 07:58:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="800960674" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="800960674" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 07 Aug 2023 07:58:56 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qT1h8-00GNLO-24; Mon, 07 Aug 2023 17:58:54 +0300 Date: Mon, 7 Aug 2023 17:58:54 +0300 From: Andy Shevchenko To: Petr Mladek Cc: Marco Elver , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Subject: Re: [PATCH v2 1/3] lib/vsprintf: Sort headers alphabetically Message-ID: References: <20230805175027.50029-1-andriy.shevchenko@linux.intel.com> <20230805175027.50029-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Queue-Id: 6B0D4100016 X-Rspam-User: X-Stat-Signature: t67118ba4t3hs7atrjabaiwh8xb59p7b X-Rspamd-Server: rspam03 X-HE-Tag: 1691420341-2034 X-HE-Meta: U2FsdGVkX18a9RMrneKHBMYWLp0emWM29MnOWFVf0JFHHeS7Jz1EfP+J5XVoGjklFJYhjyd89GattWHFowhobY04ml4RKX6Rl5bCdDUJqoQU++GPT6c3r9lkGELSlwzI9imnZD0/6T2WUhR8RYKt6BoOnPLlBXiQdIh3DUf/Gmi/b7vgD3+8ltTHqdqtDvlI7n58e7Ge9ooTkEu0YsFb6AYMSN2FxFaCe/uyUhxKzrkNu+RhGUB5BfYZzXqdnx9EeFZrmwjSW3zZQPhXmglOxfuB38NBNg8ugE5MIcmDty8XGt3Psdg3L07uDkY8W7v7pbuZH8qNruWdu14N01YbGnxNxuXBNogUJYr54b8GTzotauu3FtQwRGoHS0NzT9kKIUwvzAVwv4k+DKXViCCAC3wV2226wwbWoAUoleehXU8Q+Wme2vu7oKfqOW1TCxRhvkjxAK5q/6DxjULNqI0qVv71ccORI+FmWnWu8VVWk0Mze02d05HOBgSLodsYOxi3txVEGKCfwmOVX2D0vT7VXbEgN4PHPos6dt2WKUNSgrNeHPE3ovAaXZwb1OF+w4HsEw97ji+ibUB0FW75h+ig9SKl4VMxDJWwi9TdQrdnO28PNGArGm7oRO1Bmc7ajCLlsYS6KVePFGxmZwVCMTj1kRL1Z2wp2Lrh/u6wJCMGiK4f85d+mDBzYMRZDBauK7pCsPYr/dlX0EKBuLo2IyedrJUv1CPS4XpjEq64rbaFKl2ZGxz09yeex+foIHmi9txNrbXRGQ4k9LZtFUZiPJuw0m337pZWWxvZ5eLO/StfBcspHz35VTEt/Xs15lhpe4KGPYq9wJWCC8UMYnVQY3R2vA/tUs7+4n7iKMr36u/usad6emPg4Ii6l84UA1qQnN2+oCKr2koHLW6ar208PwmrOu8zRYmC3Oc+t3cCMexcJl3WuXeITpdKNWXmfSGnsBY/MVPb8/OGAYw9AE3Z3sH xvIF1Dvk iaqKN6C7GxJUL1aGYfB91qlsNzxiDTpOoxl+yIKRo8zRFrh4hfvjhtArodkFq7AmNUu6HENfUfbfodWU3cqkWO32OqvOJkx60M3fbangDAUDeXXWYRjleX1z9o6Ugs0/Fcp2s0YT4gnloyCPQ4z4Jh/zEJ1kKcD54BX6c7JlWQVTg3Y8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001104, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 07, 2023 at 04:31:37PM +0200, Petr Mladek wrote: > On Sat 2023-08-05 20:50:25, Andy Shevchenko wrote: > > Sorting headers alphabetically helps locating duplicates, and > > make it easier to figure out where to insert new headers. > > I agree that includes become a mess after some time. But I am > not persuaded that sorting them alphabetically in random source > files help anything. > > Is this part of some grand plan for the entire kernel, please? > Is this outcome from some particular discussion? > Will this become a well know rule checked by checkpatch.pl? > > I am personally not going to reject patches because of wrongly > sorted headers unless there is some real plan behind it. > > I agree that it might look better. An inverse Christmas' tree > also looks better. But it does not mean that it makes the life > easier. It does from my point of view as maintainability is increased. > The important things are still hidden in the details > (every single line). > > From my POV, this patch would just create a mess in the git > history and complicate backporting. > > I am sorry but I will not accept this patch unless there > is a wide consensus that this makes sense. Your choice, of course, But I see in practice dup headers being added, or some unrelated ones left untouched because header list mess, and in those cases sorting can help (a bit) in my opinion. TL;DR: I was tolerating unsorted mess (for really long header inclusion block) up to the point when I realized how it helps people to maintain the code. -- With Best Regards, Andy Shevchenko