From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 268F1C001B0 for ; Mon, 7 Aug 2023 14:31:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E5D66B0072; Mon, 7 Aug 2023 10:31:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BC626B0074; Mon, 7 Aug 2023 10:31:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5ABA26B0075; Mon, 7 Aug 2023 10:31:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4C3386B0072 for ; Mon, 7 Aug 2023 10:31:53 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F2183C0AE5 for ; Mon, 7 Aug 2023 14:31:52 +0000 (UTC) X-FDA: 81097547664.07.9129AB9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf09.hostedemail.com (Postfix) with ESMTP id E4242140068 for ; Mon, 7 Aug 2023 14:31:40 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=puqzPyxh; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf09.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=pmladek@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691418701; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4fOeICDyT7K2QTKRJ6MV/fDafXjEn/AufQ8OCjlhJmc=; b=VS/KF8da2j5zgwTUrQ5b0TbkK61o/F3r4xQiZZ9fjkpI6EUItUYMy177ql/UC4/SfJTAvI L/uKmU4cVIzc1Owsfld0cNOYJZq3Dg1mqyhW6ZnSmlHSDh/AOatUdIaP9cIe4fsUV6Tw2S J11dbyl/s3osM6LrU4OxIvFRxiWPVQc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=puqzPyxh; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf09.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=pmladek@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691418701; a=rsa-sha256; cv=none; b=SgdjiBRNdIyiFuGk7a14GRx0njWglbV2da+wqFhv6yehfmtN3yYFp9M5Mw+5AvD5oqcMQM ujmjrzcWHabnlypAftCbdeXGO/j6JwXWKY29N8ZCF/tQPrdk19feSyADeXUMItU5iomhc6 +NDT4SP7Guv7/HTbIupd2o1W6zmVhAY= Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 04FCF21AD5; Mon, 7 Aug 2023 14:31:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691418699; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4fOeICDyT7K2QTKRJ6MV/fDafXjEn/AufQ8OCjlhJmc=; b=puqzPyxhDS8ihrRf7XaMDxl1YL8jIPCi/Ga1d289a63yhac0KgN5cQaEGTMDjJJXoTqFlz upyj4HIHL5ISq9mQ8GCQDEshQyCEwPXxCKW2USu/qL8RndfTxybR14Ob4/BR0WJ+9gPiA1 OE2/xx3GVn9eTxXE6xVB4hj3bcPNYPA= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 5E5292C142; Mon, 7 Aug 2023 14:31:38 +0000 (UTC) Date: Mon, 7 Aug 2023 16:31:37 +0200 From: Petr Mladek To: Andy Shevchenko Cc: Marco Elver , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Subject: Re: [PATCH v2 1/3] lib/vsprintf: Sort headers alphabetically Message-ID: References: <20230805175027.50029-1-andriy.shevchenko@linux.intel.com> <20230805175027.50029-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230805175027.50029-2-andriy.shevchenko@linux.intel.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E4242140068 X-Stat-Signature: aj9agqgk7hw6mkzdt71ctx89gxdu96qq X-HE-Tag: 1691418700-773085 X-HE-Meta: U2FsdGVkX1/UkkG9XaG+Im+SA30JfctWJZnrWp1RcXgRIR21GJsFM7v35db/xve/GHDl1W2zSklcxDcZI6Z5Myl2TUzMfUN3oQXk7v56FjC8aOQ6nApe4ED080apqNfTku9mFsi03AcOcwVb3U4z+m0zgEPuhFYLX7t34mkjtohTWEAhlUpP9hQ7G1y9Vf1a+tHXoR8zdMu4UmqAAG4mKeaTpEjqRcJUEVXEjoR4Bhx3Vof+K8y3yfPWNZbyGI7IfMLZDJHT2Zuk98a2X6UL4Nuc9K0S2y8hc49ZRiL0JHFUnJOSf7Lee6vBWqRcPERi6+LTIthesbH+x4jZnt2e7LTrSuP5qbzGXu0ljkpi/ztJUPNXDBAbVj3qY645K+ArXsCk5wcXsA/oqwRb9P/frgpIlb3YgjgJjwpGoBydy/JWmf3zL2TEPbsx55AN5Z/GR9WdinnII6iPl3O3wfbvnghw/S106zO+4oszFY4dw55JAeELp2HgaFSZbdC0A9+t1qu1a+RobqLZB5M9gij2Qgoj7yPw1INsag72VnDtUR/opqYpwd9V0fQ5s2fXIWtrIMxuZDX6qrXTAIsj1MNQCcwcJ9pOVloF316WJnYLDL1g90q5+Tl5BW+YjAUse5TVMRAyZrR0tQ9Ag19n282JeCRVB4bJ24CEjf4HzH/7xjdFJk2HLpifsjB0BogP/epibN/J6FVEqpg6z+MuI7zSefhILF65hjRbZ1Zax/nH4/1hctktS9kbyU/oY9OrBU+Zdu1PHFOZRbJlA+zOMLns5clejjGXYgdAdpW0x9ughV6dxF4Ae1m5FOmP/+RD15fSsWSkzItB3O+Ld907wFSf9Pb5pNT1bcrlph6rO0+LaR5Yhzw7ZSdIAGB+U1cBNt2+ZZnSyDKUi0NGKH0fPWCjzZEpO6d+Iw7GsBDofPWjrodzjjdyJILpUebwAS5okG8hn4kYL/7fZiAuAnp+T5K UzB2QVjl ersgFmppcSXSNPtESmQ/qSmfuh9cPEyWYrXQHkdY6j1gQvgyz1ZpXzuaSt03Z+NDX/DKVNsfz8pV9S2lfMa1KAXFCHMVmUyIXTio2PeWPtOX+4QqnLGE6Qar2q/lB8m2tSFkfEATQWN4QDfZHMA4WAlMfRw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.004138, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat 2023-08-05 20:50:25, Andy Shevchenko wrote: > Sorting headers alphabetically helps locating duplicates, and > make it easier to figure out where to insert new headers. I agree that includes become a mess after some time. But I am not persuaded that sorting them alphabetically in random source files help anything. Is this part of some grand plan for the entire kernel, please? Is this outcome from some particular discussion? Will this become a well know rule checked by checkpatch.pl? I am personally not going to reject patches because of wrongly sorted headers unless there is some real plan behind it. I agree that it might look better. An inverse Christmas' tree also looks better. But it does not mean that it makes the life easier. The important things are still hidden in the details (every single line). >From my POV, this patch would just create a mess in the git history and complicate backporting. I am sorry but I will not accept this patch unless there is a wide consensus that this makes sense. Best Regards, Petr