From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 406A7C07E8B for ; Wed, 16 Aug 2023 18:41:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A19B28001B; Wed, 16 Aug 2023 14:41:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 851718D0001; Wed, 16 Aug 2023 14:41:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7405328001B; Wed, 16 Aug 2023 14:41:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 610E18D0001 for ; Wed, 16 Aug 2023 14:41:24 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 354AF1A0732 for ; Wed, 16 Aug 2023 18:41:24 +0000 (UTC) X-FDA: 81130835688.02.EB69AC5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 0FDBA140012 for ; Wed, 16 Aug 2023 18:41:21 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Rez3Cb78; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692211282; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CU9DWRuQVtz+NiMHTdyB07EnkShG5B6QCmpz2Q3GQuY=; b=NvIIzxdAutJ01lpKmcszUXruhxvOGsNJo5xJeoCidtO6Z0/+SOYofSYT6tFViXl3XZjR8S /OpuQwlEjk+/amGhuaPAW0SgM0z+Ct+JxVoYEKJpTsMUwOnMPC9yU90ZHTuqeAcL9ArEzd Nx+fbGvg9AZip3ggPkcKgcs2CNsUn/I= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Rez3Cb78; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692211282; a=rsa-sha256; cv=none; b=B2EYLwHmWrlVy+dvIrUa0RPJpUwbTOL0xqayl7xpE/g0QWwxb0lO1sxAoJQbTnlNkSV+vZ Z4AIQzrwG62xzQYGr4DMwj9QdDL28xq0EOuB8rdfIawYKgmY/oNGKHjwsC/zD0YeTabpdA ras5jWhlKT3rML0JLopd5HrYY1fHyGE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CU9DWRuQVtz+NiMHTdyB07EnkShG5B6QCmpz2Q3GQuY=; b=Rez3Cb78XPGne3zPRxlwPkh4lf ye9rNSEVBRnOouLi9yt0lCwa5cabNtrpAp6Ql2AWv57bSwje3jdCv76RCnBHr5VlsK55ZOjGp86Yd Ro4iegAA3pL2xUMWr+9JPyEslQNyb74WVgSClo4qs4ut1H5uygITBWNieGcp7w8oIVVHA9p4bcdGu ILGqdgLyw9KgnKqO4Uw1/kMdn35EFi45oLiGvxMf8U0XvEyaNr+Bm7xLZEc9Uojoc7S89ZiMtQIEl ExU+OJP5KnIHuFdoMTuOsALmcx8zw4LNHHfOZ9IBomBUQsX0fdqUxjMpPCp30AIrxYTSYipnIE6f9 wEGsCnzA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qWLSC-00GG5E-Ug; Wed, 16 Aug 2023 18:41:12 +0000 Date: Wed, 16 Aug 2023 19:41:12 +0100 From: Matthew Wilcox To: David Hildenbrand Cc: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Hugh Dickins , "Kirill A . Shutemov" , Randy Dunlap , Mike Kravetz , Yu Zhao , Ryan Roberts , Andrew Morton , Yang Shi Subject: Re: [PATCH RFC v3] mm: Proper document tail pages fields for folio Message-ID: References: <20230815212547.431693-1-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 0FDBA140012 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 96zj7zsmtukojwwihgjonzfkeezd5aif X-HE-Tag: 1692211281-293505 X-HE-Meta: U2FsdGVkX18trqa5IP/+M0Mitux/RXdq4z+NhYnTe2fVPivvasyRUObmShQ7D3XecPPwtHrfenBmLW+R4tpsBG4MCjhBmWv7P1eBS3V6Db4t/xrIEM+EasSIWc+MfwenCBV3BIOgs4NsALiDpYz/r3pxmuobYnerNinCzlwOqiM4TefTs5ENNmwxDK3I0RvxKfcqH7VCoVZHOFEqUS5jjWsMqIzPte1Pre/r+Kz+A2bhatywagDhY6svxyqxbLrLpjGCaOIIGsWISqRCKpvYFJXT9hDgmGg/zz3S1XBfgl21KkAiS/d7k1+RU6cGlQWBzupIvGCwlPXpSLxxgwZfBWa4GH+wUuUxBN8YivxQMBlsyjYkQ9peEJCFUxY7QxNMdYPS/mxOI4s1RlMLeS9IyJl+aI+Os87cadP9zt4DFsJtadK5WS1UuD77WJEZOOADrSmB6m0OXb1QzNBdnDzl0P0JSu3cXEvaHTC1IC2J1hKNpyP4itfj4H7N4zo9hNLIWDqPysP/+LW84nxJHLnCM+vMuwx1NslSpDyMp9MWAWPw2JDGrsz3Dl38UufmWsbMXzVC+kGbqGgHHViagHH16aMkFnCUy8ZjatWrRUKTYE8Eh8PaFapQH23dMX55xHHJMkh3Eh2FWuymPGsCZ5Pb+qPMQPQFiS3I/hTH4BItiAU55WforyXXgbpF9emvztbIf0qgfRYIAIJ7BxGChgv8pGZa3zyAYOc+8f73awic1BwTE0GFu4l761zl1q7OOX519EExV8DkyVqvAb9Epo1+EZX9EazstpTaJDuwzl3DYTo5DOPngMaMMbtaIrz+VqB8rX5e9sIFbJTwkSUJUoqjKapBbNnD6g7uDPY38jV8Jw9cMXXzXJ4ptX3dVFxh62aJ1dbUBt0gRNDVvnaSEA/V4xnOtx1qS13/EqSEposV+CaAK0IJp2cqOT4XpAoRHDpFyxEi1BUBcLaCskCnFLY dnNG6s98 lgiJJJ4DwIPLwQB30IauwGsYSfSn2LPH5V/WuNqDytAQAXHSU04OAg0Oo3KQFPK5dSj51KD0S6ir26sOUI32EbJllMA3Y7SfBKD7iu9ac0x0vVe/rMex6HsJGcWlnhZBUc6KP2hycfTjyFXA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 16, 2023 at 03:33:30PM +0200, David Hildenbrand wrote: > My simple tests passed so far. If there isn't something obvious missing, > I can do more testing and send this as an official patch. I think you missed one: +++ b/mm/swapfile.c @@ -1490,7 +1490,7 @@ int swp_swapcount(swp_entry_t entry) page = vmalloc_to_page(p->swap_map + offset); offset &= ~PAGE_MASK; - VM_BUG_ON(page_private(page) != SWP_CONTINUED); + VM_BUG_ON(page_swap_entry(page).val != SWP_CONTINUED); do { page = list_next_entry(page, lru); I'm not smart enough to understand the use of the one in add_swap_count_continuation(). Maybe that also needs to be fixed? Maybe it should be fixed for consistency anyway.