From: Matthew Wilcox <willy@infradead.org>
To: Peter Xu <peterx@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Yang Shi <shy828301@gmail.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
David Hildenbrand <david@redhat.com>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm: Wire up tail page poisoning over ->mappings
Date: Fri, 18 Aug 2023 23:14:28 +0100 [thread overview]
Message-ID: <ZN/tRLy0e+Iod9z3@casper.infradead.org> (raw)
In-Reply-To: <20230815210659.430010-1-peterx@redhat.com>
On Tue, Aug 15, 2023 at 05:06:59PM -0400, Peter Xu wrote:
> I split this out from another rfc series. Removed RFC tag because it
> wasn't for this patch but for the documentation updates. I'll post the rfc
> part alone. Comments welcomed, thanks.
I still hate it, as I explained here:
https://lore.kernel.org/linux-mm/ZNp7yUgUrIpILnXu@casper.infradead.org/
> > + * When the tail page's mapping field reused, it'll be exempted from
> > + * ->mapping poisoning and checks. Also see the macro TAIL_MAPPING.
> > + */
> > +#define TAIL_MAPPING_REUSED_MAX (2)
>
> More importantly, I think this is over-parametrisation. If you start to
> use extra fields in struct folio, just change the code in page_alloc.c
> directly.
next prev parent reply other threads:[~2023-08-18 22:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 21:06 Peter Xu
2023-08-18 22:14 ` Matthew Wilcox [this message]
2023-08-21 1:13 ` Peter Xu
2023-08-21 2:29 ` Matthew Wilcox
2023-08-21 16:48 ` Peter Xu
2023-08-22 15:18 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZN/tRLy0e+Iod9z3@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=peterx@redhat.com \
--cc=shy828301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox