From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21D4CEE4992 for ; Fri, 18 Aug 2023 23:01:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 679AA280067; Fri, 18 Aug 2023 19:01:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62A10940012; Fri, 18 Aug 2023 19:01:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F1B1280067; Fri, 18 Aug 2023 19:01:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 401D5940012 for ; Fri, 18 Aug 2023 19:01:32 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 10FC71CA35E for ; Fri, 18 Aug 2023 23:01:31 +0000 (UTC) X-FDA: 81138748824.10.39B8E5F Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf11.hostedemail.com (Postfix) with ESMTP id 56E7540012 for ; Fri, 18 Aug 2023 23:01:29 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=gS9arkhq; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of 3SPjfZAYKCOUZLHUQJNVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--seanjc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3SPjfZAYKCOUZLHUQJNVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--seanjc.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692399689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=usNReEG1yhZ2OoI1bkcsHZxi8vJT2uNEbLMV9P1BADc=; b=JRDZ0raUTs14Vq6A0cYQmgkGiWfuq45HLWoiy1VubIvEAxwxxY7B4Voa/IQhcuY5j42pwB DMR+rsaDYRvtDtOtEpMuDqKHNrMw5R3FP0Aij5cwsOmtljno9AhWvMupUgw7whD9A4I9Gz v2dPCFRMSRowFfSGT/7ycBzkFSmf7Co= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=gS9arkhq; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of 3SPjfZAYKCOUZLHUQJNVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--seanjc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3SPjfZAYKCOUZLHUQJNVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--seanjc.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692399689; a=rsa-sha256; cv=none; b=LspCHj4GM8jveB/gDF25WjzrWly1Q/1lwzxL32AjLraN/Bjf8tAt0o6BahxY6oQXjL7qtf wADbvgHFrJwFT9+SfnlfQIGQhnYhdR9g1XRZ2tUPhZdCEJuDLmyTPZs2fvuAFbwnqDmILd EV64f8p8cAxK2f9Xr9aXLJBTde/OWwQ= Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-d6412374defso1814807276.0 for ; Fri, 18 Aug 2023 16:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692399688; x=1693004488; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=usNReEG1yhZ2OoI1bkcsHZxi8vJT2uNEbLMV9P1BADc=; b=gS9arkhq2BQM5wyG90faWG4pywmMu5sfjHEWd04bKy84agcqatheT6YSVqsnMAhJXs 7Ey6R/IsFpbuJAgflRTfCsGQSeE7z8aCnsHRbxEkKBK/PAH7FMZgZEavx3BeBXM+3P+2 Plq9VhZaRy5PbOx8EDNA03ytcClkYRB9Plt+OD+UltS53ZO5IOuVPHa/Yt8AOkDtjpGf J0ReekJEPtY7ifZaoOCUWVj24ZOCPfNYabKI/jnVy+VGWVTelTn6BvdxHdiQrBc+k/kc BoETN+5H+qyvqSzJ4nWEMxKRREF2ybV9p6gaBfB8lx1V/iAPfjWa3WjZDIbTKQp0bm0Z IJkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692399688; x=1693004488; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=usNReEG1yhZ2OoI1bkcsHZxi8vJT2uNEbLMV9P1BADc=; b=Z8DLmhZvPg835okxbrJYxrlHBDcih/sCnZXEBGHjJ8m/WJBw9DszNvRlbOizQ5sJQH FzSz85/FTyc0KG8D7luQABN7oIOsOtTAUxthx4m67RSz+n2YDbiXWTC+4mSSifnNef6E jGyVF2Y9gpZ4I/Q+DEIJtoxf9EXLvp4VL1Z89do9SjwNFNr9RVeHZ3bn3/JcBEVDTaJ/ bBbR2jrDi3HuDVOEZBktYJThP0pkV0/g4h0TyyW8igAglCtt1i+K6qxZVu8Uu0eW73g/ AEm8H+tVZzA+l8uVbsukrgGSoaYvQhUqUmHlUjkKilS3rnO/IRdx+6/1l2W1oii/Z0bJ Fo0Q== X-Gm-Message-State: AOJu0YxaSSN/wmQt/qOon1IItN1zLrgfrKWVxz2y887WrWk9NO0Kxvun R2VtS0ZH5VTOZF06EgrbnO44mptlWRw= X-Google-Smtp-Source: AGHT+IHoaUgHi5iMS/0Xt5cvUarFzMCVBDWHJfa8lAvVIAai8wyXyMLBOgyLMJxxiXlZfzlnoz9PoDeIZVI= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:a8a:b0:d74:347:1e3 with SMTP id cd10-20020a0569020a8a00b00d74034701e3mr5755ybb.9.1692399688376; Fri, 18 Aug 2023 16:01:28 -0700 (PDT) Date: Fri, 18 Aug 2023 16:01:26 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230718234512.1690985-29-seanjc@google.com> Message-ID: Subject: Re: [RFC PATCH v11 28/29] KVM: selftests: Add basic selftest for guest_memfd() From: Sean Christopherson To: Ackerley Tng Cc: pbonzini@redhat.com, maz@kernel.org, oliver.upton@linux.dev, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, willy@infradead.org, akpm@linux-foundation.org, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, chao.p.peng@linux.intel.com, tabba@google.com, jarkko@kernel.org, yu.c.zhang@linux.intel.com, vannapurve@google.com, mail@maciej.szmigiero.name, vbabka@suse.cz, david@redhat.com, qperret@google.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com Content-Type: text/plain; charset="us-ascii" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 56E7540012 X-Stat-Signature: n6mh6ru7g9gra89derybb86bh7z5puyb X-Rspam-User: X-HE-Tag: 1692399689-753789 X-HE-Meta: U2FsdGVkX18flUoxXfe93qfv2uTKpN7NzRGR30ASSOoCr0zEPqwQPJAufVRtq1A+2Zl/1kOpl29LuX4UaydFd2q7WiLwjd+QzM/WwkL3xR3s2TAuKjyPFdc3xVnl4h2ow5ng9X9USJ+piyGuPwA313LkowhSadWRZ23U09WJYDez/Y+eLgUMCkbR2i/PBemWrsYvrsR34BLk7Zefos/icAe4ijeCG7zE/t5zR97RUj5cvAirjw3FSE3C+L5Q/Toqwo9pAuUFSuez+nlB5Do7P7M6/vG5YStQKOxL5X35DHSwc8Q89zziSMSoaetX82AHcZqIghpx3BImnXfvSsqMDB3xocxHITuKcEHB0Jj8UQRw7xyopkfvkW82Zb/OhyiFiq4ZphxsXmXQO3SlYxGcXwN3sE2UHsnw/pL4/9TrjHHjV+RXm4ohPq3yJqqO5PC3BRpEdmmGOPbE1ZiP7vX6MemYyeCtU9wy33LfXGiQ4prUDIzGcQAV/FgH8pNilo8m6o/d2HcG6FPYjrSiUikPPWabtCrWPO/kWwB5ghyJM7DOnB4M3A7nMPp15BNXLokKuQiYS2m+6vV+7Hq6mwgg4bLxfGiSi0vpStMz2jskGxO5k6bDAqA3n3yAn6KGnzGYHbDYeK6hkcI9IMDZ8qk4PIoN6Nlh/x+A579I6AVcOdRPjEnaLN5GEWPkfxdOE4B3IwJxhTCpgLTbKNaQ0AwZzDbUtzSwVZ0LoBPQlCDdDU0oE2v9DBRZkVG19McsBmU1E0rl7iVxepUonyy5eFOf4+CUSh6JDIwZ7vui8Og4bgNN9cpYsEftyKZ2g+6u15Al9Sn5N8gxIXlsGTQIY7aj/L4YV+kkNOX22s6393pYL4DcU/1mSsLdL12NBTkzMwc94cTzJDvnnl3njvNmnkNJmPyr+b2WhgIzSqW7eONjhypiDi6fOXRk3sAquImA7gVGh5ZpSi6suc2LnJstqQp dWk1EREM 5q+s4ZJBPRMdhadon32YUB3L5acCP6fnlOFL3hsB9LJ5vqjncEgHNqo6MAHo4QGVyuM9QOgfo0MDsXv9MSERZI3oaBvSjwx7pY7JO20iAGAlnCb91Mjur55oolKg6KjwyVjiCvU/HMITpAnxsniNDQk6zjFFlbVmoeqnyfImOHCYlF08Ep+ZoazjFsZ81l9xw8ipEmTbjquI8UueuviyfoPflFJNWY2UxF+ImZYLDFyHGMwMpMHEXGC2MF3xYq8R3/09aPxDhPq0Xe9U3lOSAOQNF8jNoVsSUZF9qjoja9jCSQRLgmgqO60THkECY3MoHhDgdT34cRWdiRAot+zkNejSG/BY+rYnVnHu8TYS+CtszqyrL02Vn0nRaq+cwLNXTOJeVPZuayI5U7KFUvT1jEXdqVdeJEiggs7BpLPDWAj/f2LP67JuJ0GQC2lG4LgfnV3x/tk9780l4o0owzedHjbEdhMEDTjsWL8Bz3K4WHhcKGOdnaNIzP4UrtLeEhPWp2lHAo9iZLcvB4m/Woz/9kI0IFqpNAGa7n8Nk5I/+UjkIThJaan7pnIi4+SFVzKLsKDa3OH6wJV3I7LjcBPANdLc7j+KsOeFYnu76aR5/lYrcsLa+OhPlt05YJyJdw5HoeR+uI87ECaMJYwVrID85NXRhc57x6IA6hU926/cnGJK19OERvUzuNOoCPRAqYh4+cyPjsWqh1d7/UN/tMS+0kN1qSYx46QYKCYGuDltnn1fzLQJRH7ptvbNH9ceChOHiQtyW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 07, 2023, Ackerley Tng wrote: > Sean Christopherson writes: > > > Add a selftest to verify the basic functionality of guest_memfd(): > > > > > > Here's one more test: First off, thank you! I greatly appreciate all the selftests work you (and others!) have been doing. For v2, can you please post a standalone patch? My workflow barfs on unrelated, inlined patches. I'm guessing I can get b4 to play nice, but it's easier to just yell at people :-) > >From 72dc6836f01bdd613d64d4c6a4f2af8f2b777ba2 Mon Sep 17 00:00:00 2001 > From: Ackerley Tng > Date: Tue, 1 Aug 2023 18:02:50 +0000 > Subject: [PATCH] KVM: selftests: Add tests - invalid inputs for > KVM_CREATE_GUEST_MEMFD > > Test that invalid inputs for KVM_CREATE_GUEST_MEMFD, such as > non-page-aligned page size and invalid flags, are rejected by the > KVM_CREATE_GUEST_MEMFD with EINVAL > > Signed-off-by: Ackerley Tng > --- > tools/testing/selftests/kvm/guest_memfd_test.c | 17 +++++++++++++++++ > .../selftests/kvm/include/kvm_util_base.h | 11 +++++++++-- > 2 files changed, 26 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c > index eb93c608a7e0..ad20f11b2d2c 100644 > --- a/tools/testing/selftests/kvm/guest_memfd_test.c > +++ b/tools/testing/selftests/kvm/guest_memfd_test.c > @@ -90,6 +90,21 @@ static void test_fallocate(int fd, size_t page_size, size_t total_size) > TEST_ASSERT(!ret, "fallocate to restore punched hole should succeed"); > } > > +static void test_create_guest_memfd_invalid(struct kvm_vm *vm, size_t page_size) > +{ > + int fd; > + > + /* Non-page-aligned page_size */ Instead of adding a comment, use the message from TEST_ASSERT() to communicate that information to the reader *and* to anyone that encounters failures. > + fd = __vm_create_guest_memfd(vm, 1, 0); ioctls() are fast. Rather than hardcode one value, iterate over a range of values, e.g. for (size = 0; size < page_size; size++) { r = __vm_create_guest_memfd(vm, size, 0); TEST_ASSERT(r && errno == EINVAL, "Informative error message...); } > + ASSERT_EQ(errno, EINVAL); > + > + /* Invalid flags */ > + fd = __vm_create_guest_memfd(vm, page_size, 99); > + ASSERT_EQ(fd, -1); > + ASSERT_EQ(errno, EINVAL); And then same thing here. Then you can use the legal flags to determine what is and isn't valid, instead of using a completely arbitrary magic number.