From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B3CFC001DE for ; Fri, 4 Aug 2023 03:50:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E81A82802C5; Thu, 3 Aug 2023 23:50:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E32032802BC; Thu, 3 Aug 2023 23:50:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D201B2802C5; Thu, 3 Aug 2023 23:50:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C223E2802BC for ; Thu, 3 Aug 2023 23:50:23 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 82567B2DA3 for ; Fri, 4 Aug 2023 03:50:23 +0000 (UTC) X-FDA: 81085044726.14.47FB446 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id DED3920023 for ; Fri, 4 Aug 2023 03:50:21 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UKi7MCXm; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691121022; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F+lJKFltZ+yQxd96NjAiSlGEaIJzdn+HIXjUUFBSS5c=; b=TOSwIxMuuCWgurlJCIjSEqHSH6BsGLDMdc2gSQpjLMGLThk4/1ClB6Uqre5bPeNzxdEQvR uIl31cD3Xvcjx8H8VkASd5VEnSB31o2AIh0NiehbXgdI/zOloARf9fO/NIgcXGhWEzWWGW sJOMfwoTZBMWceiDBm9w2xCNRKeg23E= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UKi7MCXm; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691121022; a=rsa-sha256; cv=none; b=z7B3bycxRP5+vgk6Ht5vAJ4hn1IaMrmuvdo4MqOaCGp2tY0JBLEGE/ujbypqQOj39FRU4P HoRtXvEjzOasnWev5Q3un6EivswWjNiSbmHaOvVs+R8Z4Lto7MnGtwPVUvG6ksxfSGnJok I+Rfvh8K8Rh379lNjAJcaUl1DTCDKkI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=F+lJKFltZ+yQxd96NjAiSlGEaIJzdn+HIXjUUFBSS5c=; b=UKi7MCXmu/eFaLtMvBvufRKVdU DaCDf7FpNDWKsVmLjSyGc6/yxeFqe3Y81Jv2wMiXxhN/acrrYIe+cLWVA8Ngm3flCWpw67hZ8Cq4h 8XatmpxPtkcPu+sDGM5Cv6LLrV48z7za5rh77704UnbEhMUUkjRA9o79maxq1G6k7Ln4V5cixK8H2 a3fsMVVuWgMsVAnQo2mUm+DynVTptf6Dewygne5j2FslBjF8LOOfG+zqFWNk2xZgABdUpXOFJoksb QfmLEyGJDj8wEgWRD3ZdYiXVJzfDHWttImP7dp1vRY5vAlUPDEydhyidN3Jx5OrS6NKXkVdN48mXp yq8AMDtg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qRlpN-007del-Ap; Fri, 04 Aug 2023 03:50:13 +0000 Date: Fri, 4 Aug 2023 04:50:13 +0100 From: Matthew Wilcox To: Nathan Chancellor Cc: Andrew Morton , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Rapoport , Michael Ellerman , Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v6 21/38] powerpc: Implement the new page table range API Message-ID: References: <20230802151406.3735276-1-willy@infradead.org> <20230802151406.3735276-22-willy@infradead.org> <20230803233814.GA2515372@dev-arch.thelio-3990X> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230803233814.GA2515372@dev-arch.thelio-3990X> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DED3920023 X-Stat-Signature: unr8zgs8k9autjzkdpi947zifdddpywh X-HE-Tag: 1691121021-628380 X-HE-Meta: U2FsdGVkX1/U/AsexgJBhe6ewmZSoeJGWPP38T4wO2sgr/eGpKsN83ht/ZAF1Rv51D/I29JmZhcQg3wOyct3sL5xw2yEap+N/WmGAHkQhLD+DK5IRkvNjQ1jJ2U49PhoJ1+5Qjy0ahAWcATCaHWq5CsaMcPI2FQgVmgTPyWvIRWIak28laIGfi1LMPKxjbpEnJC92egIrB54tv1c45X8pijLF2dr3AhJCnpO9EwuObqBM27iONdOIe4OJVLAt4rdcniqqvlzTPUlnqd36Wq+/kwksePrdsrbjghwb7IQgv1rvDY8G9iVywc62Ed6YcgLR1sijrnpDCzlS41XVOvo0JzRMjUvKy6Hw9CyLIxac5sYlYWqhf+cPX37u8XSQhhxbdiVWw8JOmDcSANJamVv4KNd/oI4vB7Wbh30Jgmtl9uj6hV625OWg9SKkWKjOhOBQFLYzoOKnPv1/GLmw4+IH49gA/KituTKGoz78DdD3QRJ/g58R9B6ZKCOt1vxtqeTrrfG0mOCI84nUrfOfu7m5rPY+lUW7eWc+qdcyqx6QSoU9IJXEQ4UMrnqFeJMyWuQLVy1US4SM086w3HSBw54fu/QaB2AAUPS5TbRfStet/YvXfOx35erNq0dYbytM0O/MR9xAAXAv6h/HJ+Aj1J7fnDjScnImfKJzTVfQL+sdifYkKEMhFGj+S2u39QAFmCEcyAOcGLd6yDF1BCEkheS9Fem9dSiw7qvqbgxY6jBCwfKUxHVbNFzs30fruQLoBdQWwkEBH0DXWJ3QdqsgpbXL8kxXcWt48wK79GhGmtQIBEIfLZzCfNBzqip0Wb0Gl7sirOZxGsVk7omFUXsQcZ/bn2xgbwusdyYii0eBu1FFvb21Smx/nx99Hg2C7/3799GfLCzqKSxA3nPVBYSqeIh8jrf573CKliNoOTn8sFCwTepwU5StAvPAvQLbmbcM3382h+WUrJJnueVmyZTes4 CN+hPB4G i3qdSue4J7lMwRHEHUhKNEpgl0RZANjThtHS3jQkyViXGuv9VXPkErOZt0Bis6pzpqXxPSvHiepBqAD3q56zLRKrhgI7DLbHt8UOqApMSHuFMcWY4SDv86tR3A4N1yW2nGutx08hEHsa6VUk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 03, 2023 at 04:38:14PM -0700, Nathan Chancellor wrote: > > -EXPORT_SYMBOL(flush_dcache_icache_page); > > Apologies if this has already been fixed or reported, I searched lore > and did not find anything. The dropping of this export in combination > with the conversion above appears to cause ARCH=powerpc allmodconfig to > fail with: > > ERROR: modpost: "flush_dcache_icache_folio" [arch/powerpc/kvm/kvm-pr.ko] undefined! > > I don't know if this should be re-exported or not but that does > obviously resolve the issue. Well, that was clumsy of me. I (and the Intel build bot) did test several build combos, but clearly didn't manage to find a config that showed this problem. Andrew, a fix patch for you to integrate, if you would: diff --git a/arch/powerpc/mm/cacheflush.c b/arch/powerpc/mm/cacheflush.c index 8760d2223abe..15189592da09 100644 --- a/arch/powerpc/mm/cacheflush.c +++ b/arch/powerpc/mm/cacheflush.c @@ -172,6 +172,7 @@ void flush_dcache_icache_folio(struct folio *folio) flush_dcache_icache_phys((pfn + i) * PAGE_SIZE); } } +EXPORT_SYMBOL(flush_dcache_icache_folio); void clear_user_page(void *page, unsigned long vaddr, struct page *pg) {