From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69BDFEB64DD for ; Thu, 3 Aug 2023 12:31:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F293280242; Thu, 3 Aug 2023 08:31:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C9DA28022C; Thu, 3 Aug 2023 08:31:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B8EC280242; Thu, 3 Aug 2023 08:31:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7701428022C for ; Thu, 3 Aug 2023 08:31:25 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 38801A1102 for ; Thu, 3 Aug 2023 12:31:25 +0000 (UTC) X-FDA: 81082728930.15.8F199AB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 6D32380002 for ; Thu, 3 Aug 2023 12:31:23 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=o+EfmnK3; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691065883; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jrrQ1ew0WFVnz/xz5L6c3rnCJXjhIyFg0HVApXBxJR4=; b=U6HGvEa9Z41H2K1+wJu7HLISCIiBNg0nBEhB9WdOf/9cboSshR5kGqdMsdrqddvAF8v9g7 7i0tmL0rpI0XTnBy3dbKra4Hx96iSvSnQw509aGe2fr7upEwO6y8flHHqYblvqOTD3J92w 2ip64p+Smv6h1qzVqCmnua3AkCI1GXQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691065883; a=rsa-sha256; cv=none; b=VI9wJM1HgQlWIXndB+o25NT1Usc6WgtHOSBPIn7Koy48Flb0X6bixPejPVWcICs4KLgfzz OtUVRei+8O4Ock8JiR9lff9LYlUBTQT3QyDLIYbXiZpL/VLK/tUOQwZVj0xmA9a2RR8rtz abdzhtW+2arJOZjH5AG+TSjOGZx1B1M= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=o+EfmnK3; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jrrQ1ew0WFVnz/xz5L6c3rnCJXjhIyFg0HVApXBxJR4=; b=o+EfmnK3lrw9lQrJI1G1sncWqi pwT9Bl5/ayBEKbqkJK32aoGRYFP01OjSuceBTeAXUAXgNRroLsO1IAfL6au0x3wE3L1D7t17cUryf VGN2tvvwdkKASfjnrzdQPfK1Rn8KdWzhzCj+ejMJbQurKk9x9kjx2R/WUNWUpfGLl5TygwZ/x6gzg K9ovjsi/8g1HdEcJbfKzVytAUNE3fn/VF13oIYNJA0kc/jdb64V3Y6f2Ulep7M2Ke+oSiMN2StKHs lLSb4ryzUfN6Dl9ZZvumGps4U3psmcHysNoFnp111Ld07Dxh/PdzinWXWIijJ+LmRMoR/jdL+JFv5 gfeIgepQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qRXU7-003dMt-I0; Thu, 03 Aug 2023 12:31:19 +0000 Date: Thu, 3 Aug 2023 13:31:19 +0100 From: Matthew Wilcox To: Ruan Jinjie Cc: linux-mm@kvack.org, Mike Kravetz , Muchun Song , Andrew Morton Subject: Re: [PATCH -next] mm: use helper function put_resv_map() Message-ID: References: <20230803120312.945774-1-ruanjinjie@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230803120312.945774-1-ruanjinjie@huawei.com> X-Rspamd-Queue-Id: 6D32380002 X-Rspam-User: X-Stat-Signature: fzwg971r1pfww19yc5krqjq6dkj8bm19 X-Rspamd-Server: rspam03 X-HE-Tag: 1691065883-369107 X-HE-Meta: U2FsdGVkX1+pqnsIZemfdrTbHAvintbIQcOYtnOTen21obTTlVv8viu2JYp0M1QVaHiFiXzWvP5YzNKdUDG/GLmVPbnPiTJ08T33irEXQCOUe4gihfymoPqCyP5TgOmsKaPlpKkbkKcgVMEAK2alfKuIuJLjxht6ZFE8F5P+dJ6AUmFj+73WTIajt2nc/Q1uFspf9sUFqOZN5ajQvP8oRJY14uq9Ib7EHUHPa1HQRzBPELLndg7gk3YemGZfzq79bq9tmAV7Bl5GsMgwV+UTI40Czy0Fdsbz5U8wWgqTUyl9i9riFJIgQyzFGPZrUT4dBHvmHme4f31nXgrQNT83s3VfE8MA8WkzM7v3PycsOvap/Mv8j7W3b9cpdqqAHdqcZzxjkkJJXb39fD3jk2nqWIHmXmefPS1e+sIc3vKzZQ0Y6gZbUCqZ/QW/srz/Pv9vwmnK+iXDrCoeMrIkZbZkUx/kJzGGkS0ebvgBD1OiJq8FAtXpcDoHkStGv0JxXKjMArFe93FmQhfC0oT6RflwwdlgQhuzclvs4P0EYX3pHjlUvu0fzPDervlIVhuoAGfcj69YEWEuCsRppFX9fMMVQBtykKwNuBLznrIKRLEVs5n7OkJFXP9yTk+/OEgpPXhSo/eglILhvU58OYYRtDUZCHQBJG3QTxPONgUrC524T7+ZH8pLF7fPZWP1tzgSqY3MpwIuyaT38t+Q5lu53cbekPGuClmB6XR8YljJ781ZkbkXiE9gACbydFUFYxLxsSdK4p+QerHNQ1nVMj0Xym5L6ubYlEu2+GSTNmLQaUuBbIwtbWOUi3zvL16+xvYMEXAw34KIudfzIL/ERFa/JS6jPsOJsc9F6l7DpAPzEewi58venepHgABtI+8S5oU3KcUDk8J/hvnjOEDqDGm6DZDq3eqcr42h7bm6wTsDa0gUswuX7S8gqfZO3sj6Zm0YsJpaO7Vrvdir9ZYOMX28M4t sOlEh81p Bj+k4r43JNwo4YhXGcJfv6cjGD4olI7XIgIPWIzLKhH8WkyBtzrlGA7u0q+7ocAQcOpD9nrEFmtGmj0BKsmV7TLhpqhRqaydye0lUaGeD/6MACyXMCvfMBm3Exw6gW7K5y5Gzng0nqry8rDutK2u7vbJpY9imv5rSaGxNcBuXwsfdJ4VE6OZ9niq50A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 03, 2023 at 08:03:12PM +0800, Ruan Jinjie wrote: > This code is already duplicated 3 times, use helper function > put_resv_map() to release reserved and allocated regions instead of > open code it to help improve code readability a bit. I do not think this is an improvement.