From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97D6FEB64DD for ; Thu, 3 Aug 2023 12:30:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C5E1280241; Thu, 3 Aug 2023 08:30:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 275F228022C; Thu, 3 Aug 2023 08:30:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16511280241; Thu, 3 Aug 2023 08:30:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 06A6828022C for ; Thu, 3 Aug 2023 08:30:33 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AC8F6B19C6 for ; Thu, 3 Aug 2023 12:30:32 +0000 (UTC) X-FDA: 81082726704.25.3B79F51 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 5443610000C for ; Thu, 3 Aug 2023 12:30:27 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ioOJ9uor; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691065828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+GBZoisSMbVY7fBPLSgxdUKAz4UO3mFAPyDKEIWzr3s=; b=ciVy64BNn8ZrOHvRhn2ve3M0UvqLHY0IX+vabmloN88eBaBlBarwG8ZNR9PP9yaBSgb4DU Ch5QHw/FP1HUvWn9pPNxBbjVMQBifc1ZLWh+Z0z5VEPMKE77uGxD2w9QpFE32D2pKfKvq9 2uxUcCV53VDcIml8GfCLAsgQ1nyKm5Y= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ioOJ9uor; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691065828; a=rsa-sha256; cv=none; b=xhQ21hTy8Jfz1BJThJFqBzBxGrNeInxW/LYx+eRkROZrKpSvrt9htXM4QhKVEPY+MNNEtc QvqGtbZ5LTN9WR2we3rhjRLeUI+Q8szqlYWH5rzgAaOdPBJAbr2T0RLpPQnHHdJv+/dOJ/ ReIk5nNgZ/DzrlozoPTaj4fslCIvWz4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+GBZoisSMbVY7fBPLSgxdUKAz4UO3mFAPyDKEIWzr3s=; b=ioOJ9uorxOLEyrm9ld/C2rO8EA ATmR1hfJ2DAYYGEgzH9tdKbku/JjdGnEe2YnPoqGUSXMh3qY6P5aTE4j4muSxx35gG6i1Zwm0HYZL Y3QZ57/eUSM8tpf/0FlFkcchwFYv1nn2brYYv3gdkOfHGp/m8tJhLdICZgfxlR3TTBEjBFBV0n6EA J0U/aPTqAvWQ848zav2g/Xq6qYdj3EEDBHGaJbV/fRfastADNeBOHEDFnb9U5nVgPZDSZddPJaMB6 JL8Qt9EXzZmOlMJkO6Wm0wOPIMaTmwI/qsqA18nXA20A9Drl6e1p359IEuZOuQcSo8LBPUBex0lyC rdAqmzRw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qRXTB-003dKU-Ch; Thu, 03 Aug 2023 12:30:21 +0000 Date: Thu, 3 Aug 2023 13:30:21 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Huang Ying , David Hildenbrand Subject: Re: [PATCH 1/4] mm: migrate: use a folio in add_page_for_migration() Message-ID: References: <20230802095346.87449-1-wangkefeng.wang@huawei.com> <20230802095346.87449-2-wangkefeng.wang@huawei.com> <001ee9b0-ea25-a896-e3ae-9a9b05a46546@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <001ee9b0-ea25-a896-e3ae-9a9b05a46546@huawei.com> X-Rspamd-Queue-Id: 5443610000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: zucgs5zzmazigq13izubruq8tjjofnfi X-HE-Tag: 1691065827-163538 X-HE-Meta: U2FsdGVkX19trMFJMFQ3MAoCmOZRk+A1/UMeR3v+SDgV09NTIdMdHyjM3rY/Xi3GVEnIAXHUaJheHyRg/RaewdWbFxuPGoDg4omIaHIRo5l5PHnqx3X97+t8SaRVLB0JjFbXi8GTPd3t/qbsqfMgkUPNgLb4pBiKvCXGCI/+bSWeSmblrBerjpqzR7EvNKLfo8sp8PyyMVUFt5jEtPmuBq1rm6Bd/8xbu9di04lXNeuZqEdEWMKyAFStD48MN+aHBuiQo/3a541gquE5SuMRdI9aPvLuJsXkzoOttmnYEmOgbvHGU8uZo4BRUCjnxO1bwXb7jlwniNs+hMvs+7vxzlz5XoQ+NCV/UZ1UwOP5dmldA3dLFQz9cf+EOCghyJhpP8RKc/Sv6ANKP8BnH8P3H2zm/nX1pF/JUDBcq2NpIUCZ2poFgIX9BYhzzXHE3WrgPJxuQXxrOyj3FHDgur8h5usaBEuh6oAKOcNgAmrpNA/EMqNZRevZD3yw/uPsIKuoTQGHkqzd3pOs6uIFh2bg5EE2taa8vPR99KSY+ZPsbbdf+LtdRE8QN8Sai7rBS6Y35njtc13rB8T6PekESEbGBy4CroVbNcRDdBSPDd6HzhXIiVSh72JUjkIiP85Gyjy3HYj0beaWAh+grKpu0zNNPwbwPHYryDAQq4o3z0xeIuTRGj8jpqbhsh5RPRA7zZRzcPMdD59I5vmIN6yBUGscQdocN1FRiWJuuKWIkrRxJSwtdz3lgoYi0EKE4XX128SXxO8O606QCeQujwNkY+EJ3Fxs2i6wzolVzGeuye3dCOtpTmnIHHyilRStLI+EB+P3Kmwv88SMYVILvb5NvULdQwDAmsdz059wlOECSeXvcggp0qKVWL5ktzrFtQ6f0a5AXzxBgptzWjFPjsR0ZpAiaoAfkiQXRxFZo1WQOFaoQ9N1rnBK/nFUCVIyjOo8u1Xny2yzOqQUq5bllUG/NhB axxOeQt7 zQ3VR3ngGzNl0blEfFJLjhyXRXhtnxF13tGMP70paqpSPMrCTTvY8YXMmHBsC9kQKN4kzFicpKbvu+hqZzeiXfjlvXb5uXAiOmFDnek985CyC9WsX/yBNyD/KEpHjmB5Vpg1Gq2M9fI5Mjg/86z83BL3upx815QPwSq3bASFxxHgtss64omGIwjZHpg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 03, 2023 at 03:13:21PM +0800, Kefeng Wang wrote: > > > On 2023/8/2 20:21, Matthew Wilcox wrote: > > On Wed, Aug 02, 2023 at 05:53:43PM +0800, Kefeng Wang wrote: > > > err = -EACCES; > > > - if (page_mapcount(page) > 1 && !migrate_all) > > > - goto out_putpage; > > > + if (folio_estimated_sharers(folio) > 1 && !migrate_all) > > > + goto out_putfolio; > > > > I do not think this is the correct change. Maybe leave this line > > alone. > > Ok, I am aware of the discussion about this in other mail, will not > change it(also the next two patch about this function), or wait the > new work of David. > > > > > - if (PageHuge(page)) { > > > - if (PageHead(page)) { > > > - isolated = isolate_hugetlb(page_folio(page), pagelist); > > > + if (folio_test_hugetlb(folio)) { > > > + if (folio_test_large(folio)) { > > > > This makes no sense when you read it. All hugetlb folios are large, > > by definition. Think about what this code used to do, and what it > > should be changed to. > > hugetlb folio is self large folio, will drop redundant check No, that's not the difference. Keep thinking about it. This is not a mechanical translation!