From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83398C001DF for ; Thu, 3 Aug 2023 14:56:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BA1F280271; Thu, 3 Aug 2023 10:56:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16AEB28022C; Thu, 3 Aug 2023 10:56:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0335A280271; Thu, 3 Aug 2023 10:55:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E8B1A28022C for ; Thu, 3 Aug 2023 10:55:59 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BBB00A11E4 for ; Thu, 3 Aug 2023 14:55:59 +0000 (UTC) X-FDA: 81083093238.17.14D22BA Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf12.hostedemail.com (Postfix) with ESMTP id A104A4001A for ; Thu, 3 Aug 2023 14:55:57 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=kVP0di1g; spf=pass (imf12.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691074558; a=rsa-sha256; cv=none; b=zNEWMApHc+zjXKRTGqzam2bi6yTzzLnwCBEDv7M37QqeI1uKX+ysDC2nHcHgj430YXLUou r80OUZAhhRqa9a2HfWnzOlLBXTB1LMJpFFw0k5enGOU+O2BfooWJo/X6YcyONVEUu8ifW6 Sbt6TWRwG8ABP1cxLLvhPnbJb9q/P/8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=kVP0di1g; spf=pass (imf12.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691074558; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/VNlnAgBc91S2tYQvLwrXhvlLqKeVtz0vo49rvSQNPE=; b=3rNwTmp+D0iwchdUAu08TU3bRj3OSynpPUjxZbMAe1V5PELijbAPSFymGA69EsVF/24IFf eiTTMrBWb/JlN34u0yBp6A1Nm5RrjeoIRv5GNX8835NxMkC3/68EStUs2FK4CsoauFZp1/ AohVDp6fQ8nJP2ZBQTNdspkTXzlfkZI= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4C0E21F747; Thu, 3 Aug 2023 14:55:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691074556; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/VNlnAgBc91S2tYQvLwrXhvlLqKeVtz0vo49rvSQNPE=; b=kVP0di1gzsJsEBbQQkq4/uiFNVNskhJjfzgyi/9R6Qhac7n1+AnbpJ3GFGHXK1e+0/sDW6 sq63HRQ8VLd7ptKuupjYjswPoJqTloEdleyab3q5EYZ4DzgBIi9l/Py/OhKsDxNCtMEd3n 8pBrxdzb8ugos/N86bbFPaoIGR7Bv4s= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 27E03134B0; Thu, 3 Aug 2023 14:55:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id orjIBvy/y2SwHwAAMHmgww (envelope-from ); Thu, 03 Aug 2023 14:55:56 +0000 Date: Thu, 3 Aug 2023 16:55:55 +0200 From: Michal Hocko To: Yosry Ahmed Cc: Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3] mm: memcg: use rstat for non-hierarchical stats Message-ID: References: <20230726153223.821757-1-yosryahmed@google.com> <20230726153223.821757-2-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A104A4001A X-Stat-Signature: u6orfmuy6irihheapzbb5qxnske4smsq X-Rspam-User: X-HE-Tag: 1691074557-575952 X-HE-Meta: U2FsdGVkX19m3aTbReGJVCl7DweZiOYwigNjUY0vIlIMlVi/1vI8yZIOx7BY4Uyx8YwIWMPaSQ/CGpfRZTM3DNjRfYZwbG/lazRFbMrcHxWLeYsS/1HPAa2HBC5Zq+HDH7DUpBEBMdsqRfRY6pXfdDRaV3Z1/pIQ74JPaCRwRCG/0i0pbtHlvJX0nACz8GoCwjSOjBaKKQcmEeOK4co+m/4QV8/Whuo8ph87NxB1/0CemCCRF6veGaP0W7/4/Nfzh1UUgkdWUzrbbUcfRwcKYQI7ENMeU/ORSjMpqQzXVov8dSUYx3tAswUEGeYi86KYP/bovjqn/okI0JyKWL9LUwyUqr5EGDdZfaFSYQ7/A9zAcaRtCIguNLswsoLFl0/aw/5SYoFDUqKs5LDl4XU+XygJI7DX4Wm008NvuuoaMnYAjb9H7fNkFMuClwK1T5/mtGXbQO1bfbi5foEqyqUM3r1A1/rTw7qQuQPKL4Cepd1t0gOjx+BE3i6mmwSQ1fVVXVAFdNXqvWARdntE6mkKLvVZMOCBKiT2Nj81qtTY7hrealBd+0kW8H3arLRdk1glgsz4rJ97PF2xpImCikFANPg4KYVXrm6dOiXpscgSuRL74BCMsovRQFAlfduZydp1rOQij4jN+cX+79X4czzJMfoBFdwm+jRQr3rhpWXOOhWBJ/AItxGYghRu7+GEhIN0AbQXqcfS5ZXyJp+O4hU0st5zx8ejRaZn3++Q7aDza0UuhFws+r2J0+H/yPocK+oKsluBb5ruXz8SgQNSAdqVUd6RuNs0IJhi2+QEtdP+xcdq0QIF4FtpPopAEQJ99gF4z/ptPcoJSmRk4RAvsz8jd/PWpyBT5A5c9tFthcQKQFCmKwBjNmBT+4/93dE2i+PS+J/svZN5edb7KA+T6HKeTR6VM8b0T4D/oSRllV+mXiQbScovlqONKwcB9/OpRiKzJISxS3tEnSQcHwKopeJ RdouIGcM 5oScuZl+pvCK+Ushh2HZ+z+R+tO0TbGyVqXDIEkD8M25rmqthHTjADQi6VOURFrJDIW3mfukxOF71rJmDsgHRRSF3R8EENB9ILqOY34qVrwUFLOaxTa4qzdF7k8kCabdIB66HnTlaURHRNu5FEmBgIvc7wNN5vq3oCv2MCz6doqWDtzaF5naRTEk3cUBYNPq0MXFRi1XiO0wceD8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 02-08-23 15:02:55, Yosry Ahmed wrote: [...] > Let me know if the testing is satisfactory for you. I can send an > updated commit log accordingly with a summary of this conversation. Yes this should be sufficient as it exercises all the CPUs so the overhead in flushing should be visible if this was a real deal. I would have gone with kernel build test as that has a broader code coverage but this artificial test should give some red flags as well. So good enough. Amending the changelog with this would be helpful as well so that future us and others will know what kind of testing has been done. Acked-by: Michal Hocko > > > > -- > > > Michal Hocko > > > SUSE Labs > #!/bin/bash > > NR_CPUS=$(getconf _NPROCESSORS_ONLN) > NR_CGROUPS=$(( NR_CPUS * 2 )) > TEST_MB=50 > TOTAL_MB=$((TEST_MB * NR_CGROUPS)) > TMPFS=$(mktemp -d) > ROOT="/sys/fs/cgroup/" > ZRAM_DEV="/mnt/devtmpfs/zram0" > > cleanup() { > umount $TMPFS > rm -rf $TMPFS > for i in $(seq $NR_CGROUPS); do > cgroup="$ROOT/cg$i" > rmdir $cgroup > done > swapoff $ZRAM_DEV > echo 1 > "/sys/block/zram0/reset" > } > trap cleanup INT QUIT EXIT > > # Setup zram > echo $((TOTAL_MB << 20)) > "/sys/block/zram0/disksize" > mkswap $ZRAM_DEV > swapon $ZRAM_DEV > echo "Setup zram done" > > # Create cgroups, set limits > echo "+memory" > "$ROOT/cgroup.subtree_control" > for i in $(seq $NR_CGROUPS); do > cgroup="$ROOT/cg$i" > mkdir $cgroup > echo $(( (TEST_MB << 20) / 4)) > "$cgroup/memory.max" > done > echo "Setup cgroups done" > > # Start workers to allocate tmpfs memory > mount -t tmpfs none $TMPFS > for i in $(seq $NR_CGROUPS); do > cgroup="$ROOT/cg$i" > f="$TMPFS/tmp$i" > (echo 0 > "$cgroup/cgroup.procs" && > dd if=/dev/zero of=$f bs=1M count=$TEST_MB status=none && > cat $f > /dev/null)& > done > > # Wait for workers > wait -- Michal Hocko SUSE Labs