From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AD2BC001E0 for ; Wed, 2 Aug 2023 13:46:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCBEB28017C; Wed, 2 Aug 2023 09:46:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D7B5A280143; Wed, 2 Aug 2023 09:46:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF60F28017C; Wed, 2 Aug 2023 09:46:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B1087280143 for ; Wed, 2 Aug 2023 09:46:31 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7F8CD120F5A for ; Wed, 2 Aug 2023 13:46:31 +0000 (UTC) X-FDA: 81079289382.22.AF2BD58 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 643A540026 for ; Wed, 2 Aug 2023 13:46:27 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NvyUM+JB; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690983988; a=rsa-sha256; cv=none; b=AUIdEF4nEdEWqjPsSVFM+F8O7r0RkuRQZiPdjaLDkLjfDWhgKDswDMB6A84sv0ER/gONhU tHWUYPGDtVVIJAqrFekSR5iBoqBadIlNqamyyQi+JJEDAyrFYyeQULg8jWmKuVNx7qeuhq ZyuKDvLHLfdzOYbLfM+joyiSW5wLbvU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NvyUM+JB; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690983988; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v/HxkH+MwMRJoj9XZVDChrBs6s8fFrJtnhjR+r44FxE=; b=GTxeHXkJ2Z0JPxNCZZyTPS0KErz0hTsgLUtU28xlkkFjddDySsqO5T1xqu25NyJJTsEMog o634WyRMwNFkWL/jO6krHEBpaQado08S0WsER48oiDhzhDlfrI9BbLg4p5kQEia58kGi5O k4yPhzFQTbTTcEtCRLiM4+rdUkuFwa0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=v/HxkH+MwMRJoj9XZVDChrBs6s8fFrJtnhjR+r44FxE=; b=NvyUM+JBp/xq4xJaZzCRS3wJli mqSKGYiwuXzI4hGj5B/wNO/D6eUOoeGGtDm2PjC7kqJhopmih6pDZMTNw2l+aE/fe7CU95j2Y8s+X jA5q982D9O78ksrjMOMXyLRKbQDpTHe2dhvm+GJ6oOOJ1QNKhPseT8jw0wBjtkhw/cYhsnRpSNK+U atChSXzNjxzUh24Wxn0ffoOTJRsgnAgui4vdHbXDRcsymaX7BRI4JUXElE5tJdKWlIgViOByPmnUN c6fIPpqud3CUKEGLWhH+hDo/naZGAaR+xJzf1a1hyP97rnXrdbfesxBcRvgmFKjvJ7lQGIGQD7Oyy ACgpUsHw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qRCAr-00FGsh-7W; Wed, 02 Aug 2023 13:46:01 +0000 Date: Wed, 2 Aug 2023 14:46:01 +0100 From: Matthew Wilcox To: thunder.leizhen@huaweicloud.com Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, "Paul E . McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , rcu@vger.kernel.org, linux-kernel@vger.kernel.org, Zhen Lei Subject: Re: [PATCH v4 1/2] mm: Remove kmem_valid_obj() Message-ID: References: <20230802130918.1132-1-thunder.leizhen@huaweicloud.com> <20230802130918.1132-2-thunder.leizhen@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230802130918.1132-2-thunder.leizhen@huaweicloud.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 643A540026 X-Stat-Signature: jaxxju15ediyur3k6ntns89uj5qxta8c X-Rspam-User: X-HE-Tag: 1690983987-353196 X-HE-Meta: U2FsdGVkX18bBSkOK5qEj1ZVIaEGCn42piG920nSPpsZexDPhmOxw6rDC7D1v1V4vScT8F8i/SjHPfsjyHK3jIZEhsPe1Ig7Oge3h96zWIKoc19g1iN7xg8UwbrmaR82EU5gO5KUKpr3H9tkS7sw8wuwohx/VwLJ6u6+gmb53JWHlTqKdeLJYyj4gzLM0mB2rWmdIoCHN+yhAzl0zMYkJMbDUQzrJCcZWAIty/2PUsu9hQ+knskYrx0CTtcVy/NqEszWAi3zYQxwt1ThIQNtOdPoqK2hUTkZD0jEs+8eJHTUTNS/STzM0146/up9t9/y48S9h7/10yM95/8ZSiCyjWhgb+VoDoZQ9Cb74wQN6QKFd93oYJoA6nDTzUFZwQj8rMOY/r9GH1mEgxRKrte5aWUuOEPWk4gfh02pcllL4q3KOrzVfSTXPQ2HHzd3+BOypocp4Dmha1j+r6eozgjM9vpqInHELob767d/osMhCHjgDMu1VnntI88KF4iyrCV4P1q49IFNae7sEbegCXKsx6A8McLe3ecwW9TXrY0ndce8k9G/co1aP5uBA6g/tEuyqou4VfXDhc3RdqoQdSUOfZZM/AaMt6SPGBrbikHUevublSnxlmfCv3Y0pcKnUAue4EQNb6bbd7m9r+gP5jDyTiEAr/w9l2PVPiInmpG89+ARKAPjz0Sux9MpP+/bFapWgwCjO8ywmre4CSO73PrnFy8UlQ4hQ1xslbYOqKBTRqNt34jxJ5yt5JlH2s0dBgoWQa+LbmzWgQMqfsGgtrpcnhu8ou2h49vF69aOrl7xmTW4kU+XNCiMcfbJHjpI5JOQoCGUSYNhUSXS+oxMAV7s77zZPmkMuvWfd1W6wzQCwEzVKQjFp/hSG0l+IdVFZUtauVFM9XXeBtN3g25L7JTAqcKMumJoSGIOBMjF2clUPAIZLCbFCtrt/oXzotDq43rs4ce5A1RIbkSP2F9P66Z EzjhcV2f zUQN/dU2fv+A/5TLFzjX4jU4aLkxCcpun7H/w42gWRfat+EIRRSm9qIR2lo03JjeaXSurPHftBwPuj0ia4zPDeJbhH0lAqw287N6BzF2Hq9A+HioKTpkleAoFx+DQWN+0EEMzeWmx/1a6LTUbJFKYv93N+8YAy0wWmpavWvbhGkqkKt6ER5ORvLGHRW5FOs1qtzxCfkTEv2C0df+flotqu5UUHPiyQrRhASN5tSpEaIxqMq8IBEkUmmjUCRBU0lSu9+EelDilSGqKYUptAZaaFiqxsZbiVYDszgB27djH/0MuneGMwsgpTETizzdbWykZMqgNdNcZcqzbOotJvbwM+xb67GbbMw8KuxPTmy+a10tiLc9p5DG/G0haKQRceB1Uk4YL3G7iM7moTuc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 02, 2023 at 09:09:17PM +0800, thunder.leizhen@huaweicloud.com wrote: > From: Zhen Lei > > Function kmem_dump_obj() will splat if passed a pointer to a non-slab > object. So no one will call it directly. It is always necessary to call > kmem_valid_obj() first to determine whether the passed pointer to a > valid slab object. Then merging kmem_valid_obj() into kmem_dump_obj() > will make the code more concise. So convert kmem_dump_obj() to work the > same way as vmalloc_dump_obj(). After this, no one calls kmem_valid_obj() > anymore, and it can be safely removed. > > Suggested-by: Matthew Wilcox > Signed-off-by: Zhen Lei Reviewed-by: Matthew Wilcox (Oracle)