From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C4F3C00528 for ; Wed, 2 Aug 2023 12:37:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD508280169; Wed, 2 Aug 2023 08:37:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8520280143; Wed, 2 Aug 2023 08:37:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7438280169; Wed, 2 Aug 2023 08:37:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 948B5280143 for ; Wed, 2 Aug 2023 08:37:36 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 66107808F2 for ; Wed, 2 Aug 2023 12:37:36 +0000 (UTC) X-FDA: 81079115712.17.07E3505 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id A6A164000A for ; Wed, 2 Aug 2023 12:37:34 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=iiLAOATK; dmarc=none; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690979854; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4ab3GBgwKIO10gaSlc0RTzmhdSzbBvrq8O6cOw4GtT0=; b=2E5iynSCzbo22UcE+OR4aGRg+QjdOoNDFfPVgEA4XqLLgR/rozPBgRGNxheR0OmAbS1hFa SgjpIk93wVCfhq3wc0T+GwBF3PZ6v6I/XBZ3JmGil/t9w7tsi8xZGmcpSkcyeahd9EdCd1 Lu4wGgurc643uiAV3mYbUng4sLgOMVk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=iiLAOATK; dmarc=none; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690979854; a=rsa-sha256; cv=none; b=xMULfAQSJo0iaDh3WCqZSk/BWwb3mPawAHkj5ECLc9aNMuKdNONVoRUfFH/PWSbvAmL+Ym RzIpZVpmCXUow/7PTTx7M7mNEVPOZSOkcjnVWHJ7dp0W2urdPIwt5kbhgVlIyEeSwqZNtI cuJdPQhmCfr6F6SOx8kQNueGKy+DvGc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4ab3GBgwKIO10gaSlc0RTzmhdSzbBvrq8O6cOw4GtT0=; b=iiLAOATKrbDDzwGM0wgHxZ6GSE U5WQgdgmbZXe3Iy1e4WjW7hOQuE1RBjldaZ7XhL32Kd9TkMVDgADECgdZfXu4evOfN2uCDP7eNLl/ GjzQYBxhpedsmyAenLPuLfDdG+HxRpJIeAUiz2gg6I6Pu3GROIN9hrnPXqS2Udrxl4hwNy0S+Sux4 AQSUYC0FAWh7BCDjBAh6vnGRdDir99V8GalYCs26a2jFYsrfDjJQyR8BuCQbGJ1Kuy9t+jCe3W1+c QprGGZajo7oiqPmfPrIcieYtUj8zVZLIB4b2Ip8Bc/reli6NSODXmhbJIHYGtLjeMaJgL1aK5odeB YwCXGZPA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qRB6Y-00EyMw-3l; Wed, 02 Aug 2023 12:37:30 +0000 Date: Wed, 2 Aug 2023 13:37:30 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Huang Ying , David Hildenbrand Subject: Re: [PATCH 4/4] mm: migrate: use __folio_test_movable() Message-ID: References: <20230802095346.87449-1-wangkefeng.wang@huawei.com> <20230802095346.87449-5-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230802095346.87449-5-wangkefeng.wang@huawei.com> X-Rspam-User: X-Stat-Signature: 7zqxzhjkk5fngckagmpuhy4j5ucn3r1n X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A6A164000A X-HE-Tag: 1690979854-498244 X-HE-Meta: U2FsdGVkX1+RvsHt7NhIPLdoBqROlzqGfz43oDyJhWBfMsGTE+Yt5s2S8bCLOqd+QjhRXNTMH8a6BJSEHLnDZVmUSV65ADyMsbKl7bj/BNIBLoLM/rECkhRzmWWx29L5vO+2y6wslF2+fTNBMsVTqCX9Wnh6VTVbTUhOruxT2N6sgXz5fgrZnwDAmQCbI2EHmdz84wwJxtASjd+HHq7IW3gvb/bcMezipJYr1eh9m6FW6sucOE7DBnEWLPxnmX/1ncod3OAvrEWmyyjvqlFGb9NPLy8AqG05+TTiaNP3v6gOnpc33OtttfRF+fLJzO9pUpdvip1+BMw3YizO8R2F7ic+67S0UzKzVrkTahIN1qbocuR/A1IsabbvG0YGyfzlMwk15Klo00Ajz7d3bWip8ec6OGOTVtMeNo8fsywYF0yWdb3lh1Ma3QMqDhimiUJ1q8xLDoocHU+F83NlupCUDwi8f0pkoHNjBRVH5oIsaRs5OKcqdrzMcWuXFiY3yyvMBRENfAJ5xxmkiYEi1aE0mLuHJcV3WulO1H4FkXu5AiO0QnJ6wcMEYJY7X3AqG5JYJqXAeON9l9odKbjaPaKELM3M8s2yJ2cMZQS/9qxl0O9nXuGq9n7gXWx6SLplErsqpRJMEFRudriIy5e65zfKuFPYKYeY51U59eH+ZaYpgnTVlrE7lR8U04o2kmepbZdXHJaoRBMoWNFvEeJ//X+X+nIABlujE737VbBJTOuyITF4YvWL7b4Bd9EY/NDL9A8nhIscm+8Gczv571b69Ui1UqjkT5dh+WScNteZs8g+oq6qSTTTPzVMBMSaJrRM3AyEfUovo8TPlA4lbgOZA/41J2irilvRH+RW8BLNLnMl42gJKxXRx6SNQBuHpywZDPSh6HmdxKYyCjMGPhsuJmF9NcZAnZAfoLlg164LCe9aKmIfTSJqQoPuzGeuBHssn+JSlklMvAjpSnu5wO3lqXw ivLDSsme 6/5u41/MVLfmwiuE79z9mH9k9YODy6dZKSv0fPD1/NNEpJw7SFnqAU0O/NpV5qQ3X4y8fR7jMLS8oRLmnunZiX9woqP6ukp0mFCryCWG0Ob2+RNYNjec1HYowoRipWg5xoEomkgt7gkEm4cBnpKYKGHxUOrpKH9Zsc4q2Ltt8/CMFAIA/mBD+sThx0K9Wfu/zvdZdbtP7DaZZmBAHwBmuzvmjtickW74T05hKn2wi77wgJyV1vOB65roVBJ08GxrFmjGSMsovNNVLVgyCpeytSTux7x4+tkpaAFzy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 02, 2023 at 05:53:46PM +0800, Kefeng Wang wrote: > Use __folio_test_movable(), no need to convert from folio to page. > > Signed-off-by: Kefeng Wang In my defence, I did many of these function conversions before __folio_test_movable() existed ;-) Reviewed-by: Matthew Wilcox (Oracle)