From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C9CBC0015E for ; Tue, 1 Aug 2023 16:13:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DEFC940021; Tue, 1 Aug 2023 12:13:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88E2B940010; Tue, 1 Aug 2023 12:13:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70865940021; Tue, 1 Aug 2023 12:13:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5C0D6940010 for ; Tue, 1 Aug 2023 12:13:34 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E34EBB28EE for ; Tue, 1 Aug 2023 16:13:24 +0000 (UTC) X-FDA: 81076030728.29.4618346 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id C40BC1C0793 for ; Tue, 1 Aug 2023 15:48:11 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HbhuYcgc; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690904894; a=rsa-sha256; cv=none; b=pzId1zqP2brPOfwKhd2kQWBJm9jfRb+sFPwKBeCY/9yCpvSlfLt14mrVGw20VoZnr8UOkE NcoAH6ojzNG5zd23oBICRNiJslmMUEStIcZR1BNZAXRg3WBiwxMQ5fYOVFAB1JRtAirwfQ MOAidH7t9Fw7H4tDhMgbIcxtboV81ms= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HbhuYcgc; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690904894; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fzL/Ybnx3HfszMfs/mHvvF2PskJxWsEeOJHTJUi83hM=; b=MFcRmVahWy1sHP0TBki/0dWRheRggnubkk79N7QPIUexdbLlpM0xhq2zgjOagSaXX5a15X nGsd5Bfwrb0t0kJvB3NrY62UgFf2StnH1s54ZLEz/fmOzTr2FDg/PgZVkIa/XkRgFS4zvF TTqZHMHo4QTGtd/lmJjzxE5xApIeREo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690904889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fzL/Ybnx3HfszMfs/mHvvF2PskJxWsEeOJHTJUi83hM=; b=HbhuYcgc3sE7riyuZxG7c91FsLndVUXBw5RyxWevwof1UhxC0jfphbtRw+OTkCTms2HpgT Z2zoaMukJ3HBnB3UKW+T/pRecHJPhj3n2IlZbUnAn3ujDHRWqCHAzH/4p649HKJd+zDc8A fj13qU4bAzh6P9ajVU4fGM6h0p+TOq4= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-262-A-mUSZOtPr-HSsy6fWjtcg-1; Tue, 01 Aug 2023 11:48:08 -0400 X-MC-Unique: A-mUSZOtPr-HSsy6fWjtcg-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-63d05a56b4dso14952526d6.0 for ; Tue, 01 Aug 2023 08:48:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690904887; x=1691509687; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fzL/Ybnx3HfszMfs/mHvvF2PskJxWsEeOJHTJUi83hM=; b=a2nSXRrhitMRkPG8zIw0EtJKEwGi+FUy16yIe9JUv97Ar642gUvlAjEDvpSugCj4zA ZVvVyyhOsGMEDl7q+i5ddyPJzGvlgOHy4e1rTGXOXRZLPtqqE6f2OC3UFp+Gs1RZAFty JgUPZ5F+IjwYkUCs23DQUJkEvdH0xmGJrMSPwRTTS9vblvX25kqznwlaBAMMPuXo8+2B cKB2BrQgZ2t6W28drVKu8WxcF+7Kc2ffIcejB4C4D6YIgfDhoVqypKsFceZTa230NFZM l2lPCKXu2PV++8pyc1KOtE37RPBcodx6+6mQthD305yf70xY0BLy1QmPpkXIWt+RLk67 29Fg== X-Gm-Message-State: ABy/qLaTgXwsOs7KOC2/0VGxF9q4imgXsnbGlw1C0Ovx5BIB5NpNZ2kL kywFEFqLIMu0YDTvk649awe5ZICDIrNMi2Z+6Rlnx5VG3bfe7ov9fCWx90EnC2zLuVVJy9XgZpt FN62m/Q9PCh0= X-Received: by 2002:a05:6214:f6d:b0:63d:2a0b:3f83 with SMTP id iy13-20020a0562140f6d00b0063d2a0b3f83mr13483339qvb.6.1690904887778; Tue, 01 Aug 2023 08:48:07 -0700 (PDT) X-Google-Smtp-Source: APBJJlEkIpicp2puvI5rez9Bp+zxcAl/7L3rx/USJUT9iEBbnLJ3LmasmjZqlKMQch/r6bJKu79nfw== X-Received: by 2002:a05:6214:f6d:b0:63d:2a0b:3f83 with SMTP id iy13-20020a0562140f6d00b0063d2a0b3f83mr13483311qvb.6.1690904887526; Tue, 01 Aug 2023 08:48:07 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id h16-20020a0cf410000000b0063d119034a3sm4695385qvl.94.2023.08.01.08.48.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 08:48:07 -0700 (PDT) Date: Tue, 1 Aug 2023 11:48:03 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Andrew Morton , Linus Torvalds , liubo , Matthew Wilcox , Hugh Dickins , Jason Gunthorpe , John Hubbard , Mel Gorman , Shuah Khan , Paolo Bonzini , stable@vger.kernel.org Subject: Re: [PATCH v2 1/8] mm/gup: reintroduce FOLL_NUMA as FOLL_HONOR_NUMA_FAULT Message-ID: References: <20230801124844.278698-1-david@redhat.com> <20230801124844.278698-2-david@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230801124844.278698-2-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C40BC1C0793 X-Stat-Signature: zgy7riqnexyo7mxnqfa1smmx3rbrojtx X-HE-Tag: 1690904891-70871 X-HE-Meta: U2FsdGVkX19Ql64FXVnfb5hsdDPyw/Wrbtf4Y59VhrNOG0HIjK9+lj6lXUmE6BEDoDP7na6oL2Kbf3a9co69lj2/pHZFFhNeDYgO6aCJMU/SH5FVHA/nwDPPDAUOyj0o71Vi48p/w2+pBGINEvITrNj0QEWYG7m0CgixDisWdO5NnZpm5dxNz0zE0qS5MfAeUxPKE0zz9/ERk+u4YkzlajdKGOur09NcpHTtH1WWqtA1wvN3MBX5Lf7wAMjfxwVDhHklH9CnBtejXxm2gY0QgGBdX7RgPGlAiTEjzgh9mr6c9rBlv9EOy9ZHMbIhoGNFi1Ru253+poWrxyfuXgGsuzjKbs+Bc5s0Emn5jKHUZ+ibF8fJKbFpY2cRmROM9wCE5x1ql5sJa+XNKB8EdkLFK/b4JpqoF53hJUqAw7Eb6njrpQxJ9nHYMMMrwh/iaBqCUDfu6WucsT96WQL+HsXv49luK+qJ2an34C/ftGX/MwaSoU6NbC7WUjBl7BxnH0X4Em96606fSJZIduZfVMZH8sUYl5tdEiVUyA4qd733E9M7YKc1oH99HSzJFJvDZGfK6bh+OJHOJ8+47o1wxaO6fzAe/rOVHQgehfvtsSS5ihjNPOxBfpzls7LUzD/BbBiOA6lfEhifVFu1X7pUsZXmlHpIVBLNLfeePkIokWOEIExvj4XbVn+thmknDg18r8MM4G9npwOtnD2mspAGx4s+NXnftqkpfGPiAEKhJPowry7oG740LQD0glTM9saH+5FQhCvrr7IYpxF3wkZxvVMr59ELTlKo/SGr6GJlha9do9yOYGCKfLk9wuwHfEyVFLdIiUBetEYcKJ6TOWvwmq/sJ2p/I3rkElIAD//PVqSROl9V/kgC14/wND/zF9oakND4jJlXUYK/t9vaU+4IK0pNiCcBMi7x3nAu2MxkTkV8/9ldjRbegpcnp/SzupjA02u1+x2ZY4fUMkRXjxoqAUa IMGr1cGU hbnrEDwjJvb+7kBMM5vNRtHHOXoWfRxiMu0XJxeyodZuGDS9qeDqsNGfq62x4c7DTtDAurUa8HF6k1xo9ymDVTXkAM6TKLcdTtbAikQ4lZnbr9c9PhKXoP+3hryNrOOICuB3vsVMmLdH+vZhnX3sMbs2VnupcUYymofebq9T4I0VWB/BDw+ki2SChIJui0UUlt6NIjDBg5CYShiUsDNZXU4u7oE6C5ipgjMgCRTVf4yVxLJAugS+dVKeSGd5skKKN1+WqL7/DzD+AJwnRk2oGmyCpKjPpRKAOPrVvcSf5X3oQhLpy4RULbgFj4DqyY0DMPRDRV7Lb2479ujGJzYc06cf9aryyVyKxmiuIDVuEGZMcRpI0MqTGbrfxtBzX6lGSBWE2Vj88WviwsD52tG8oqGIE6xHgHUr5FHnj1fa6/58RUCwF9EkZnmq+JA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 01, 2023 at 02:48:37PM +0200, David Hildenbrand wrote: > @@ -2240,6 +2244,12 @@ static bool is_valid_gup_args(struct page **pages, int *locked, > gup_flags |= FOLL_UNLOCKABLE; > } > > + /* > + * For now, always trigger NUMA hinting faults. Some GUP users like > + * KVM really require it to benefit from autonuma. > + */ > + gup_flags |= FOLL_HONOR_NUMA_FAULT; Since at it, do we want to not set it for FOLL_REMOTE, which still sounds like a good thing to have? Other than that, looks good here. Side note: when I was looking at the flags again just to check the interactions over numa balancing, I found FOLL_NOFAULT and I highly suspect that's not needed, instead it just wants to use follow_page[_mask]() with some proper gup flags passed over.. but that's off topic. Thanks, -- Peter Xu