From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57A51C001E0 for ; Tue, 1 Aug 2023 13:07:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7FE894001A; Tue, 1 Aug 2023 09:07:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D08F1940010; Tue, 1 Aug 2023 09:07:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDA7F94001A; Tue, 1 Aug 2023 09:07:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ABE4D940010 for ; Tue, 1 Aug 2023 09:07:12 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3281E160C54 for ; Tue, 1 Aug 2023 13:07:12 +0000 (UTC) X-FDA: 81075561504.19.A1B9C3D Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf29.hostedemail.com (Postfix) with ESMTP id A828212032F for ; Tue, 1 Aug 2023 13:05:43 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=ZCuzNn6A; spf=pass (imf29.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.214.182 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690895143; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kNAKszskixaa3hgdlCtn/3Bo9V9ma0+ARvrVT7ws8lk=; b=LFYc/lbISUGIVmhU+WT1rKZVasz0vPemid4aZVDq7F8iJcvhh11GgxjGNN4Qk5oFKanVVd Hy3isSaKCixSejlXG0W+PqD04uisAedj5xD/sBTatnTRbA7AevwLx2RJgy2M5dhVs8ojlA POz3q1kyqeK1ewYrsbNfjEJZWx8+Bsg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690895143; a=rsa-sha256; cv=none; b=OBm/OJb1Xn8wrNqcg4UcoK49DOZVPvjjv70fOqu/WV4ZRuYY0GvPmsxdLjdVFzYmFG/qTT ctnok75GzTpB6VncExaJqLANK6MjmKp/L7hlldZ5kHMQnjsbnvvFbbc4struw7LRFQS/+B C9OdypVeuiLtHPVz803y7Z9a3my1GPc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=ZCuzNn6A; spf=pass (imf29.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.214.182 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1b8b2886364so34360065ad.0 for ; Tue, 01 Aug 2023 06:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1690895142; x=1691499942; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kNAKszskixaa3hgdlCtn/3Bo9V9ma0+ARvrVT7ws8lk=; b=ZCuzNn6APf7Wf5WKyrW32GNHO/80jBoq1pCrGN0t5E5cwIUsRt+Tn/GES+T/KnDh4A tLt6wMhodhapCC063cH2e2hxFD7fuxIe89FyLyk+MflUnbkZo8wAf0AgiYflVFpkd6Aj CmmBUe/FhROpxJgkVL/zskys1dhqdnbpSPxtQc3cTvda5v/yzQ3tAZlzNg7/DPyQmQ/2 sTGb8bcyYVIKLSZ6XRVJ+gVxZYwqnq8oYBn5fJPqdJe0e0iEc+hAOhC4VH3eP9MOVmjt nT+pq2XgFtqGgZIfqTE6OWa4Z+V0satqrO3PoJ/gpvEvpAdOpMA0RxY6pQQhp7zoD/yF JWgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690895142; x=1691499942; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kNAKszskixaa3hgdlCtn/3Bo9V9ma0+ARvrVT7ws8lk=; b=UhmIRr3xGIKtv85l3kuF9D+p5h47mLd4t47loEFN2cKnO9Xqs9TN6678mi+8xUhfzI QPjKUviCLz+VMD1Bx3MJ/SFIuHkvzlKx/E6lpQk36xXRS0Ra/ZazIj30979rDYq52nIZ 9+UmhvLUWfdW6MIsaaaqnPzDL/hx2SBSKCrxbkEI4Ci796XVhtWkkzrLpLR8GcopGgtA Pcj6NHQTM7xzsu7vM7s7SIUpkqlc27ocTu8Y/nAfWYvUjnsvLENBKA91O9NA+WMnjpVU PMFcBUPHc1nzU9LGKgdcxByRn0ZHTI4NGU13x+QhUcCctAEVBbIsaHlq2tC+CH84NSn4 jZdQ== X-Gm-Message-State: ABy/qLYbcSLuJ42duDjKLRMhGpxHfnELkQmFUNpKW2CrYCBrPD+DNGzt RMxUvSIqMmaSF3RlM//f8ol0hA== X-Google-Smtp-Source: APBJJlFjj/UQBxDKWUdx/frDQYBFVDCh2370GVmNUaRC5O6568WBwiYbCtNgfs0MZwMCvU9A3D5z4A== X-Received: by 2002:a17:902:bd48:b0:1b5:4679:568f with SMTP id b8-20020a170902bd4800b001b54679568fmr10179994plx.45.1690895142060; Tue, 01 Aug 2023 06:05:42 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-25-194.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.25.194]) by smtp.gmail.com with ESMTPSA id p16-20020a170902e75000b001b9fef7f454sm10388131plf.73.2023.08.01.06.05.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 06:05:41 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qQp4F-002ma2-5I; Tue, 01 Aug 2023 10:05:39 -0300 Date: Tue, 1 Aug 2023 10:05:39 -0300 From: Jason Gunthorpe To: David Hildenbrand Cc: Linus Torvalds , Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , liubo , Matthew Wilcox , Hugh Dickins , John Hubbard , Mel Gorman Subject: Re: [PATCH v1 0/4] smaps / mm/gup: fix gup_can_follow_protnone fallout Message-ID: References: <20230727212845.135673-1-david@redhat.com> <412bb30f-0417-802c-3fc4-a4e9d5891c5d@redhat.com> <66e26ad5-982e-fe2a-e4cd-de0e552da0ca@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: ig7593kizd7qtr8d1wnoop5raonsyp8j X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A828212032F X-Rspam-User: X-HE-Tag: 1690895143-655196 X-HE-Meta: U2FsdGVkX192GAplUMjeX+qA4goB27zrI0MfffVN/ph0tIU7MN/BOjZmBHgvsjRouwe2Pzqkrh+aSyBALqRCWxUVaD4jKhNzLufIkXRpwwUnARN9/Y/mP1CwX4006m2FQ9bFjYgPkFmdiH2gvcNANIdm4ZzjqAT2FO9pc9wgxJ/L3GHvSo3Z5qkJSno236on6w1qmwB/Tavi51PKR/T3rgF3piWHSnDp9F7ksCdFWexOviSVWVG8q5yaPfw9e+tZJaoFtu8w/xBaXVCRGxIsYd9AW5TGzF5UPJSY+1J+9tjEOziO31aSt+rLDna/pmKbkADj8e3ck3zFTkv311bklZYqiL0oJL/mguODcXuir+i+DcIP4X5cWVUKqkj5bDVLIGkNnM2J3yXY6GBhZHuh2pqTZOCOchOxG5AUZPXhFaAopvfw6/oqNCeCvLMjgj1FR3KY0HNz32DDOF+DCa/RbtD2zdhsmHzVXFjjM20+aIMfTg/vTIu75MSjx0LkG5S0xUEeIlaaXkgdZVzed77P5Dy59SplprMbAN1KD24VO/j4YKzWgiyr/w44SNK5MU0+5HPwI+PCDK/U64FERx9MO3FIUnwSobMLFbgn2RsFqHKb11oS44ArtsKz05oIUy8QDUxbxeQZRjDaDFg3tB21vPwe90FTIV9XMMXJVRN337+2VNugu+OkPIrMHa2FyQsygONQn3x999iHKeL6NwfNSKm8BgTw7OG4f+bJJSWWrv6NJnZtOAMNYyom0ClUUIwULnIK3Fp7GjS17i4YwWke+fuaKqDIWyDUoYZFR3thD1IhDR9lO4mQP1rvmIReXoW6GrZHNfbHSE/QejNGR+n3Pg8rlqaePugv3ziKtbVctwqQme3wyZEOUNGQyZJkLqJ9VhM+SGES8XfrsjiXiUlygFU1CyqCSfKzD0K543i596umkkNNThSotEA1IfHWqk7bbBGBOfPW6rVvyfIXpQS 4n+K0/9h C9gwCfG/5m92qECvX4Wi2aSoi8W3ZTVyEfoBvx9LrKxdYr56YFG0nxnXdghKNKUmyl6cUpREv6fAZo892IWWDpOhrhzSimy304bGt0f4kE3HhBTPrULFFurSHfqF11GEoKhOqrkyZSvZLYOTQNLDRLGjy64zz1oW1eHpjyxVTt5AzwgXXrOaqIBXIxh65JxGWbixnWzpW9bxubzLtJWOEbcAQLxe0z/9uBqxPeLhNOAOy4KqcH7hxglv3nDqtkpcnAqvbshih+rEdIGQfB76VEGtLmow1b1Q0b+LfLLFyKQs/ixRH+8x4Us5Jpgr8RV3DjVD5QJaOUPdhgbkWapsLBkP8nmZrwuTRIcS4M/9MIiI0P1sr694re4ouUQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 31, 2023 at 09:00:06PM +0200, David Hildenbrand wrote: > Their logic is "if it's directly in the page table, create, hand it over. If > not, please go the slow path.". In many cases user space just touched these > pages so they are very likely in the page table. I think it has become pretty confusing, overall. In my mind 'pin_user_pages_fast()' should be functionally the same as 'pin_user_pages_unlocked()'. Places call fast if they have no idea about what is under memory, otherwise they call unlocked if you are pretty sure something is there that needs the mmap lock to resolve. If we need different behaviors a GUP flag makes the most sense. > Always honoring NUMA faults here does not sound like the improvement we > wanted to have :) ... we actually *don't* want to honor NUMA faults here. Yeah, I think that is right. We should not really use the CPU running PUP as any input to a NUMA algorithm.. If we want NUMA'ness then the PUP user should specify the affinity that makes sense. Jason