From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43E63C001DF for ; Tue, 1 Aug 2023 17:51:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6ADB940045; Tue, 1 Aug 2023 13:51:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1B1C940010; Tue, 1 Aug 2023 13:51:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE344940045; Tue, 1 Aug 2023 13:51:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AF8AC940010 for ; Tue, 1 Aug 2023 13:51:14 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 75F4D16063B for ; Tue, 1 Aug 2023 17:51:14 +0000 (UTC) X-FDA: 81076277268.02.88F619C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id E398140487 for ; Tue, 1 Aug 2023 17:05:08 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZpZfSliZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690909509; a=rsa-sha256; cv=none; b=Fsb1Y6Bnm8GAzgvRKtgnGb0LJv8n8u1vaJUqZhUiD9JSlW322I+i7GmdAPIrQ3zfrSZS29 rPr/u7aiY/zfEVOn/8hy5rkjbBdt34P7nEi7AyvGXxsu8sGR77vDH0DFmSmNQyL8u58B+9 ZdKgQaXJDyfc3aavypmYvqZwLk/g1Mc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZpZfSliZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690909509; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iHJDHQhMPESpDTCc7d6m6CZ7cgDoS6a5SZpOnu6DMTE=; b=TPEMaP0Xyi0MrLoSepHXOMUtrk7jwoZ6Ij6PFHfqJdyOAwnw5UDx+IgH+HlL8iBPm0NT1G fe2UJhL8WhGa1VYfiMese68JbueTNPepret5l5FM8/3Cuc0KCs+Ih6MnXXP+XoyS2mMipR hyQQn7DamnGTdTn/ll8cxwHPi4cjSBM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690909508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iHJDHQhMPESpDTCc7d6m6CZ7cgDoS6a5SZpOnu6DMTE=; b=ZpZfSliZeCAyVHnq07/nNC0aK60SdRbYESozhXODI57HIuorJIw1JwSiwxIT49YBdRD9Fo W01E/klqO4ngmanIJ0JU6bkijwWepgR+35PyAW7bpMK2xdtykZJA6Qa/2bNPKWFlKFhJ2L mPEYU2szrEspg3eHAnvduUydszwbXHU= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-KwaKjSHDP8iVa8mSXJzWCQ-1; Tue, 01 Aug 2023 13:05:04 -0400 X-MC-Unique: KwaKjSHDP8iVa8mSXJzWCQ-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-63d2b88325bso12293586d6.1 for ; Tue, 01 Aug 2023 10:05:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690909504; x=1691514304; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iHJDHQhMPESpDTCc7d6m6CZ7cgDoS6a5SZpOnu6DMTE=; b=TDeO/my+TxmlNpGdYEX5fzMNgckq/2guxp9x6srXQDwgvMEnr8MwCbrnnGVi4KpETV swt6WyhRDls8pkA6gx9M0mpDQwIa2piKoy6wnYgJLp43unxmSn9BwfzT3amjWj8Al0CX Vkb83V33BIflLgF2EopI3B9pimIZAgYdFSOs/k+EAHHdL7KZO2Ihinc/LbDT54NM++ez CwsV4/xWhG0yRZiUOFYjyPx/kCVtoVGYSQqivgOzJtaopesDNODj3ekWrqp/Vm1b6mzB d74Um5due6qOBoLNBpnVSOXZE6lV23Ot2VXY97dmFKld/ElC1E/4X/taj6mIRDcOaiuU Ff9w== X-Gm-Message-State: ABy/qLaTtckvfKm6sWROLn2t1QNoZnDDFpH0azqU0FBXaHA4tPbmJICo dXsGuoD91/CoIWFTfXBtFOhADAJAKWB8qNHT27tCBu1sYmI1gbMfOf8J/ci21A7t44P9JvF60oY i8v55M+gPBqs= X-Received: by 2002:ad4:5b83:0:b0:63c:f5fd:d30f with SMTP id 3-20020ad45b83000000b0063cf5fdd30fmr13776738qvp.1.1690909504492; Tue, 01 Aug 2023 10:05:04 -0700 (PDT) X-Google-Smtp-Source: APBJJlFaaBdvX372gnIc+hqJabCioknXLsWVusS1Xd1tIAYtUq1mP4VO3uaCM3OMaXWQ6+iPT5cVCQ== X-Received: by 2002:ad4:5b83:0:b0:63c:f5fd:d30f with SMTP id 3-20020ad45b83000000b0063cf5fdd30fmr13776714qvp.1.1690909504219; Tue, 01 Aug 2023 10:05:04 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id e30-20020a0caa5e000000b0063d10086876sm4807945qvb.115.2023.08.01.10.05.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 10:05:03 -0700 (PDT) Date: Tue, 1 Aug 2023 13:04:50 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Andrew Morton , Linus Torvalds , liubo , Matthew Wilcox , Hugh Dickins , Jason Gunthorpe , John Hubbard , Mel Gorman , Shuah Khan , Paolo Bonzini , stable@vger.kernel.org Subject: Re: [PATCH v2 1/8] mm/gup: reintroduce FOLL_NUMA as FOLL_HONOR_NUMA_FAULT Message-ID: References: <20230801124844.278698-1-david@redhat.com> <20230801124844.278698-2-david@redhat.com> <30d86a2d-4af2-d840-91be-2e68c73a07bd@redhat.com> MIME-Version: 1.0 In-Reply-To: <30d86a2d-4af2-d840-91be-2e68c73a07bd@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E398140487 X-Stat-Signature: 9dxxdb31fg6di347jq7e6uredd3g8smq X-HE-Tag: 1690909508-895933 X-HE-Meta: U2FsdGVkX1/8g4Tpskjz23w7Vygb/rx7588eg74YTp7zq+bQ1ChSw4v0eVe+kfYr0boGEAvwAGnBrmMbC33h3FaRF+4ElkjyxlDeXHyvgZHK5qO07x96CInK0nNhMImzPzbPpWnIwseho2RPrdPXHg695Lje67gptkHtjuZQfXxT8kF8a4mV/Ncp07q58C/Es9vWr5SnZAgNCD0dttYFekH+PrsGvKcVnzZ7i8p2FXlhuJQE1zSojPhbTB+YH0EhU3xdugBAVTtRFZD5v//wxHfdiMdknIoDTsioEilSak5iXvZjQDhwR1NzzZrdG0yQdy+kfGZtY8wenOVVzEZ5MODq+5cJBTuoFQlAAPAFSkKLnUzRjZZzZR7gQPghpc++j3zlXbMGh0oS5W/dyxrSDYo5MluQDtk4KldhRwZN5JDyLyHtTH6pyKF4W09lwHJUKqj3SABbdGvx1/Rsw2Edtei+jEu7JIVTMTXFyGrrYejY4DAtEXBhU7OHps6Zru4g7UPa1pNuSJNZXIQmerty9QfshE6cZRgwaECsf5uyhZ17WH+J/bCt8tzynq+saUTgQNd6M5rrucJHRRkQNBEk+E5Ho5/fOpXbZSj/dU4l1z8YNQEGdyMKG7FvxF7ihdunlT10ISFgrbBQIFvxnfB4Qv7aA8VrNRzzIgQyk8eGpst5OBhzYzWiwsg2sM4qPh8cy9y3SAX3PYoflIvMfoNRMpO73UPlVqcaAXus/NxG4+gZAMR7ph1kGfNaYJdBcNDay7cpRLdbT7yfzAB1tzriKMdIShIo9ufQFbNdDUMmARNKl39ARGf9xWVzY1bMLbg/WABKFIhCeu8uSS2Dab3Rsb1ASp5DjT1oBsrtL1gbKLYrKXIPmlhrlm26qRrHm3OZTt6NL8xo0IaIlyfpsW3fXoyji755I8xYqJyiHxpDzt0cboAiRsNjankHHiSllBvNGWUBCuYF4UYpUehdlZm WrsRfcw/ PeJFZosgy6dEy0xaDPgB1dqtABGww2sO/zwmoUiUWLEDLoy69grl+pDUM4y54du50QIOZfAHu4VaB+CFU3jqJbP0BVMDBG0BvhE/nCSbIQxe+bZCfI10VZZtjypS6ETfkTQnndVQxXfwXRe3CtFpK0cw1MyVxk8Z8vP9pRI5aVI82swzt13F6ESCXnKOK9Ky/6WIp2iQVLK2LArUn5a1X13fuqx+VXYySxwBE7MFEoWaABbjm2CEsmkb2GZal868LT8ZNETXbb0EOnBCHbaH91+bUpHxNROh1PbhJoZRKUWCF7qNbK/W694a94Z2kNIzEsEhjDaXK+hmkaoYhvJF7LnYwQwwZjcOtqwj2SUzP89lvcDwTH9dTkxB/uLsibtxiHxPNkWfJRi2O1nih4M2gmXwJhJLBPAdR53rc1BezlKoKLT/yCrIPhidr2w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 01, 2023 at 06:15:48PM +0200, David Hildenbrand wrote: > On 01.08.23 17:48, Peter Xu wrote: > > On Tue, Aug 01, 2023 at 02:48:37PM +0200, David Hildenbrand wrote: > > > @@ -2240,6 +2244,12 @@ static bool is_valid_gup_args(struct page **pages, int *locked, > > > gup_flags |= FOLL_UNLOCKABLE; > > > } > > > + /* > > > + * For now, always trigger NUMA hinting faults. Some GUP users like > > > + * KVM really require it to benefit from autonuma. > > > + */ > > > + gup_flags |= FOLL_HONOR_NUMA_FAULT; > > > > Since at it, do we want to not set it for FOLL_REMOTE, which still sounds > > like a good thing to have? > > I thought about that, but decided against making that patch here more > complicated to eventually rip it again all out in #4. I thought that was the whole point of having patch 4 separate, because we should assume patch 4 may not exist in (at least) some trees, so I ignored patch 4 when commenting here, and we should not assume it's destined to be removed here. > > I fully agree that FOLL_REMOTE does not make too much sense, but let's > rather keep it simple for this patch. It's fine - I suppose this patch fixes whatever we're aware of that's broken with FOLL_NUMA's removal, so it can even be anything on top when needed. I assume I'm happy to ack this with/without that change, then: Acked-by: Peter Xu PS: I still hope that the other oneliner can be squashed here directly; it literally changes exact the same line above so reading this patch alone can be affected. You said there you didn't want the commit message to be too long here, but this is definitely not long at all! I bet you have similar understanding to me on defining "long commit message". :) I'd never worry that. Your call. Thanks, -- Peter Xu