From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDC83C41513 for ; Tue, 1 Aug 2023 09:04:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4228C8E000F; Tue, 1 Aug 2023 05:04:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D2868E0002; Tue, 1 Aug 2023 05:04:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 299198E000F; Tue, 1 Aug 2023 05:04:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1B7168E0002 for ; Tue, 1 Aug 2023 05:04:19 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D8B8AA0BB6 for ; Tue, 1 Aug 2023 09:04:18 +0000 (UTC) X-FDA: 81074949396.13.818082D Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf17.hostedemail.com (Postfix) with ESMTP id D83D040026 for ; Tue, 1 Aug 2023 09:04:13 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=OgOx5qtL; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf17.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690880654; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I6/n4Ux6YWy9GCwXQYfypkxLzivnlsuKwD27zLIsxlE=; b=6rXmrTgDKczxD+P0PIcDKlY51ZqeVSXEu1P6EU1y2htQ2Cai5QEKtRlxK0S5Fp0ZuYp6ov g+QHlSsDIGmDXJRob2iVv7ljitFhEO+Y44knnB2zQLNo+zaHm8aRfRrqsWRESH0e1EJqm7 wJHAXwIi7so1Q31FEQZstMVFIWsaOhc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=OgOx5qtL; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf17.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690880654; a=rsa-sha256; cv=none; b=xbd22WUZDI+bHw96tvF+khCJCqI56VBocGq8fDpNumhwJHksef4t5G7nwzpMmsAsv+Bq/r Rae3bZ/QnwjDYWmSj9/BeG2ZwGdD6XaJKVaMcTQK8PqEtw33B64Wx/ioWIugNEPQV9q/O4 KQcoGVGSVy9QJ5xvtzZPS4eSV8fj4gE= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 719F91F897; Tue, 1 Aug 2023 09:04:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1690880652; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I6/n4Ux6YWy9GCwXQYfypkxLzivnlsuKwD27zLIsxlE=; b=OgOx5qtL4A20RxLma0h5n5Q+aOu1i4ebHW/c1Zbo9aqcMuDuJXF0DkHZweOF31RbfkAYNp w+1V4LyDAi32lYkNi1XJcGzt/Vye/kyKrd2YpSoxR59ExAYUqrQrM5VM0fyNADdhMTkaQB UZeas5snoQ3dBKPSYoKXd8JdIJg4m3o= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 62D9113919; Tue, 1 Aug 2023 09:04:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Kf2yF4zKyGQ0NwAAMHmgww (envelope-from ); Tue, 01 Aug 2023 09:04:12 +0000 Date: Tue, 1 Aug 2023 11:04:11 +0200 From: Michal Hocko To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu, Oscar Salvador , David Hildenbrand , Vishal Verma Subject: Re: [PATCH v7 4/7] mm/memory_hotplug: Support memmap_on_memory when memmap is not aligned to pageblocks Message-ID: References: <20230801044116.10674-1-aneesh.kumar@linux.ibm.com> <20230801044116.10674-5-aneesh.kumar@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230801044116.10674-5-aneesh.kumar@linux.ibm.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D83D040026 X-Stat-Signature: ng34uqfd4npoy6zy6fjko6aj5mratngi X-Rspam-User: X-HE-Tag: 1690880653-680517 X-HE-Meta: U2FsdGVkX1+4EFHEbZcfiCmjAg+wuL1L4yVc3zi+aACdysCOHqiPuxLoqEzahDbiEamxqnlD/otyX4e0orA1mY7emNwoJfhRSUk01P4OcczULsG872U4M+DuEHiHBjC2VoTZb2G18rfP1BErY/lbmqPE4q5vqtb94f7ynOnzUX2ll9vM6VwiDLyfG0AN3RYm3WVzayq/dTK9eK8H5PXbh5ASdybXqtnLSjYQYkNeCzxvAc/tto3vSVtWiowzcrOfKvik9FtwAismOjn+tQ2ZTAuTmLJpekF6E2kTR3HoXmUEmGiN5XyX7T94yI5PZet/cR0VD9NxWvBmbJ3/NGF4F3Odb5trOpfX9+u7spvS8baQ9sZcm//WOXxXRM/QAQRnbkR8UHC7lOuc9uRofDoXgiuh8Zax47580KyqEpRSQlqtHoZKqucwOmhtkxV7g4k/wAXFKX7vLZ8dMNYopoW8JyxVw50EyDr3g04twbCjUdnAf/mgp2eSpuq71+J6veLErgIOGFbJU3+d+OUniZ/DZHVpzTWL0hK6z3b71trIutLGXFB3bY/YwKkU7Vj3ynTycv1tSvGcIQhLgCbQdTT7X/hlceg0mJm/aavsWqd2DfsDpFLn1b6lVj0PF4sQb666lZ+M8/+85eChKw7M8PEhUiFlX4Bun7vvg5fd7mt9VmSUNeiS1kKzqlwTz0UMp/9TW81WcYqbSci8fSr6HHuNZyjj4I54Vb1d1CXMpcyP3wgDLXHXBifz5T5C8h8SnZYpzKwdHP0B04JQn6t18nx5ZFmAMvq+/aOZh+Yd6plMurR/ynJ5lMite5y914g8pyS9fUQuf8nSfulFZZHhh65aqb7hsvLPfl6rsVHWQ9JaApQCV1VLF486aG8puoquSfK6Oqo5iDExUKV/cVegMm5rHy7MVSFZoTeatO20rRZIrOu+v1TcIaNuwQzY5tsNuNkJl128SNTtGHnWkX8g/qA Er1oycaL UueunulQKOnS+zLDkFec6CxrEC61XxC2vHRD1oQTDt6hORxtvSDCMYytcaDacLvh9nFlBLfvrvduUx7dD77TrX5bzyNrXi2p50r2xudJKxLbmqLY1T3GuBC5g//AYPE5ZEOREAYC0aek+weTBeXUNrIbefyWmZkeZzrGIGRQ4iieDWnW7cH0i9bo3nVrHq5VYvOoo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 01-08-23 10:11:13, Aneesh Kumar K.V wrote: [...] > + if (mode == MEMMAP_ON_MEMORY_FORCE) { > + unsigned long memmap_pages = memory_block_memmap_on_memory_pages(); unsigned long wastage = memmap_pages - PFN_UP(memory_block_memmap_size()); if (wastage) pr_info_once("memmap_on_memory=force will waste %ld pages in each memory block %ld\n", wastage, memory_block_size_bytes() >> PAGE_SHIFT); would be more useful IMHO. > + > + pr_info_once("Memory hotplug will waste %ld pages in each memory block\n", > + memmap_pages - PFN_UP(memory_block_memmap_size())); -- Michal Hocko SUSE Labs