linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
	mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
	npiggin@gmail.com, christophe.leroy@csgroup.eu,
	Oscar Salvador <osalvador@suse.de>,
	David Hildenbrand <david@redhat.com>,
	Vishal Verma <vishal.l.verma@intel.com>
Subject: Re: [PATCH v7 4/7] mm/memory_hotplug: Support memmap_on_memory when memmap is not aligned to pageblocks
Date: Tue, 1 Aug 2023 11:04:11 +0200	[thread overview]
Message-ID: <ZMjKiwC5G0mu/UjW@dhcp22.suse.cz> (raw)
In-Reply-To: <20230801044116.10674-5-aneesh.kumar@linux.ibm.com>

On Tue 01-08-23 10:11:13, Aneesh Kumar K.V wrote:
[...]
> +	if (mode == MEMMAP_ON_MEMORY_FORCE) {
> +		unsigned long memmap_pages = memory_block_memmap_on_memory_pages();
		unsigned long wastage = memmap_pages - PFN_UP(memory_block_memmap_size());

		if (wastage)
			pr_info_once("memmap_on_memory=force will waste %ld pages in each memory block %ld\n",
				wastage, memory_block_size_bytes() >> PAGE_SHIFT);

would be more useful IMHO.

> +
> +		pr_info_once("Memory hotplug will waste %ld pages in each memory block\n",
> +			     memmap_pages - PFN_UP(memory_block_memmap_size()));
-- 
Michal Hocko
SUSE Labs


  parent reply	other threads:[~2023-08-01  9:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-01  4:41 [PATCH v7 0/7] Add support for memmap on memory feature on ppc64 Aneesh Kumar K.V
2023-08-01  4:41 ` [PATCH v7 1/7] mm/memory_hotplug: Simplify ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE kconfig Aneesh Kumar K.V
2023-08-01  4:41 ` [PATCH v7 5/7] powerpc/book3s64/memhotplug: Enable memmap on memory for radix Aneesh Kumar K.V
     [not found] ` <20230801044116.10674-8-aneesh.kumar@linux.ibm.com>
2023-08-01  8:58   ` [PATCH v7 7/7] mm/memory_hotplug: Enable runtime update of memmap_on_memory parameter Michal Hocko
     [not found]     ` <a32fe748-fa18-bd92-3a10-5da8dbad96e6@linux.ibm.com>
2023-08-01 10:50       ` Michal Hocko
2023-08-02  4:45         ` Aneesh Kumar K V
2023-08-02 15:50           ` Michal Hocko
2023-08-02 15:54             ` David Hildenbrand
2023-08-02 15:57               ` Aneesh Kumar K V
2023-08-02 16:02                 ` Verma, Vishal L
2023-08-02 16:59               ` Michal Hocko
2023-08-03  8:52                 ` Michal Hocko
2023-08-03  9:24                   ` David Hildenbrand
2023-08-03 11:30                     ` Michal Hocko
     [not found]                       ` <d71a85b1-c0ea-6451-d65c-d7c5040caf77@linux.ibm.com>
2023-08-07 12:27                         ` Michal Hocko
2023-08-07 12:41                           ` David Hildenbrand
2023-08-07 18:35                             ` David Hildenbrand
2023-08-08  6:09                               ` Aneesh Kumar K V
2023-08-08  6:29                               ` Aneesh Kumar K V
2023-08-08  7:46                                 ` David Hildenbrand
2023-08-07 12:54                       ` David Hildenbrand
     [not found] ` <20230801044116.10674-5-aneesh.kumar@linux.ibm.com>
2023-08-01  9:04   ` Michal Hocko [this message]
2023-08-01  9:07 ` [PATCH v7 0/7] Add support for memmap on memory feature on ppc64 Michal Hocko
     [not found] ` <20230801044116.10674-7-aneesh.kumar@linux.ibm.com>
2023-08-01 23:10   ` [PATCH v7 6/7] mm/memory_hotplug: Embed vmem_altmap details in memory block Verma, Vishal L
2023-08-02  4:47     ` Aneesh Kumar K V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZMjKiwC5G0mu/UjW@dhcp22.suse.cz \
    --to=mhocko@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=david@redhat.com \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=osalvador@suse.de \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox