From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 482C4C001DC for ; Mon, 31 Jul 2023 11:11:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5CBC280024; Mon, 31 Jul 2023 07:11:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A0E3C280023; Mon, 31 Jul 2023 07:11:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9241A280024; Mon, 31 Jul 2023 07:11:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 83880280023 for ; Mon, 31 Jul 2023 07:11:53 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 526B9A0AF9 for ; Mon, 31 Jul 2023 11:11:53 +0000 (UTC) X-FDA: 81071642106.07.3C8E50E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id AB5962001E for ; Mon, 31 Jul 2023 11:11:51 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf13.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690801911; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4g88eDttDkFx11ziT/Y32QCPX3lbWQD6OGEGJ5J3OsA=; b=X0OdOHjqi5q/NwsY7WPVzOPUDDH5+3S44IJnhVmgOgz7YC5TxddZM2eGCcOcbmbAdOAILt nlZqPwdK2oxK2Apq/6689CYy9prGVi15XRAP2gn9LoPrjeCaM6UhMZ+DIZnh3bd0cvvk6f bAdvSb0tPXh+TktGe6M/DVvp/wR4r8w= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf13.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690801911; a=rsa-sha256; cv=none; b=q0qnKnxAWnn8djRgIN0cEna8m9Pt3vaZrkr/uJlPEJs3jvOoYSqYP8DascmPDMkZ2inpNQ 37VwvU4uQsGO062Dln5TvEkUR14dCOXveHb1iwA3kcNNq3M+GhRcBkIJlY52G23pcf/f/X KGHhWmOYAGyDvEHKBCbhgoJ9qRrrZQo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9507E6102E; Mon, 31 Jul 2023 11:11:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A632AC433C7; Mon, 31 Jul 2023 11:11:42 +0000 (UTC) Date: Mon, 31 Jul 2023 12:11:34 +0100 From: Catalin Marinas To: Kefeng Wang Cc: Andrew Morton , Will Deacon , Mike Kravetz , Muchun Song , Mina Almasry , kirill@shutemov.name, joel@joelfernandes.org, william.kucharski@oracle.com, kaleshsingh@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] arm64: tlb: set huge page size to stride for hugepage Message-ID: References: <20230731074829.79309-1-wangkefeng.wang@huawei.com> <20230731074829.79309-5-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230731074829.79309-5-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: AB5962001E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: yj1xfyaz9zaig8r1bj4t8t4dwcu86ygx X-HE-Tag: 1690801911-361552 X-HE-Meta: U2FsdGVkX1+tDKERDI6F83gQh6yslfncgStvQR/ynDb2kYpULKRSMDLXBIKM4faM/uIzAnKsyYHLBTFDDVWliyenIU3yYP5EhEi1kXxXpz3J/nU+PFu/A3LHmGcF0l+GwHE/RiHSSizm0wEbfw/4aouleUK2Gx3t/auvagEU5ye/Yt4uYFJ0IG2uwRqN8RTzTPpGn0wPcL5y2Aq0a4J8wIZsMvPHxopjWIEOU6RVTVRAYdNEip4bkZwsQ2FngKzSZYqiV2qKpIN145n9qG3nwNF3EqEeSo4v/QknNXuA5vGkyAneTxRUe4svjZYBBdQF/IFCnNFNCCMYwqGRIOTaWA2DwbOXU3rjZD05M5rw1GZFWJ6z6LpteCakK88DVlzFkIXZz36fkOSdlxEDQAMfvd10NTVsLs3XElGVs/tO5FF1K+orSzqiHRKVwFSGeVYBZxI5OaCkuRZPiP3S4jYnowJq2I7DC2ZXyZJDIiqzxM34O7Cdkv8uD1XP1XgbaJS76iMLNg187QBQhJbNE29NgUjpNf+INjf/yBzU17TZMln1kaNDStwEK8i0nmBYJRmXKA/DqjF5G8Efx1TfiNoNjeT3vJAWyZ8iZWyn/EZ5gvVIJcI4hvK0qqZGgxhjRmfL9gajJA7MNytEGcexVjX2L2BASHtokop0NLO7nVG6FqSx6ry/nOy28t+JhjMqKJwReWN6+C1Ak14QrT7N7BiWk8O1R2sz4xcVADM0IK1Z7D8sYfeGHBQhJdT35n85muVbSUWf48zZ/Ps+lbTWkTmGgipqGaaoLfcG/mJpO4dfyHZldOuMmAsdUnbyhO/Vj6SljsvRl/h825OM0LTiDCM7Pkv4Wh4K2FZE8kAKZ7TkiF5OXcsiAcut7OfrqBI2LbTZtOh90/uGFH3BDHfQc5ku93+ur2n5mll/JHG4mIXQHywr9JEl6h+O55Brchm701RGxSSAFKd3YmBBR85zI9H Sz9XZ4Gf hmI2ZGLVjLgHJhKwPl+Pk/biFlsSElRdIGoUZJb8ryXR441XubnZcNPShpXGSltHbkmeMsCn4evDXqbi1xhD95AO6J1Ecm1kf78/e6v94Dfo3aSpIejygbpV8XqYNYKCs/vDjW9lgfkgrUVf1KZZojbGt7l/qpb1kG4/T6SCpTOHmAA1C+b4CpvYMcmdoK+qv+OlUTTtmTqgDbiWnt0shq3nTTCHyIILATSwL3qMy0BSHxChhyNFIeFPBGZBvd0aOO6tLHBts26MXRnbUY9A+V1CFYgVrTZYZoqb4RRtEoblsZoAt3z+4WDr2eZl8IEraR6xfPaVA8AELBOLYZ2ll0/vEW/YJ3Bqjq9OGayrC5qwpNzXGwHpIdwVYAe0rOXhYJhLHpCzgkQAuO6YyqBRuAKGbbN82ysPlbhQoHUVtkMcQyUniiPZruuvE/fl8trsEymrg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 31, 2023 at 03:48:29PM +0800, Kefeng Wang wrote: > +/* > + * We cannot use leaf-only invalidation here, since we may be invalidating > + * table entries as part of collapsing hugepages or moving page tables. > + * Set the tlb_level to 0 because we can not get enough information here. > + */ > +#define flush_tlb_range(vma, start, end) \ > + __flush_tlb_range(vma, start, end, \ > + ((vma)->vm_flags & VM_HUGETLB) \ > + ? huge_page_size(hstate_vma(vma)) \ > + : PAGE_SIZE, false, 0) This won't work if we use the contiguous PTE to get 64K hugetlb pages on a 4K base page configuration. The 16 base pages in the range would have to be invalidated individually (the contig PTE bit is just a hint, the hardware may or may not take it into account). -- Catalin