From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BECCC001DE for ; Mon, 31 Jul 2023 10:35:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3A196B00C7; Mon, 31 Jul 2023 06:35:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE9D828001A; Mon, 31 Jul 2023 06:35:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD86D6B00C9; Mon, 31 Jul 2023 06:35:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BE1BD6B00C7 for ; Mon, 31 Jul 2023 06:35:05 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 79474B2097 for ; Mon, 31 Jul 2023 10:35:05 +0000 (UTC) X-FDA: 81071549370.01.6AE7E6C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id CD054140003 for ; Mon, 31 Jul 2023 10:35:03 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf09.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690799704; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=am5K1ZtzusEKKh71RP50c2PXCVAvFjBL24cmaydyANg=; b=aIXrgR67ROXZqNBDP9jg2WKlhkyxkQN4xt5o5K5Kj9YFCjcXchK1hIomzrs7QVFVl4h6XJ MSttRRO9vWp1DJqCxbundSN+M+flt6LPjWj9JnpVSwUH3dpfq7pjPHkmuIc/pzBOC+jszd x9sBLT9Nl0Ff45UrGzTgcgS8DV9bDQk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf09.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690799704; a=rsa-sha256; cv=none; b=G58BvXLdbWBhw4wIgl8z6EneAKZSaCOci5YVyhadKV5zSD9wBpbhuUfe9SrLy/6oYachhu zE5S5+6jY/VWot6/Awkl8APGbyCc3oHe4CxA8SbDhK48RuyRm9mwGrhgItGNp81a81uH4M 4GjrvU+D70hW5dWML+PVXrwBCrPp9Fo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C634F60FC5; Mon, 31 Jul 2023 10:35:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80221C433C7; Mon, 31 Jul 2023 10:34:59 +0000 (UTC) Date: Mon, 31 Jul 2023 11:34:50 +0100 From: Catalin Marinas To: Yicong Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, 21cnbao@gmail.com, yangyicong@hisilicon.com Subject: Re: [PATCH -mm] arm64: tlbflush: Add some comments for TLB batched flushing Message-ID: References: <20230729131448.15531-1-yangyicong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230729131448.15531-1-yangyicong@huawei.com> X-Rspam-User: X-Stat-Signature: rb43nwrzzp7jxgfgntg379d5cmey1c6z X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CD054140003 X-HE-Tag: 1690799703-769403 X-HE-Meta: U2FsdGVkX19pjUc4LzVLJfEppKLKFc36Q7r10pfhvMl/SfzAW0sw41ru5//pspobmJ6gTzv4740Fl1EWQJjapL6DVyIfLzGkiQ/71gOt4DgmHuG7qcnmXTit19H2NNwaCx4RQU3kBIO2wEbpznRGD1pzqOCXhxCjUKE3Cows++fyJA+4GmieEr4o1Bxry1WTTKC3WemALU6fVrqm9wmIQKKDWT1ME2S7RPskZ7ZqCK3EH9ZHwZa5vL1oZMkmjwcJyrKKaCzvhKNY/0JdZKrndSErqAmRvlNa8Ohub5a0+g8V1yukkpqzk7x6EPoi3aG+PS17685lNoNYCF8qKgFqnu5NjBVa6k6WdEIiC2sb4M6Wq5NSZ14oa6FjR1yNLTXxqmZnZugTJc+btxpyzlRHwnm19D+YownHGIPpkDGPSVbYiImykDD63LrKoCV6i9vrYbff5LzrabT35YyZK/IpqyDkJ7QIGnR7uCzNsdO6U/1ypNSgthcCxcasol+FCemzSL6nHoruIab/xArQ6/6PWZuTQN/gWL8V6MEoMifR+C30vGxxwY/y4K3nDk6NPNzoeyenc+gJaC+mN5G7imDJcucIVksfy4Yj7dqpxTS70/8o3E021tg8MDoFfD6z6yQWCpoTg7tBCFZxpI0rVGT+OllScwc/hU1yE1Wl/EN4tENYC5Par4tHM3QUPNafwYzNFphJ8abx2h30bqCoF6lmlDsswVL4+YpWEfKGQ7isFsYLoVSCrnz9/yyf74dybjZNN3ijZHccDB8BDNN/gowa5kpPkZj/d1oWP7pdLTHamYP5sYQYjB3qdfLrdNutUgw+ozVsBqQLYla01+tlezieFNAhPyqT0Q1rTfQNYpP4h61I2/edOWfccZVmeC3UhFuom7bU5C2m17WqGtwv+oXw67DG6+rFij25dt7ovO8KvCbEcn0cxnobX8s+Jhtue/WRFJMzhXV3fk1ZOLy1XS7 Fm98D/Cm 87cZndxvDudp+Gzm6vkwyZ0XXg+yjK0WhljFWw7T4yLAHkD/iHL91xxibI4Xq+c1xxOlTT5+ELaY07rA1t/0zHp25llN1U0V1bRRKfwj0JirkF0uIEqqCNzyoYl/p88Vx8h+5QS/iVCnqCSHLzMX5V8MHSd+xTPpdf05/WtfEOppp5OQHUUMIXilAZ7FmSHqkwl4dl2dhsIq/38P4jNpXB8sWZJLfxx4Wd4x0Su5F8ieW1dH/YQy/cl+4LhlOvZci/wJ+aAObCWNkpIfNz7E+OLyeiJPcKVcEqbEt8p7FTlMmvRfyu33NIYin6Nvu5faIdOpIlF5Eh1EiAQxhQBCVmhG8ojyRE42aR6ejJUlNfxgtH3Gj+k1Ny9rjZZDsy2V4b6FjoPAz4tz1GTDN1D+7Os4HbDE5J9mo/wZoJKFLp/2ZAWLULkM7vyy0ldGHmMpRGRn3le71w6apavdqkrMOas0sFR2jFU60/Diqf+WwZoMlTH8pxBhD7BNBmA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 29, 2023 at 09:14:48PM +0800, Yicong Yang wrote: > diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h > index 3456866c6a1d..2bad230b95b4 100644 > --- a/arch/arm64/include/asm/tlbflush.h > +++ b/arch/arm64/include/asm/tlbflush.h > @@ -300,11 +300,26 @@ static inline void arch_tlbbatch_add_pending(struct arch_tlbflush_unmap_batch *b > __flush_tlb_page_nosync(mm, uaddr); > } > > +/* > + * If mprotect/munmap/etc occurs during TLB batched flushing, we need to > + * synchronise all the TLBI issued by a DSB to avoid the race mentioned in Nitpick: s/by a DSB/with a DSB/ as it somehow reads that the DSB issued the TLBI. Since the rest of the series went in via the mm tree, I assume Andrew will pick this up as well. Reviewed-by: Catalin Marinas Thanks.