From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C996EB64DD for ; Fri, 28 Jul 2023 21:21:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2035E6B0071; Fri, 28 Jul 2023 17:21:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B4886B0074; Fri, 28 Jul 2023 17:21:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07C8F8D0001; Fri, 28 Jul 2023 17:21:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EC4D56B0071 for ; Fri, 28 Jul 2023 17:21:12 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BC2CB1C9652 for ; Fri, 28 Jul 2023 21:21:12 +0000 (UTC) X-FDA: 81062291184.01.FCA0E3C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 7C6944001F for ; Fri, 28 Jul 2023 21:21:10 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hj33nEHW; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690579270; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ac7QCjU27us9pWCzIU7wIhVCfe0T3FQhf/CkOGsKAAQ=; b=BA5sIGap6c+JzvTfX5UxfahdbuRp6fy7SB7Q7zGlf86fjFE1rbm26+Rl5IaD7R3rXujLnt NWXLamdNbAAFHrMQVzSMv2sB5yDLDZCvOhhiYT0zM7s6+ZEnSIbEp8oqLaObl80AN9eIJn BnVneeGIsubIZlQlOW62rFIpKOLEIBU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690579270; a=rsa-sha256; cv=none; b=v+soum77tLdZEq8BLEivpuaRnEDZZkNiIYPU/b1NMVE6cP4Ag/u7KEqlucR28NBPmKczO9 FPUdTjE7bfyhGO7ASQOxayQaqjIFmn96nBTVnn32lzEBJNasHRgAJcIb0StYmxMmV7AH8+ 6c3Vxt51ljJzWeyq4RNt0AzxJsbLLRg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hj33nEHW; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690579269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ac7QCjU27us9pWCzIU7wIhVCfe0T3FQhf/CkOGsKAAQ=; b=Hj33nEHWkX0odSgTRb9mLFYu84QHMB5Os+4LkVs4tdu1/HWh+onQL+cdTDynMigDoZxP2h pDg15AtPxjfaQEyVvcQ2oAIGcfQ/hKJxvhe7GyWjnSciyfIqMFMbZNM9B2qG1UOWqaAxZD btxoLvyrqj9VIv8z7KQ7rxcAFHw9L30= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-261-y_nFR4dpPGSiIsb1baWaLg-1; Fri, 28 Jul 2023 17:21:08 -0400 X-MC-Unique: y_nFR4dpPGSiIsb1baWaLg-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-637948b24bdso5467156d6.1 for ; Fri, 28 Jul 2023 14:21:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690579268; x=1691184068; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ac7QCjU27us9pWCzIU7wIhVCfe0T3FQhf/CkOGsKAAQ=; b=EsDui4GnkcI2tkSsoZRdvCbzEKOo71jOO4aL0VI7ov3d/8x2vwV2AmU9wHS4RACFIG FeulI5X+UVWof/4Y35eGpghci9zOkhAzQb/Pyhz5qUXSZX+4866FKP5xdLOmq4oG2Xvt ozR+wXJbTT9mxrdOiFWH6XuRZB89ld/vZiArXVI7CF6LuZXlw+1cWPWiNtw9n5JwDD97 3ITjOuu5Qn2AMzkcGMsQeBdTGC17NDtE8zwN1YVuJBVcpo32Zgk2MdOSHop3jh6xyOnX cM9p5mtwe2do1IscOvqfH3628uSOf1Q7RvJK/EreAjZ/I2kLkcEzxk8zzNwfh+GEQtUW k6kw== X-Gm-Message-State: ABy/qLZG9tITuqqZWlS431f9Wqv0azGDffVrSbddYUUBIkSdlqS3xov9 hvSZwT2r8y3S6MOlL0TMpJWA+lSiL5fiUeynpCWu2NVCqeloOMJt7eXSFLqxnFom/n1Q7AepI/n 9MDGK2n6qn9c= X-Received: by 2002:a05:6214:5190:b0:635:fa38:5216 with SMTP id kl16-20020a056214519000b00635fa385216mr571665qvb.0.1690579268033; Fri, 28 Jul 2023 14:21:08 -0700 (PDT) X-Google-Smtp-Source: APBJJlG+YMOCBtzBXkVZi5qKTKhmwdfdvIXgbKwZ5wE8cXxoJVGwXu7gH3KYSZRnh2FZGnuM3gaciQ== X-Received: by 2002:a05:6214:5190:b0:635:fa38:5216 with SMTP id kl16-20020a056214519000b00635fa385216mr571651qvb.0.1690579267641; Fri, 28 Jul 2023 14:21:07 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id h13-20020a0cab0d000000b00635eeb8a4fcsm1538086qvb.114.2023.07.28.14.21.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 14:21:07 -0700 (PDT) Date: Fri, 28 Jul 2023 17:20:55 -0400 From: Peter Xu To: David Hildenbrand Cc: Linus Torvalds , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , liubo , Matthew Wilcox , Hugh Dickins , Jason Gunthorpe , John Hubbard Subject: Re: [PATCH v1 0/4] smaps / mm/gup: fix gup_can_follow_protnone fallout Message-ID: References: <20230727212845.135673-1-david@redhat.com> <69a5f457-63b6-2d4f-e5c0-4b3de1e6c9f1@redhat.com> MIME-Version: 1.0 In-Reply-To: <69a5f457-63b6-2d4f-e5c0-4b3de1e6c9f1@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: mcj1tork4myzad5gqo9brahifzn58a55 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7C6944001F X-Rspam-User: X-HE-Tag: 1690579270-648984 X-HE-Meta: U2FsdGVkX19cT5iVNdtsBT94cNZaf8QS3cTNXp911c+vay2IrEEvy/OUEvIBR3rxAVhV2M3OVEs9y5RwoAwfYC3iNjxN2VTt7RgJAXzRFDjz65qTNNyWT60I1I6ysI53nbL/pBbmfVEO5x+OwftCUQgz8nmsxZOQG0i+rA+GHpCv/FM7FX3yKqFnsu1H0mUr6lF6Iyvod2y6R7Yy5333+7Smpkft73qxikeivMN2RA+ADgSW6muFk33fhq0SuDagogMmmURpouHCzIcC0Hnd2p/98a6JER6owx9mPD18OcJ4o8vNEsTUPcGyCFNYEQW0Qvo6wx1M6LisIWIwE8WV376f8lMewGyfigeWM/OgisnNT1ilTC2VR0FjHPvfFDNaUwMN9HjfcTapkAuVI/jJv+ITcqU7SabonAxXrQZPc6YvQCs5Z4/IprIenrzpxYNIFf1M2w1D7fPHt73kZnUwdT4PYVRO5lHpfXopirlTmjQVLixpTPD7wi3qHVCHgVNs0FrMJ3SEYn9XGp/RIrYvtS6ZhHUnIDotDc2lJu7+4Gv1tSGnWHV4tOLCMkRB6Sha+YoMKqRbsUTi/khUw2ZRS5VEApNOeKfEvGf59wjUN4D7CS+u0EoD2KAlPIjnONRqfKP7Kh6vwPomOxe+6+kOkusSmcLflHfcrN+MqF19jf+BTy0dXR2pqNM7Ugl9kwIBT45chucbTQjdj63dcaAUwUCZhrSbmjn0avnZDgyw8M0JioD/9ZZC1Ji8VLn8OmDWJgbN2xGvi76g9rY3aW91pzN1HqErWS9cBgjb9R8ZTNQkhmv9sw/4gANbZIX+jdOKFD+YZwnzXEkvUTjzANCezYDFImMAxI1+tAfgOGqdrzuWVOgEJSQcMyfJ5n7Gv2iFTE0IHov6G9JqS/PWDjC31jHBRKATgGzBPBTf6EhXAGmPkJ26M6vnngWCd/C8JhXyvaXOAzkYQNu8aGK7jN/ hulHYbft v44Etce1tZLwewTv+Q+Miwo5Y2mOw0W1frGvS49Lq/TuWhGhyDPQTA8sbnmgUV7Bm/eOU1s23cKZokcjvjSSEB4DNYMtzjW4J9oWq3333dEPYGVkL6uNg62aPG3HYRt/qVPy6B6Svu85Nlqn2HitohgbMdEBwod10ppHOE6vrN4lCmnlqZOyo2GOfa+/k8bjXlcB9CV5oEntB4xPzFRRn6sJKJ9oiSkyjDou0ZCQBvI6YTSKe2hGvPHfwHJL5dn1lhqQlaBwiyGXSLXFT5oVtv0DA3nSjMzsxlfCP2wBuqeJCojSLDqtFqpQecM4JCSHsnCSrBxw+hg+TxMcGtdwVcFmkWetAih/emkxmFOykJG/dK3IG8ggA5wzBXytENS0rjK5y6KTvZjw3siwnQLkvbzFWPWY8Pe7pTXCl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 28, 2023 at 11:02:46PM +0200, David Hildenbrand wrote: > Can we get a simple revert in first (without that FOLL_FORCE special casing > and ideally with a better name) to handle stable backports, and I'll > follow-up with more documentation and letting GUP callers pass in that flag > instead? > > That would help a lot. Then we also have more time to let that "move it to > GUP callers" mature a bit in -next, to see if we find any surprises? As I raised my concern over the other thread, I still worry numa users can be affected by this change. After all, numa isn't so uncommon to me, at least fedora / rhel as CONFIG_NUMA_BALANCING_DEFAULT_ENABLED=y. I highly suspect that's also true to major distros. Meanwhile all kernel modules use gup.. I'd say we can go ahead and try if we want, but I really don't know why that helps in any form to move it to the callers.. with the risk of breaking someone. Logically it should also be always better to migrate earlier than later, not only because the page will be local earlier, but also per I discussed also in the other thread (that the gup can hold a ref to the page, and it could potentially stop numa balancing to succeed later). Thanks, -- Peter Xu