From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 536C4C0015E for ; Fri, 28 Jul 2023 09:25:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C382C6B0078; Fri, 28 Jul 2023 05:25:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC0478D0002; Fri, 28 Jul 2023 05:25:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A39B36B007D; Fri, 28 Jul 2023 05:25:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 918196B0078 for ; Fri, 28 Jul 2023 05:25:30 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 35E5E4087E for ; Fri, 28 Jul 2023 09:25:30 +0000 (UTC) X-FDA: 81060487620.27.76AFA36 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf05.hostedemail.com (Postfix) with ESMTP id 3F707100020 for ; Fri, 28 Jul 2023 09:25:28 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=yZlBBa+Q; spf=pass (imf05.hostedemail.com: domain of qperret@google.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=qperret@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690536328; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MyDeksRVqGtJNd0fe/itajI8E9fXoiZCjVyZ7emrXms=; b=Z3aX+dVTnezcy1Ts76wrxOBfJ1vR7reISTpOfZwfdzm/ccbK7aAWX7qFZeuUNqLrVim2qG T7BxVycxA+rNI5jProwazOWRnn03e/LQ+9nD99Tdt6YQ/R2aFuNWY0cORV9rGvVTeWnyW6 RspReaR+6zSBeAHYGcweTjy5s8MSZbU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690536328; a=rsa-sha256; cv=none; b=7WwGAy6yNGlntpLqPHzBT2QZPHiA1H4hFJV4/2YQNwc2i2tKYrkde3ItuwFrFw7JOLcziN Zi02Qby/+iqqgxLWVLvsUB/4/mMsIzFzD8D3nhhueut1JRJ+YGsBtzpONYuFFXHjdm1sMo wwcZ8Pp8qwjc1z45bo+5Vcc7RfqJvgs= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=yZlBBa+Q; spf=pass (imf05.hostedemail.com: domain of qperret@google.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=qperret@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-99bf3f59905so24184066b.3 for ; Fri, 28 Jul 2023 02:25:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690536326; x=1691141126; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MyDeksRVqGtJNd0fe/itajI8E9fXoiZCjVyZ7emrXms=; b=yZlBBa+QgG6A3izqrAvYrZmjNARnJqe9UVJDDaWeo1ngnmOt9VRY93kWsBg3OxlgJ6 BNgAnv6T/0ObsR7NeaCjk+WNJnmyD7Q59yeCq15kUZEqjsFvHdvXA60zH7S6F25/qIjt fm8Sg5o5MpunPrL/BqoXYGZy7msDjit8jc0wg2EmQ6Q8Th8F7S82AjrHRl+/FMq8bTJh sEoAOBkEqP29Krhf8xqYypp/joUWh9VUOF8DEcZIisv2V3iWTfC6qxmMhKHNjRW9HI9T TolK5KmZ7NzIlhfQCguxbwjQDJpXunGMqxws18N6XaE4FtdLuzrmk4BalRM99UvIXMiI LjuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690536327; x=1691141127; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MyDeksRVqGtJNd0fe/itajI8E9fXoiZCjVyZ7emrXms=; b=SDbYtQmVcdbPsEV5DgYF3P2jReHZEhcjXoIYIMhvpzch2FtuOxFuUHv0RWR/9o5vWL YQfIlGpb8iTztLXL9eFAPNmwZ8Re63EtLVwLxVjIaVxHVYUjzEOOjUIzvA6jhBcduxXV U0iUMuIZGMD99lyIDJZMZblaopD/ePwOxQNiprqyoclDEZ5dJlojvv2/4vMv2ZGgu+T8 0FGE5X6ESotQPjzdjgNOSmNIBawYDMsEXByROlUnkp/FXrAxXH81PBZRVxYjoEe6m8DD ZbVPDYoUm6HPq5v+tzGMfNHxj1yH4VLGHIKBiqF3P3CjjFedwP1/Cxhg4sFr+/3z4OJk pkkQ== X-Gm-Message-State: ABy/qLa8L5wkdzZ7YTFK/JsZu2WU8Wd/gTTQpWUc+ZhCu/YBgei5jx3u cANzC6Kpd/DMGsxrRd+MUjAs4A== X-Google-Smtp-Source: APBJJlG4DNtaaix3llwTkCcLiQNG9ALlnJv6ynH+2HDeVn6HzB3Xx8i5ieUEd323eDEBkV9C48RmSw== X-Received: by 2002:a17:906:8454:b0:994:1fee:3065 with SMTP id e20-20020a170906845400b009941fee3065mr1975862ejy.15.1690536326590; Fri, 28 Jul 2023 02:25:26 -0700 (PDT) Received: from google.com (64.227.90.34.bc.googleusercontent.com. [34.90.227.64]) by smtp.gmail.com with ESMTPSA id n12-20020a170906688c00b00992c92af6f4sm1857653ejr.144.2023.07.28.02.25.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 02:25:26 -0700 (PDT) Date: Fri, 28 Jul 2023 09:25:22 +0000 From: Quentin Perret To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Subject: Re: [RFC PATCH v11 06/29] KVM: Introduce KVM_SET_USER_MEMORY_REGION2 Message-ID: References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-7-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230718234512.1690985-7-seanjc@google.com> X-Rspamd-Queue-Id: 3F707100020 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 6p5k485i7fza4m8ssa6gq3syfdiw3kqo X-HE-Tag: 1690536327-398187 X-HE-Meta: U2FsdGVkX1+mBI7jKQwZlQnpLO6W7jfbXCHg9a4PKMLkUKEcabu/FjlEY4gYFvO+9dQYggHLnle24tUUifRPn1oYOKTP11HP+Ss9uwLcg1eGz0euzcxfz1XYQpJGiz+vfhrMmywho3sl0irhI0B3C311t2oswuOugCdaxb1t5zPtftAU4wGTtZFM5IR5qTm6QdyZYInF4dWRkA6Q++upB9nHCphY8VR3AwpE+zNnPJ6TUN5ZlQfjVF+bYC2ELf5JAUci+1YwjLM90Jv2cdxnzkCWBDTorOsfLeROC0IyBCIFJYxWiK6lnD+BvgEyVmgSVtcOPLIiszSdj5wHid1MZU5aUmUlGcNRBoZozN82Ux3AvX+na2cyBxKlhlSr+YYSp+/pfcgN9b7XJWU+SpKn/d72u2O2Tj21QjIcER93z6F0HOVp49fV1hWvHvh6nyYyozxAxds3TkmkkB33CXXBc2RSlvrYSTEfZrb/H+A/8UX6BjV6OEDzEazoWvQulP/D22BSWD1/YgB0LasLISnM23poIETWYGkbfZHrrrx0qeNmzViqswZ8b8a7stOXRwjnXMBIrqr0Ts5PqrqA/u2AVPpc0YIwFzFn5nhRjwQ70c5+p32U769g2buFJo6V121kzdKQ5crfFoXj1CKnv5URg4GDVoGT3ssRv3L8g0wAl3iF42LzVKte+siiiEGwQEx/RrUJQ275VyVin0AAdDGTw7Jtd0wVkV3oTT7qkoUqZb8kmBn8wi63g6KFzPYBeuhE2VmQYa41R5kIduuaQbwRUr+9SvzByFmNIOQwOhfgDpVPXOuLEANUKI8bhM/z54AswrM+mEHldZusctZRLunxFO76UTaNi8b40fS0S79cQkAcWZWjP9JFsD7DNFNEDBzo4mRzhAhEQzUGXOxkPtXLrDmQVbYiTX1Y1Lmr0/f9mgS3KjlnljK2jZmv5O2JeXv+qxVklgOt25SvMN/1l0L zCMKUQoc olP48loFWd+B2C+KWb55KiGPQu6R+ppOEZ8CYDTAPmH9VxXvBfQ+5qwAe8u7vgAcJiBlkLNsmXtKPLg7Os75H+f/iqPzFXYMA5slEK1QzSBcvejgX1TEWOLP84BQBchGuVmm5VjyOEDDl5MO5IeuWw9YVKyLUcYYWmPbV3jL9DTG96U1z0gXIS7WuNf7zz188V9kNau7IdGRvhd4X3cIwCAvafWaLmKUt7NOEsJteHZ1IFp+zbO2MXYAKsVt4fGqy1vffcd/brnyAWBBs2VNY4E4Yf/K87NenfFlIBaY/RpIiDVpmYfgY77EZWyuwwTCGIqmYzhRMpL4iMG16204qzYYVbaYbO4oH1WO551VMRIGSN5eCYBzwvCYRgaK8FBKsrEZnTwlE9qqOaizzSgs5lVLOiiYdXGWU6tJK3PCAmOcb5cx8Zzgv3b+5I/fFmxToFk4GYXgLMQVCXGsPRHTkyyhBMgC8/dWFGLA4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tuesday 18 Jul 2023 at 16:44:49 (-0700), Sean Christopherson wrote: > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -95,6 +95,16 @@ struct kvm_userspace_memory_region { > __u64 userspace_addr; /* start of the userspace allocated memory */ > }; > > +/* for KVM_SET_USER_MEMORY_REGION2 */ > +struct kvm_userspace_memory_region2 { > + __u32 slot; > + __u32 flags; > + __u64 guest_phys_addr; > + __u64 memory_size; > + __u64 userspace_addr; > + __u64 pad[16]; Should we replace that pad[16] with: __u64 size; where 'size' is the size of the structure as seen by userspace? This is used in other UAPIs (see struct sched_attr for example) and is a bit more robust for future extensions (e.g. an 'old' kernel can correctly reject a newer version of the struct with additional fields it doesn't know about if that makes sense, etc).