From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4D69C04A6A for ; Fri, 28 Jul 2023 03:04:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92C726B0072; Thu, 27 Jul 2023 23:04:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DC866B0074; Thu, 27 Jul 2023 23:04:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A40A6B0075; Thu, 27 Jul 2023 23:04:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 666656B0072 for ; Thu, 27 Jul 2023 23:04:10 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2828C1A06B0 for ; Fri, 28 Jul 2023 03:04:10 +0000 (UTC) X-FDA: 81059526660.19.47F37AC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 4DD2F40012 for ; Fri, 28 Jul 2023 03:04:08 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YA8TmwmM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690513448; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GStcZIMJcpm3mEc/b6/z0GhlYIMNmnnV6wFHKdIVD34=; b=fNp+81WVkEdL30DgezKaIo4+REPEQkud5PEJBnyCTDpicP07WhngOs2m+lgewM2goh/kEV Vyjm8S8YbY44T4moG2vLlubdh7Qd2OjAV7vAheC4wY3sgQ1TUzybuZRJcg81f2Ygp3IkEj acHsBVdq1jD171arU+PPbj/v4/EuN6A= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YA8TmwmM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690513448; a=rsa-sha256; cv=none; b=AScjkwOtrP+oSEwfUOEWddykxgRlo+jBkE55CM0dIQu0+zCCNNud52Tm4X7huGJ++pyL0I wCBK2wv5q8Z7qOnACG9XgB2amAuw7mbMHimmfAWOW10ysOYXnsz5Bdd8O/nBDDd4FzTCyf GeJoO1UzmfEjei7blwE0O2IYQZjIXJ4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690513447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GStcZIMJcpm3mEc/b6/z0GhlYIMNmnnV6wFHKdIVD34=; b=YA8TmwmMHJkkO8B3ztixAVqxIP6kHlp08a0tVthkCl+4LWYwE/VDFfJRFQn8RDae0Gv5db lAdgao7Zi90FliUaYdyKl+ByNniWaOWaLeuziycflF2EJh4FGzOxTZ7mtqSf4w/FGKPq66 6n1vHFJ6nKomMuM7i/7L5aNeHJ3WE6s= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-31-UZIbd7wuPReYBwkAFZlj-w-1; Thu, 27 Jul 2023 23:04:05 -0400 X-MC-Unique: UZIbd7wuPReYBwkAFZlj-w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 134EB800159; Fri, 28 Jul 2023 03:04:05 +0000 (UTC) Received: from localhost (unknown [10.72.112.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0A4994094DC0; Fri, 28 Jul 2023 03:04:03 +0000 (UTC) Date: Fri, 28 Jul 2023 11:04:01 +0800 From: Baoquan He To: Dennis Zhou Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, tj@kernel.org, cl@linux.com, mawupeng1@huawei.com Subject: Re: [PATCH 0/3] percpu: some trivial cleanup patches Message-ID: References: <20230721131800.20003-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4DD2F40012 X-Stat-Signature: u9w3nenfs9x3pzij3ewb5ebgsjrq7ed9 X-Rspam-User: X-HE-Tag: 1690513448-655086 X-HE-Meta: U2FsdGVkX19HIsKJg5idtQRcctMfqsnoz+nDHGW50K+jmP9Rbao+hn8oULjaNx9/bE4TcV9Q+5fxFOf8ApO9Z4PWoXkODietl3py0L1W4E+Nm0UG1ZP786krx+JUyXKlyBhYsHti193Gui/N21cI4VC4nKOw5v0WcIsF6yhTiVBio+VTWpgStKUNQ5EkK2dF+GIH7mfcmapI4YAe70KYxRLHjiY3f/TLAF+vpRytrfylUV1NJSFAUkM/B3/3CPW3QfCBcy+AONRYBIbR6Xzs5xwgmYnVXSIEVTc5JHI4zo+qflWFCYTbwDdd7w27ujjiEVCPGzKndtcR4AeC4fR9uR3HPoHcJJSAY37F5ISSX54dTFjtb2QZo1LGfUAmXpk1jpeD0kDVAXIIksGzAJojLvqHnxvwdnDi32F3Pv7CtgUO4/Xq710eHFCaRTFoUyFS6uRFGwN9lanuwzqcRg4fsDfMAdRm0+FQ8QYjTQVR/MwQ+1D0/fR4Gxdvsq7V4p8pqSTxPBx/1cOakQcG+lJfeJyfiwVcs5YjQ2nd4JDKrbO4ZzVn42XKeJK2DtC+vouCu/b4zt8/XZlH8WSC3aNbe/sFcnE3uI3WdujzwYpYoxE7QGDRX8ZQJk9XJBK5UHdsXKtAZwRRnc/r55VneT3LNcxnKBJjstq35Fbo8PwGLDYn23w8iUdE8PM8UqMYPC9LVUnv+BkVLrMoFzzPw1pVtRuk8hRFyyZ2bUM2IEAbb8lmaG3Fzb/zkRy94Yo21bRi2nxPDtz3vejqX26QpM+VWZgf0E58Gcm5lS3nAXfQr2UoaoHwIO0I2cjGUwr/CARZqUXzAtka2oevoQBtEbUCycz1x2U0HbRtOncODlMWrxSk2Nf9xiPfMVREwaaaEQfF5HY+BCbvyN6P1d5c6JLOoJ7aI6SHu26wjfN/OsK73rC02EJ4afam4rncz6xYHSIvbpzXsFwx36Xt6w6ZCzR buz/cHkK WLBfuBq+AsiFAr+jMGYPirPjlEFCfBX56dabVM2RXDPxzqjrM9YrFtuYFbOzoCTknpcbDuRI2NjQGgwiY88aTUnPcYOIE2qs4PE3zP14DyPqoisUbVenBgaagcrOzbbD6/0G44qaso7anfcNwNmNnOQyGN92HbYNfxDYnzPAXxaJkQBhI77RdqTn9vt3J/zMIQBusSsC6jmw1ddEVJtGfdGXAJxmhB0KmSywgco53oC7Jq07Mj0p49kHK6tmvHAZ/36me X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07/27/23 at 03:50pm, Dennis Zhou wrote: > Hi, > > On Sat, Jul 22, 2023 at 11:30:14AM +0800, Baoquan He wrote: > > On 07/21/23 at 02:04pm, Dennis Zhou wrote: > > > Hello, > > > > > > On Fri, Jul 21, 2023 at 09:17:57PM +0800, Baoquan He wrote: > > > > There's a left issue in my mailbox about percpu code at below. When > > > > I rechecked it and considered Dennis's comment, I made an attmept > > > > to fix it with patch 3. > > > > > > > > https://lore.kernel.org/all/Y407wDMKq5ibE9sc@fedora/T/#u > > > > > > > > Patch 1 and 2 are trivial clean up patches when reading percpu code. > > > > > > > > Baoquan He (3): > > > > mm/percpu.c: remove redundant check > > > > mm/percpu.c: optimize the code in pcpu_setup_first_chunk() a little > > > > bit > > > > mm/percpu.c: print error message too if atomic alloc failed > > > > > > > > mm/percpu.c | 39 +++++++++++++++++---------------------- > > > > 1 file changed, 17 insertions(+), 22 deletions(-) > > > > > > > > -- > > > > 2.34.1 > > > > > > > > > > Thanks for these. I left a few comments. I think I might have some stuff > > > for v6.6, I'll figure that out in a couple days. If that's so, I can > > > pull 1, probably massage 2 and send that out again, and then I think > > > you'll need to resend 3. > > > > Sure, thanks for careful reviewing and great suggestion. So I only need > > to send v2 of patch 3, right? Or I should change and send v2 of the > > whold series? I may not get it clear. > > > > Sorry for the delay. I've pulled 1 and 2 (reworded the comment). Can you > please resend patch 3. Sent out v2 of patch 3, thanks.