From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EDA5EB64DD for ; Thu, 27 Jul 2023 20:54:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA1166B0072; Thu, 27 Jul 2023 16:54:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B52586B0074; Thu, 27 Jul 2023 16:54:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A18AD6B0075; Thu, 27 Jul 2023 16:54:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 953656B0072 for ; Thu, 27 Jul 2023 16:54:12 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 69725401F4 for ; Thu, 27 Jul 2023 20:54:12 +0000 (UTC) X-FDA: 81058594344.20.D9C7F67 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 4A6CE4000B for ; Thu, 27 Jul 2023 20:54:10 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Bi1FGj0J; spf=pass (imf17.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690491250; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1OcuPUaQjLUkSPF5ziwEuH1gdGw0Y2/mfnEGefK6PuA=; b=XQD6/+AmIAILPFXtDL0uO3nN1sQFjEO6NHKQtXAZcZkdoji7SBVVQ2gov4m9ajpVgMQWTz tYOf4EAw2+Ju4aLhXT03uoBFVUjibZb146b0fZbXE2wJQs9/F5A7vk0SNkt9OM77J6ngMl zJodtT/S6oAOYvd+hI5bGhDE1ZIsZgI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690491250; a=rsa-sha256; cv=none; b=qwmxRgkUmc5vW8xzMBxcdTRfOWhjCHhGBne53jWLAdkgUf39Z9wzcWRZb6aJccP0pbL9xN tuunnSCqufsJzr7UNrcsfW3vC2efbfy4nhZR50TedhyYkpoAlJx4rH+74c1riKSLOFziQ8 JOGs8G751Nd4XezuHh1mTHQaSWe5ed4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Bi1FGj0J; spf=pass (imf17.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690491249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1OcuPUaQjLUkSPF5ziwEuH1gdGw0Y2/mfnEGefK6PuA=; b=Bi1FGj0JMFtLtlZGh4/vnOgbj80L8Q+zUBFz3zfuzvQUJFbQ2iCPiVQzaKX5nFZ0Ix/XeK lRe5hrucPDD0QoHNj9vHOQprR6j8x3i+DjSNKrEFSKazlSVX2dWKHOBMEF4nYSy5jh4/YZ HaOSmx/vOAGRQVtc+tczU0rqO8s7WWU= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-9o4xpe6HNpGEQXCct6j-Hg-1; Thu, 27 Jul 2023 16:54:06 -0400 X-MC-Unique: 9o4xpe6HNpGEQXCct6j-Hg-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6364867fa8aso3392956d6.1 for ; Thu, 27 Jul 2023 13:54:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690491246; x=1691096046; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1OcuPUaQjLUkSPF5ziwEuH1gdGw0Y2/mfnEGefK6PuA=; b=D0YXpwUBbHyntaw59VdpYj4eA1n8E/Z++cu9tx0xV2EtfLG73bzZhl0Ju5ZjH9LwNp CnI6gZl/Hzs+6QzE+JmLrc6+YMBFPX+iJUUlWui6qgb0rtzlgk+RGNIALYN/m98iWme2 W3DLxp01Q5faUPgB+w7kBZqLR2g5NZuFac+uxKqiF9TKWYP3tpxnz5nICPQIhepznT/C tWjdcDnAY9VSKQrnJRLA8eIMMLuSLly+ev0x1OXaZEirHQgJYOWdGo2cuJMnX+tcKn2S S+mRm6RxLCru2PDX1mPO82QpY1U3P/PAM5y1GKWOALR9MnUhNPqYOJVjB8vq6ym+5S4h eXoA== X-Gm-Message-State: ABy/qLa4t1ZWHyzKByaK8eAJjmPZreX1cno/ckuBJxgOiSHHPuWy5VAW iL20C1QPmp7fagYUeWD9ddzhqdFHS9Qa/t2O0em+Zr1MelmeuqSAWXL3JPNOw9ifuLfRQDoozXL ytP5U6An57lc= X-Received: by 2002:ad4:5d68:0:b0:636:dae2:dc4 with SMTP id fn8-20020ad45d68000000b00636dae20dc4mr573589qvb.5.1690491245770; Thu, 27 Jul 2023 13:54:05 -0700 (PDT) X-Google-Smtp-Source: APBJJlEKlj6SzG8qCOOohZpbpp0o6XbCBjw+9tBDHZ+WPZ7+Z2U5Aj5njYlWBm4lviaIN+XPF+vG5A== X-Received: by 2002:ad4:5d68:0:b0:636:dae2:dc4 with SMTP id fn8-20020ad45d68000000b00636dae20dc4mr573577qvb.5.1690491245484; Thu, 27 Jul 2023 13:54:05 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id c14-20020a0ca9ce000000b00632191a70aesm690443qvb.88.2023.07.27.13.54.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 13:54:05 -0700 (PDT) Date: Thu, 27 Jul 2023 16:54:03 -0400 From: Peter Xu To: "Kasireddy, Vivek" Cc: Mike Kravetz , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , David Hildenbrand , Hugh Dickins , Jason Gunthorpe , Gerd Hoffmann , "Kim, Dongwon" , "Chang, Junxiao" Subject: Re: [PATCH v2 2/2] udmabuf: Add back support for mapping hugetlb pages (v2) Message-ID: References: <20230718082605.1570740-1-vivek.kasireddy@intel.com> <20230718082605.1570740-3-vivek.kasireddy@intel.com> <20230718234436.GB10413@monkey> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 4A6CE4000B X-Rspam-User: X-Stat-Signature: shzbf8msfdg9cbo3rpapxijw1sghokah X-Rspamd-Server: rspam03 X-HE-Tag: 1690491250-944910 X-HE-Meta: U2FsdGVkX1/yiGdc5NNWs7YkRQuro4TrSjNGPbr97xPkeyPuPIb4+SfPwPAL4a8p6SZam6c6p7vEyKm0fbGXaRK/QtmO9ChNFvbSR4jcyn7q/606cE8nwi4VoBT7WGJQw0JTyKSUdU1h5JvJkVsskZhp0xJZQRUtWALNJCF/3FoK06xMNujHhfOImfk6x/6AnD8I9WTXCS6BKykBYnRGPirRwhL5mhC2tJDfqoKdLswoOB6uOZ6AtFN2aknzl9Fnmfz1CzgLiWEQ0buAwIMJw5erIrZQ4xWBhRlFYNxc+UAqoWUKFNa5Sm4QSowJP04Z8S5WG7yYU/el1mF7tiLf0+bAaZ5OyTt+BH8TQWVPuiSjifKAR8j+OjueYqKf+pn2vl3M9STYHCgMhK210TFj3zeN6377LBeIwXohEivh9PnB/kcWciss9u+9LHG2WFkZjyBeaWI/yu/WhcCvV+L1xxRMJEQ51QF7B1p8xuAoHM41+MrmJ6++MKUn92GfkJhSvrcTqxLAl+6NpSp7FrOQBfPO4YfslhczXpJLHyXQQ4rKje7Q4pmaLc458TqL0JUkSs1swtJjZmqpA2WQzx+ofbd0PEGNRD7258YeTTLZvDJZQCJmlqdithUgyGltEP8jdP6BgJAdfGqnv7Y11Cp+NWtJFz+5D7oYcMX0uGqzADUaOA1wO7UQ0DxoN8ltdu7Zp/ZtG2iQSyWaPdC+sRvJ9Cfz4svy8L51zE4GCfjxrS2tRPtPNyn/WglwuR0yU88Am4CK5zmfz/3/+OxF+uk2qViMselmq+liR+CTDZ5Y5YXiOEy6MgCAln0OwyIQPgqn8QeLdXRuei//ja4gCadrm5JEgIimBPdkWZkmtO5Pc/KrmF5GzbFB4a52JT8QbAFCCf/UszWAFUm5as3LTOUCel6jLkWqCvegZn1EcFWYjA4hUH38srH5jURqkzt2NL/rz29DXXzpP+xJFgUSRZ1 rELY801S PoUKvbHSCc3Nfz2d4LLAjl38Nb1qhPrVTKYg3rFc3WhfM7hsqAlyWdl+157BsNwgtZnl+3Qtd4HkGTlVf71k+aDVAGmOnEEfJKxX6IUPYin/uqQP4rUjL3FtM5k7dTqlKCSETtz2vCM6Pm9xNA1hgb34HydlyYtOWVwSsl7bmZp4nr7Sb3K/PSGTojdwYbSsT75VSRyi0wZ85VknHkGepFZJze9e7qxJ12eauYe2TSJ53dHFPiLy9+XfAfP8cNoawrMA/nlLJ5EAfbYRUI0X/kdEmW8rI0sSPZkFRJl0RF1e02Oy3OrIf4whJL74KX2pH0k0blB4JsLakZUeTppM8WNjhkv1emSUbNhx5NPlpX4X/JnuhuLLMifOV/9BF8fd0Wu4UoPr8UVBWFinzsyLOQFtrJw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 19, 2023 at 05:42:54AM +0000, Kasireddy, Vivek wrote: > > > + } else { > > > + page = > > shmem_read_mapping_page(mapping, pgoff + pgidx); > > > > It may not matter to your users, but the semantics for hugetlb and shmem > > pages is different. hugetlb requires the pages exist in the page cache > > while shmem will create/add pages to the cache if necessary. > Ok; got it. Would it be nice to do the same for both (perhaps always try to allocate)? Thanks, -- Peter Xu