From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A98C9C0015E for ; Thu, 27 Jul 2023 23:08:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17D966B0072; Thu, 27 Jul 2023 19:08:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12E3A6B0074; Thu, 27 Jul 2023 19:08:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F11DA6B0075; Thu, 27 Jul 2023 19:08:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DD8E36B0072 for ; Thu, 27 Jul 2023 19:08:15 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B09554030D for ; Thu, 27 Jul 2023 23:08:15 +0000 (UTC) X-FDA: 81058932150.30.960872C Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by imf04.hostedemail.com (Postfix) with ESMTP id D3FF340013 for ; Thu, 27 Jul 2023 23:08:13 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf04.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690499293; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UBYOBoJLYiNWyPBZ8JtjEPNaBvs8n9DfL50KMt5h7Ws=; b=UWbuj9FMplkztgX9st8xG5CbSIX2h1RnIm+lIU2Y+qXaiUFGQwOMAen9PrUYY/cJ0Erh75 uDVAJZ/14YSzjLALwTDDNHRamT50GsMTosDgc37L9xLo5WNtBG7WbXYRGejc4yBhh/rfl+ OHThjeFt+cNv7sOaUOfEIxfN+60rNMI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf04.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690499293; a=rsa-sha256; cv=none; b=b4v5x9gSeCwLcLfsaeACKyhAjc5hCh+MVrjK88pazfHljGkg9BiBBGm/cEEFLBGEXjjQXH zdjyD8LdhvtoI0KrAAEHqmhp8a1CqwtTVgT3ZNth92r9lAZX4Bj9PmCYD4Igee69t4UX+C flnSVbLXPoIa1KqqG8DxwDLRATAiPa0= Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-55b5a3915f5so875528a12.0 for ; Thu, 27 Jul 2023 16:08:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690499293; x=1691104093; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UBYOBoJLYiNWyPBZ8JtjEPNaBvs8n9DfL50KMt5h7Ws=; b=OYzKN8O3UKS7TUJ5ec45ctbYm6RfVb1Dcj7e547em1RviUtvk5+VqjM2Zc58RtYbZo 8dyIM9VFwK2QrlWFKHucxV2qpL0ME9/p3sxIJlXyJwmQbeXd161h/P/NUOhw25kTwVsZ 5eyPHbzA4liNemnhB4x35Zg5FhDBNKuEv3Ccq/r9756tNIkThnsUVsMD5OAQuFQRrT53 XmTrdG0xY5Jy4qz8/PtwksLkHEI1+7esO/2Rm4RAKixr0s0nzlfD8drtVehwCk/vZ3v4 QhD30m/jzS3audigRK2tz2O62Da5+P/ZD1X6rwYC7qxaQ38C1zQYDC2KtHLt7SNQpSbf r+zg== X-Gm-Message-State: ABy/qLZ5htDg01BX6R+rpkW3soq6SCEZvl5ZCMRrRDhWVmE1dfsRF4qM rZRszFU0XyO99BYPGB3T63c= X-Google-Smtp-Source: APBJJlGz/uqkDGdyOYbooK4qi3urMgjXZdj674zcDvx65lAKgWJKRtnlfPgUlQsBJq29niDw8iMIwQ== X-Received: by 2002:a17:90a:bb12:b0:267:faba:705 with SMTP id u18-20020a17090abb1200b00267faba0705mr8961pjr.10.1690499292643; Thu, 27 Jul 2023 16:08:12 -0700 (PDT) Received: from snowbird ([199.73.127.3]) by smtp.gmail.com with ESMTPSA id m8-20020a17090a4d8800b0026822cb85casm1631801pjh.18.2023.07.27.16.08.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 16:08:12 -0700 (PDT) Date: Thu, 27 Jul 2023 16:08:07 -0700 From: Dennis Zhou To: Bibo Mao Cc: Huacai Chen , Tejun Heo , Christoph Lameter , Andrew Morton , loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, WANG Xuerui Subject: Re: [PATCH 1/3] mm/percpu: Remove some local variables in pcpu_populate_pte Message-ID: References: <20230712031622.1888321-1-maobibo@loongson.cn> <20230712031622.1888321-2-maobibo@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230712031622.1888321-2-maobibo@loongson.cn> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D3FF340013 X-Stat-Signature: bongdqajzq94ees15df1apfuw76qac8d X-Rspam-User: X-HE-Tag: 1690499293-120028 X-HE-Meta: U2FsdGVkX1+IqVSaW29KMmYxK++DWGI4A4jc6ZeZJM/Eueplu2o4dzTeAqxhB50AzadA62k/dJW0PwVEgdfDAZzHK0DnWiFb1Sj9/UVCajbBKXqjlMjE0ukFlNKJJrx2D51Kup//zSYHsqcmdTVX/0UAf3S4gN3WheuOzdgF5lHUV2S5iOiA+tuSX07WPxcH/C4k42CSkd+o3SilD3Z8M+5ZQK4Njesr3wLHEjW0mI28hV88voAfIQAa+hcAx6eobJbtemvnCAmcDPtmV1Y3y9VNru6CWdxnjeJfKbYa1OVGQYzcShT7BvXsAEXsfX+Pl57T6KwVm6TjGv6oC7K2R8W6Jj6KnmLzsHpk6HBJpN60RM5jR4125jibEL9HLB5dS5je/RL6EU5lbmY+ReVs25MpOl9H+D7bXfH5JbGH+x0oMtM6EwZKJcmP/Fq+WsPrE4BjZZsbbpPmrPLgMhZ+S1BXKxirfknYLCYb0nPnOysLs0qRwNoneBhI/J/aqRMosQi3IHoc5DnMvvV0t9kVsq/7ZJ70SaUjr0xpnqTPNFqJuuauC62JJA/nWLStk8ltf8f1j9ELr070E2vLm9H7x4u/rOyClKUEX6cBqFXa8qSHE7QV8+qq43Bs3WoXW36ft4lZPj9jcUxqLXyUEDDsI0QhFHUQ8VLsg24EqWhQDGrcuurdeMeLFi04/VwfuNrnlbQwLFnXSbr97JfkOsN+6osG7oNag5xblfTySVth7EnDYq0oQPNJpXhNRFSd3P3m8qxhZAtIKdfPxsnd9Wt+ElflUHAC3GQwJME/krPk7oZbJ/fZCEUUrUiasY+okGFAzmuhh90oSMegg+EQuei7sNRMwc+pJseHd6ADlPwXtM8u2mIeb4PZa5jip5ATx0k3tRwUPDfJ0nCWNNwHTpQGZFnSPbhpak95kDOpDgx5/pncQmxEdkzVFFdW3IJuKSX++zJl8mG8ZJNB6PQ5TWG ntI6ncnw DLBSTDXtpgp31N8gCbGt44Xc0xfwAfm+R2k1N7uoi5wgzgsw+BbV68p0R6N/xt9SBq8a/4fM7to09EKjsUdQ9vbMG8lJpjp7XE0XyYrKkSLDrkJZoZ9L5J705+UViiSIg7Clk4l4sZODfzBWWKpmfD0Vn8hxr/HhQ2BXHJVKYMxCnLKPAGhdVIjyI52k67azO/35UpxssLshdxBcClfXp2ZLEYdf5E7d8+xwG/c/kvIxj7f2AvLFUTBIioTlQ1hdgbcPy2O0LyZDoCu8h8UcXuwDhNg4bqQYWgzCDPcPRzL9GM/J1+Pf4FDCqlIlCqeCTa2TjOcnMp9a3+e9SZDh0NTJR9JKZBpCZsSQ/Pvw79ge3CqBkKeoIiIULvzODO3Beq4YZiGxHpCx02i42elYM0egMRu8SB2PIJhwFMg0ldKytVH7/PVqlSh1EXD3CgMAV7sBVLFGGbQMHCp/XVsPHzg8vQ+/XsC4ol7XU8CLZQcW3g9LkkSz/9ASdKuocikMJmK0Vmh4696T+9Tg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, On Wed, Jul 12, 2023 at 11:16:20AM +0800, Bibo Mao wrote: > In function pcpu_populate_pte there are already variable defined, > it can be reused for later use, here remove duplicated local > variables. > > Signed-off-by: Bibo Mao > --- > mm/percpu.c | 24 +++++++++--------------- > 1 file changed, 9 insertions(+), 15 deletions(-) > > diff --git a/mm/percpu.c b/mm/percpu.c > index 28e07ede46f6..85e3f9b2a61f 100644 > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -3189,32 +3189,26 @@ void __init __weak pcpu_populate_pte(unsigned long addr) > pmd_t *pmd; > > if (pgd_none(*pgd)) { > - p4d_t *new; > - > - new = memblock_alloc(P4D_TABLE_SIZE, P4D_TABLE_SIZE); > - if (!new) > + p4d = memblock_alloc(P4D_TABLE_SIZE, P4D_TABLE_SIZE); > + if (!p4d) > goto err_alloc; > - pgd_populate(&init_mm, pgd, new); > + pgd_populate(&init_mm, pgd, p4d); > } > > p4d = p4d_offset(pgd, addr); > if (p4d_none(*p4d)) { > - pud_t *new; > - > - new = memblock_alloc(PUD_TABLE_SIZE, PUD_TABLE_SIZE); > - if (!new) > + pud = memblock_alloc(PUD_TABLE_SIZE, PUD_TABLE_SIZE); > + if (!pud) > goto err_alloc; > - p4d_populate(&init_mm, p4d, new); > + p4d_populate(&init_mm, p4d, pud); > } > > pud = pud_offset(p4d, addr); > if (pud_none(*pud)) { > - pmd_t *new; > - > - new = memblock_alloc(PMD_TABLE_SIZE, PMD_TABLE_SIZE); > - if (!new) > + pmd = memblock_alloc(PMD_TABLE_SIZE, PMD_TABLE_SIZE); > + if (!pmd) > goto err_alloc; > - pud_populate(&init_mm, pud, new); > + pud_populate(&init_mm, pud, pmd); > } > > pmd = pmd_offset(pud, addr); > -- > 2.27.0 > I've pulled this, but the other 2 are part of loongarch and should be reviewed and pulled by those maintainers. Thanks, Dennis