From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 399ACC00528 for ; Thu, 27 Jul 2023 18:53:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9D0D6B0074; Thu, 27 Jul 2023 14:53:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4EE56B0075; Thu, 27 Jul 2023 14:53:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3D206B0078; Thu, 27 Jul 2023 14:53:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A75556B0074 for ; Thu, 27 Jul 2023 14:53:09 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7142DB1B23 for ; Thu, 27 Jul 2023 18:53:09 +0000 (UTC) X-FDA: 81058289298.08.E768B75 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id 2BFE140019 for ; Thu, 27 Jul 2023 18:53:06 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jogN2VFK; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690483987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OGaxUnsaNE7ojPpCXwzAVb69Blku+f4LZSFLg2JK47E=; b=aEZt2ZHz2j16or7g662+vKM4jA3UvY25tLQUjtUL6nBdGe2ZUT9rAyrSGKYVAtryLGhmS0 e+IWFOfDCrMV1WIlx0+C54KEmueBWDyf+88IGfwqYBwWenbwxEywnduS4UEC3sBAF/LmqS iGMJKJ2dWJTqnlujohMTfLYMv6o9Fcc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690483987; a=rsa-sha256; cv=none; b=KCQsbuY58z65+dvIHhj0VY0RTHCR7RmuD6RSz+pguZlvvBlNOzAuCKf22xw5f8o3ihM7VS UTKShaHKOMqW8x4lk8hejP9Ia5/FPOwlHtSu0A+OHPJbLZBNaLrxZac+sm6fsM6lWKt2bk 2fzw7Fc3ZcPFP/zWMQf8PJuoZtrW7bQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jogN2VFK; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OGaxUnsaNE7ojPpCXwzAVb69Blku+f4LZSFLg2JK47E=; b=jogN2VFKloiT/mNQrJzt2nk5mM q8wO5F9WcwdrfSfdfTb8E7EbyzZikHHkAec2gpMXny0zIH78btqu3i8bPie4LWsyX9CHbDbtFZatA VHUb1CTEQPXwid29lNysyrXAsjEpEhfiMGqInRiHYzfq2xoTQX+ONgOYL4kHJApJFQ3A5t1yPaFVh fcqdLsSHtg2fCv/KdUCwT5yCwDLbTwQ3xEXTX7UaWootHnp1yUTaNCP8XX82caFLMgPnGwpfj3Dmb jNiYpKoh/+Dk0N1603biI3Q9+nX23C/3s10Tpvucj/AIseuW+jUA1cQHxqm/PjCkovl/tIiJB5UjX +lqCVrnw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qP66d-007mOY-MR; Thu, 27 Jul 2023 18:52:59 +0000 Date: Thu, 27 Jul 2023 19:52:59 +0100 From: Matthew Wilcox To: syzbot Cc: akpm@linux-foundation.org, liam.howlett@oracle.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [mm?] WARNING: suspicious RCU usage in mas_walk (2) Message-ID: References: <000000000000607ff905ffc8e477@google.com> <0000000000000aeb7f06015e5cbd@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0000000000000aeb7f06015e5cbd@google.com> X-Stat-Signature: ybqanmss16iciwrtthwc1fzyd6bfjx4c X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2BFE140019 X-Rspam-User: X-HE-Tag: 1690483986-651207 X-HE-Meta: U2FsdGVkX19O5BUPJJmXXiWAGxDuljt+PdxFPUhK90/2tyOhs3/2/VDcrbc1B1cKJ+WEUDUEBv82aECJl6C/gYWTk2rTizLQMeUusjgSnL49MhEIsMv+CMmLbGqz8si75C24rmH1EGpfSf8HsuA/RkhmHlqMfR7h2OjsFPB8E4Sf5upLt6v73OIIas3xpTvyCbZSy8NCi+A5qacq0nGFjhUEvUMmTV152AM35UYbw2RuaMdDDoezMVDbhCPFais9GtsMA71dBKKDljgITCRq54MWLn3EMTg9pkgcXbkb3yyQLvDyZ3aZNFOY8U+MkRmQkZn5IWXzObGWCQt8an+8XGDGBI5gkxoIZdhdWHPy3l/3qvCs2T7CvjgERb5kgJlfY/yoTCylCwcvNhSHAcbu3U5KsJZKLmHCjNwnewrZOFDvRj80bEy/B3f5ipz2K4sBdQr8y5jAcdWEt4PJR1zQ2oaICcciWg0avx3KcqP3mFfafhtU5j971uT4EA3OLJOEgC8f8qBq2zkZeyMwRN2R/MVB5s+n9N8J5Glm5OR0bylCyogYxuwBRvk8J1J4jf4Uj0nbtMp2brL0YdRvI6SW5qzpasf1kn19AqMP+JPyKfawW5lC4N5dyivgX7QFrTkSgIWg3dGKhvz9uzmTYZlDCrOUAUXVjQZurH3UbxdLuc9YfVIVlS9o9ZuUL9irFUsexWmo7QYYHvgZxjjJapYmoH28L+CzrUd4bqCZ7FzyB7+rf8es7/LZ84qR0F5ZJ7YTWM/aId7IRtm5l+h9zt0Xcd6cG3A7oCRC0SlXspEsTjqMvoEQqfL2bOPm9kgnHPobIkuVXuhyuo+rHkTBqmhUnfrOlXxp0AX3RZD8JK5TSxTO0CHxoS+8zyVwbwZrQC+1EptS+VaaIbeKRRCOW+BPJO8SjsD9h9sEa9VAKfqAx0CsZiFv3YjRRyYczdxpATujwxX/9maQB5zMc6xbEXB vlBdKfd7 qlF718N5OO50uEjzLwWMPddc+6h6Kzu/HxZVUXCj6C42drjWFWAEaSGJKZgmDkWLq3VeuOi/JSCRZ9EuZiBCxzfV5TL5NE6Qor7rGcPJ11jQ8CtATLzB7r/jIfYxfuisUX/HaUVXi7NZeNpVopttTEXovi6groyRLC7BP6z5R13KSIF3BEHiRsrrnfaSAUKW3mtD/OqUR4dP3UcUY3zUXFYF/AIXIUEJkfBgz8hbkM+lEclz/eX2aeGVft4BF9snnMw/Nt1DGDaXu4z0ueQl161K3Env50/Z7gynN+h0RjZq6ZBl0C0YJuZcvX/XOPNROwI88p0Y7J9ku2u3EuKWQe8J3zCewYtfNyHQod9mN48BHGHawDRTE805Xsa8R0xwFg+iPqHfwdn3J5FH06tpbNFYw33ilgi9NE2Gn6HfCojT9zp7escpwE8IlqLjbEm5xoG2Ozbgls5h04qcD21XaEhnPIQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 25, 2023 at 11:57:22PM -0700, syzbot wrote: > syzbot has bisected this issue to: > > commit a52f58b34afe095ebc5823684eb264404dad6f7b > Author: Matthew Wilcox (Oracle) > Date: Mon Jul 24 18:54:10 2023 +0000 > > mm: handle faults that merely update the accessed bit under the VMA lock > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1783585ea80000 > start commit: [unknown] > git tree: linux-next #syz test linux-next a52f58b34afe095ebc5823684eb264404dad6f7b diff --git a/mm/memory.c b/mm/memory.c index 20a2e9ed4aeb..57b271108bdc 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -3567,6 +3567,12 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf) return 0; } copy: + if ((vmf->flags & FAULT_FLAG_VMA_LOCK) && !vma->anon_vma) { + pte_unmap_unlock(vmf->pte, vmf->ptl); + vma_end_read(vmf->vma); + return VM_FAULT_RETRY; + } + /* * Ok, we need to copy. Oh, well.. */