From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71BABC0015E for ; Thu, 27 Jul 2023 09:23:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFB406B0072; Thu, 27 Jul 2023 05:23:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EABA88D0001; Thu, 27 Jul 2023 05:23:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9A306B0075; Thu, 27 Jul 2023 05:23:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C82946B0072 for ; Thu, 27 Jul 2023 05:23:52 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9789EB16BB for ; Thu, 27 Jul 2023 09:23:52 +0000 (UTC) X-FDA: 81056854704.10.6FB34F1 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf15.hostedemail.com (Postfix) with ESMTP id AB1EDA000D for ; Thu, 27 Jul 2023 09:23:50 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=IqS4TyJA; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf15.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690449830; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t3a2K2H5eWN5+vuGQTox2mxK0yUNiYLQL2611PJPb2c=; b=f3lkHp8D1a/HpnsaYx2TlUknP9c9kROAKQOURMPF9Mw26m3tmXxq9vKABfGaVTG9Fnts38 0AJ+lrRQvkQ4usYYeJU7MwPcKzabTzI99C1/XietojiZ7Xk/2X32/r5BsqV7j7NVF9JwZP 9YwJ3+noLpuScrHsNUD9GD0aoQExWag= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=IqS4TyJA; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf15.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690449830; a=rsa-sha256; cv=none; b=ZTNY03sIm3LEuKNaczsqL8wbV8PpxCYZ0BsXOdoaM2qXL2Q23ptnPZR09a8j3j3H4tZ/q3 S95xgXehtUNvOapGQ5MocDLC+vEej1F1EOJSFgDLMMmZu8hr1hGvUcRlBSwXsUHN9uRmmY ce+/RuugTDxqifqZpZpNCSMd4GwPJJc= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C93991F747; Thu, 27 Jul 2023 09:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1690449828; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t3a2K2H5eWN5+vuGQTox2mxK0yUNiYLQL2611PJPb2c=; b=IqS4TyJA8FZGO3n04s/JboWGbbBZ93RMXtbGr2dy2wzyay9clXBqg50VKhhWNTNNQ2ocPu 5MErvY/+Wk4Rm1dItFNlhkCeLU8yTXt7715OwF+c3PAl64rnydzV2PVhPHvoIHv6a2kcOQ ZYiqpjBW45GLCQtXN/rr15gRN/gJAQE= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A6B2C138E5; Thu, 27 Jul 2023 09:23:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DfeeJaQ3wmSIagAAMHmgww (envelope-from ); Thu, 27 Jul 2023 09:23:48 +0000 Date: Thu, 27 Jul 2023 11:23:47 +0200 From: Michal Hocko To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu, Oscar Salvador , David Hildenbrand , Vishal Verma Subject: Re: [PATCH v6 4/7] mm/memory_hotplug: Support memmap_on_memory when memmap is not aligned to pageblocks Message-ID: References: <20230727080232.667439-1-aneesh.kumar@linux.ibm.com> <20230727080232.667439-5-aneesh.kumar@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230727080232.667439-5-aneesh.kumar@linux.ibm.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: AB1EDA000D X-Stat-Signature: d13uxzgpcjaaubugpbbo6475k6shajih X-Rspam-User: X-HE-Tag: 1690449830-306059 X-HE-Meta: U2FsdGVkX18p3UZ+FBK5e77i3b2wtfJ15VDUR4O6QWMJbQs7LwJ18BMy1sHZrLAa2QbT0LGBDa4E69qoB1GpK1RKnV/iyt44A2tdG8Vgw/Q3sGZt7+7yFp80FRV9LzSxD6ohmf+3aPbP8jvMaUR6WrF/clf+hVspbSsFzOb8by8lIRA121XSJsFdcLB6CYZ3PmhI/nolTTCXJP3HICc47hLG2GAjDLQn33V4MdZay3uv1M4vHmqMguqDHOgecZPwFScjPrKNSbMtriX2mNjk3vmow4ts1QkzcXdYHo2glqKeF1ZZUENOq+oHNcrHqXEzvGEwwtO0ycShS3ZARoviA7tkXgd+lbbDOaDIyorr1so/2wJiilNa7HpY/LVFn4IvVDs8drIgtSeKHsWK5JeI70kFvOJr9bqFWVcgtdWQisocSmJhqa6Od/lhZCDbKDVlHtc/tL6tF7tmp3hQSeCkbvLV4qmmgpYd8TGRiw+ru77SXNnefvZcnmN+dTnWF6S2F5IYCW63Vyk/XVv02Myb57MFNSI8FJId9aVE97ZlS4xFYzh5dfOJ2UR2g8jdHFBJixoLZZB30n/j/MaaLmNt5VOkt4ZP5L6IPhBx3+THBsbuD0UK4FnjQS2uKVG1VDMef3UqjBmUQ2XewlPxGTHrX9JF6ek9mF5PvlXdjXMMO5lRU9tLZ7Cl8P63abNOnstAgIPWlJNVtPUT6T3cjsG5mRMhFNY2LWFBikoPNsjt3Ff4xV0iE24y18F4DU/Y4Z9fyR8uNZbEvQLsNUvZcMWiS/Bf/oFIm3WgdLSynsHuT/ZNtOyAHv6eKA/jybnfAWDCK9NG1gtpEfAABvS5mUHSRXlSykXeuxhCBiPbyi9i47sh+pkfwTngkugnmVLjmqSOoSdsPU33mhLzh0y2OoGZ6Af4+cwht0E2yI0A03KDQJZ58ShUMTOCqDcZim0mhI5yxJU/AWXpwjQbmHIl8Ye pznVLS1Q AiSUDCZvIHq8bng/AIKaHXXiyIg+En3VBnNCiKvV0Y+X54i3Vr+Lwqn0oOnBwzUTOq6kJFT2+haOOKG8i251omid8ibBIgvGfOgXr4LOjCjm6kIVmHehOYednLX+qHtFiT2OeOdIrRJQ4QjTRS6C0R1M/gT3q1JsuLC10241AAYsH1oL0U/bZcBpKtHIlO5PY06Rt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 27-07-23 13:32:29, Aneesh Kumar K.V wrote: [...] > + if (mode == MEMMAP_ON_MEMORY_FORCE) { > + unsigned long memmap_pages = memory_block_memmap_on_memory_pages(); > + > + pr_info_once("Memory hotplug will reserve %ld pages in each memory block\n", > + memmap_pages - PFN_UP(memory_block_memmap_size())); > + } > + return 0; > +} Why should we print this only for the forced case? Isn't that interesting for any on memory memmap? Also is this the above sufficient on its own? the size depends on the block size and that can vary. I think it would make more sense to print the block size and the vmemmap reservation and for the force case also any wasted amount on top (if any). -- Michal Hocko SUSE Labs