From: Michal Hocko <mhocko@suse.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
npiggin@gmail.com, christophe.leroy@csgroup.eu,
Oscar Salvador <osalvador@suse.de>,
David Hildenbrand <david@redhat.com>,
Vishal Verma <vishal.l.verma@intel.com>
Subject: Re: [PATCH v6 4/7] mm/memory_hotplug: Support memmap_on_memory when memmap is not aligned to pageblocks
Date: Thu, 27 Jul 2023 11:23:47 +0200 [thread overview]
Message-ID: <ZMI3o8k/+QKbhRol@dhcp22.suse.cz> (raw)
In-Reply-To: <20230727080232.667439-5-aneesh.kumar@linux.ibm.com>
On Thu 27-07-23 13:32:29, Aneesh Kumar K.V wrote:
[...]
> + if (mode == MEMMAP_ON_MEMORY_FORCE) {
> + unsigned long memmap_pages = memory_block_memmap_on_memory_pages();
> +
> + pr_info_once("Memory hotplug will reserve %ld pages in each memory block\n",
> + memmap_pages - PFN_UP(memory_block_memmap_size()));
> + }
> + return 0;
> +}
Why should we print this only for the forced case? Isn't that
interesting for any on memory memmap? Also is this the above sufficient
on its own? the size depends on the block size and that can vary.
I think it would make more sense to print the block size and the vmemmap
reservation and for the force case also any wasted amount on top (if
any).
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2023-07-27 9:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 8:02 [PATCH v6 0/7] Add support for memmap on memory feature on ppc64 Aneesh Kumar K.V
2023-07-27 8:02 ` [PATCH v6 4/7] mm/memory_hotplug: Support memmap_on_memory when memmap is not aligned to pageblocks Aneesh Kumar K.V
2023-07-27 9:23 ` Michal Hocko [this message]
2023-07-27 9:27 ` Aneesh Kumar K V
2023-07-27 10:55 ` Michal Hocko
2023-07-27 8:02 ` [PATCH v6 5/7] powerpc/book3s64/memhotplug: Enable memmap on memory for radix Aneesh Kumar K.V
2023-07-27 8:02 ` [PATCH v6 6/7] mm/memory_hotplug: Embed vmem_altmap details in memory block Aneesh Kumar K.V
2023-07-27 9:25 ` Michal Hocko
2023-07-27 9:32 ` Aneesh Kumar K V
2023-07-27 10:56 ` Michal Hocko
2023-07-27 11:17 ` David Hildenbrand
[not found] ` <20230727080232.667439-8-aneesh.kumar@linux.ibm.com>
2023-07-27 9:26 ` [PATCH v6 7/7] mm/memory_hotplug: Enable runtime update of memmap_on_memory parameter Michal Hocko
2023-07-27 11:18 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMI3o8k/+QKbhRol@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=david@redhat.com \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=osalvador@suse.de \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox