From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 268AEC0015E for ; Thu, 27 Jul 2023 09:25:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7AC76B0072; Thu, 27 Jul 2023 05:25:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2AE16B0074; Thu, 27 Jul 2023 05:25:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F1CA8D0001; Thu, 27 Jul 2023 05:25:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8C0486B0072 for ; Thu, 27 Jul 2023 05:25:14 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 58941C0538 for ; Thu, 27 Jul 2023 09:25:14 +0000 (UTC) X-FDA: 81056858148.25.A58CC5C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf23.hostedemail.com (Postfix) with ESMTP id 8B140140005 for ; Thu, 27 Jul 2023 09:25:12 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=LQaLxXqi; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf23.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690449912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eoQwkBmT1hyeapFwp/0+cDin0BjEYAjkQ4/FeLmHSp8=; b=Vyc9IBFJhjdaCMfqWVo7FoB+m2atQmbiwngo/NQcgiYXx/GFRmYrB0KvT+qwzKhq1+orm9 rL96jz/eSQJ+JNslV+e1B7NzGHdh2egerO8rZmuilt5/ABsX/YsxZs56fdaIrwKyFMOO7r AshGf+ypnQhOmFvYpnjR2yRNW1Tja4M= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=LQaLxXqi; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf23.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690449912; a=rsa-sha256; cv=none; b=KJF8EJdPlUDz1CiKvsDboA9rykqv4C9b5wh5K2k0b8Fa0EbLtxLqvD6cmBHVeBtZj0OIDN gRdiMPietVmZGjH20LvMWo7bv5Hlsr8eSRM//9EaXf6ZHlFDjsaWFHC/kcNoz2CT6AKscq 6t/gpn1kioSJI16tzLIFK7Nti65dnyU= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E2D751F383; Thu, 27 Jul 2023 09:25:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1690449910; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eoQwkBmT1hyeapFwp/0+cDin0BjEYAjkQ4/FeLmHSp8=; b=LQaLxXqiZ+u0anFqzvE4WU+pTxV/aJXBb1yG+TbXXnZb7h22/YtntjxTQ4yY/gFg4wC/on Xaw0soB/AUEhd1+kUoHh9FgVaEV1f8tnpO291+dFschB65/AO6yN0QpsIpEoK+1iPSJMuI 5Iz6tGQsIY/QiUxsU+O0cPQEK99UriQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C4149138E5; Thu, 27 Jul 2023 09:25:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id tn3lLPY3wmQvawAAMHmgww (envelope-from ); Thu, 27 Jul 2023 09:25:10 +0000 Date: Thu, 27 Jul 2023 11:25:10 +0200 From: Michal Hocko To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu, Oscar Salvador , David Hildenbrand , Vishal Verma Subject: Re: [PATCH v6 6/7] mm/memory_hotplug: Embed vmem_altmap details in memory block Message-ID: References: <20230727080232.667439-1-aneesh.kumar@linux.ibm.com> <20230727080232.667439-7-aneesh.kumar@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230727080232.667439-7-aneesh.kumar@linux.ibm.com> X-Rspam-User: X-Stat-Signature: btdys7gdx9cq58oc1twz1gesb6363ni7 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8B140140005 X-HE-Tag: 1690449912-871646 X-HE-Meta: U2FsdGVkX18XJ8QhvTJJayQyluvzSQAjIRWX//JodzMEk2qRnuH8Y635cKQwNXHpET1/qYSfXJrxmV/rWt2R1Rj3q1qAFfRnVoQZPOTtn7OIbNxb+BOvXNkhMtvr6sCVvbwvpWOurWbpJH3zttgHgDF3br2/eYQENBsK7vEDW9JUM9pk9bJyzdQ3oLEIffsjVxbya+SeybTvDe0qpQzQuYsTQ1cC+41IJavfNoHm832v+KvGBstKQHDVUwm8ONtoYQClcJetK28gozwUhqWQJBfpRJ310rM+SKXXowYjtnaslhQH4OHwJ43vqeTItCH3ucnGKaCXHIPeUYakpta96YcmojXmsWzcHQ1PWgVcI26XGSRcL0hD9PEamDIr0dj+G85lwC3vV50dt8AVxwuU+Gze4BlmDUDNU1WluaqaNaOnKvPlT70hCkjFDar3xRvxBA+AhvpkzElY1nxL1lVIEBrecgZkliOR10R5ps/QrClIL0EsXrAO9oxjyQ+Ba0X/IetkzCFQLuJ3u7Z/q5Nz62lpZvtyjFzXYTJrTO+HPDF22M7Q8SZveQOzzhWOaHc7lBQRaP+QSAVqiCKo9NbK8kcdXlOcSba04D9v4HYTgw7jCyI8/AHv/FYZEr88ForeUCOqMDEBm+mj1DYCE9tIuuauEURErvsEf/iZyZbcGE0e4bO+WBsJDsOcEMuPnbJ+1Cxd6rgqTyYJYbE4GAEkdLBm9xQ+89cdobZkp+Qbt1gMepHf0VNKhgHt45oupjFvwk7ygX+amjnlGI947ZuH/FtEqqCbGFOptagjWUIVvMSDOLUk7KzTw3Br2bWdCtSxN87zW7dH1MTUkNfDAUtna/vZpIZOnEIZvP8N4NayurSR0OyVefVSYEmayUYF5cnBs9HDxD4KqhZNu4y5uOvykA9HKGxlhevkyXO3h3Fk9mIWQcZyzuJZPBuw2LcctaVM1nqEQyqSLcxLc0/hAM+ v6tKuvnQ 32j59D7PAqQKgFicnQQC6eK+pA6V07e6eS7x8Pwma32erWrNmSgTCNFnarFbBJzNpEnbA+Yptk71MF8MmcAqEZekQf5zr1SoQNQTVP9Fsa2tyIZklt59GE2i3WUf+ZmmBE80WrrE0kzms1vxAVIaeGucAEmwrnSaZZTxdq2I8Baj7eCCW2z1WbSc78LTJWTkv/jvgyXyFYvOpmxAIimdnFmDLmutE/6DjVATt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 27-07-23 13:32:31, Aneesh Kumar K.V wrote: > With memmap on memory, some architecture needs more details w.r.t altmap > such as base_pfn, end_pfn, etc to unmap vmemmap memory. Instead of > computing them again when we remove a memory block, embed vmem_altmap > details in struct memory_block if we are using memmap on memory block > feature. > > No functional change in this patch > > Signed-off-by: Aneesh Kumar K.V > --- > drivers/base/memory.c | 25 +++++++++++------- > include/linux/memory.h | 8 ++---- > mm/memory_hotplug.c | 58 +++++++++++++++++++++++++++--------------- > 3 files changed, 55 insertions(+), 36 deletions(-) > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c > index b456ac213610..57ed61212277 100644 > --- a/drivers/base/memory.c > +++ b/drivers/base/memory.c > @@ -106,6 +106,7 @@ static void memory_block_release(struct device *dev) > { > struct memory_block *mem = to_memory_block(dev); > > + WARN_ON(mem->altmap); What is this supposed to catch? A comment would be handy so that we know what to look at should it ever trigger. > kfree(mem); > } -- Michal Hocko SUSE Labs