From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 717C9C001DC for ; Wed, 26 Jul 2023 15:08:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 076F68D0001; Wed, 26 Jul 2023 11:08:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 027386B0085; Wed, 26 Jul 2023 11:08:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E57D18D0001; Wed, 26 Jul 2023 11:08:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D7ED66B0083 for ; Wed, 26 Jul 2023 11:08:47 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4D780806C0 for ; Wed, 26 Jul 2023 15:08:47 +0000 (UTC) X-FDA: 81054095094.19.31B5A57 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 7220840085 for ; Wed, 26 Jul 2023 15:08:38 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kxg70PNC; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690384118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3SBJoGUFZ8lwNkwq/ql9uohKYuuPWo1S+MSI6dKly68=; b=MlsGkv3HREewe4sqbr6p1f+paxNvIgN29IICBhjH3gf/fRf7micEHk++QqpMBnA0U9LWEI TOYgNKwByEXNAWhULQIxPyw/atES6vZVn9/LjhX5CEo40CZmKOXvHSHJzvS3eTrjqcgIk/ TVpz/qQNoi86aJs/ycLxWlhURdgLjRA= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kxg70PNC; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690384118; a=rsa-sha256; cv=none; b=OGwoC7HXfqocXMwn7iv1l8acoaTKU803QV+OgG9aAOz6nSwvhSI+RxozGM53UgrX/xmjNm G+nCgpj+V6OIRPrS2I9d7wq6sXmyJY9GKgryND0Psw4FC0LCPaCfPFVIrZVTPABKbq65U2 +JeqH+JT9faLrYKshUQQluUUN5aShto= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:To:From:Date:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3SBJoGUFZ8lwNkwq/ql9uohKYuuPWo1S+MSI6dKly68=; b=kxg70PNCtug0NJoFTuxLUyLzfJ yoL1xXtL8MafasBRbj3eKvHSYAe/765iHCyGLEVnRawDXUnEEUBDfFJ5K4mtDwrZ56ZwNKXLRqMVL WyB7C0LBiht5Rv5BXDbmUjmyQPDEvoGEE/BBcprp5VAbEaWgfo3gfvSQqbYghXGezTUvrQuDgi4tl BeVsH8AADMNLrZcyT3iOv/c1l1CwhEY5OHLZC6A64M3Jdky3ZvMxQgEpHVJRtrtYNVoRwqwPGCGJP cKXPTSmg7LQahm5ypLgqF/Dr6T7myCulXlL1hlUS069de/c5He+dIOj6/EkZo5gWjGWBNnqPi4fCP HHA7XSQQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qOg7Y-006aoa-W3; Wed, 26 Jul 2023 15:08:13 +0000 Date: Wed, 26 Jul 2023 16:08:12 +0100 From: Matthew Wilcox To: "Liam R. Howlett" , Peng Zhang , corbet@lwn.net, akpm@linux-foundation.org, brauner@kernel.org, surenb@google.com, michael.christie@oracle.com, peterz@infradead.org, mathieu.desnoyers@efficios.com, npiggin@gmail.com, avagin@gmail.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 03/11] maple_tree: Add some helper functions Message-ID: References: <20230726080916.17454-1-zhangpeng.00@bytedance.com> <20230726080916.17454-4-zhangpeng.00@bytedance.com> <20230726150252.x56owgz3ikujzicu@revolver> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230726150252.x56owgz3ikujzicu@revolver> X-Rspamd-Queue-Id: 7220840085 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: c43xtz4xz6wgmkm4hzg1pkaqsbj3p3fn X-HE-Tag: 1690384118-155577 X-HE-Meta: U2FsdGVkX18y0hK22Ysnh705A/BowkR/S5q3Hm7ZENXxehw2vZIaFup4VgF9TgTtUD0CnDaljDCPPu/9Za5BGaSqP5BVx7yeOIHE56NikTYyhhcy0bRuRCNpEdPPAO+LvxSCQlLHvWyYzaJwMoDX/nCT5TfnodBOLkQAGAVpxrqd7nYbwWxthWp3ED4U8OkDhU0t/RHSD0bFDJRkH0UqoN+u06lL74fqH7HCFd1pULxrY7ancwB/PyFXchNNYgLv/fBncffH5ch1gK7Ex7xB+s8W0BxZE+6bvDyNrAakB+vXYFOIXI8PeVJOA0sZdPow5nf+moEIgvd2oTsNU+efL8hUTGbUIMrNWYqSFZp5U/BrBhRsvkNmo4acSwgltI0PtEzBsFudL6Q9a/1Yd82/ykyfVIQZcz8/EA30l+nhM7kNhxsNvv++wSPHvC2jNLUk8P90EaFJFbcAhcTjfkkDYpDo7yjhks1LTVwGo9ftvj0bC7zkQr8y3t/CXa4Dm96FhVscmVdlmJW949AbawuLuZQjJ5NBT1nvyBe2fc6hfpqWkaJdBmCkrg2/g4BxYnw+l315z1nFqe8frkETqkmeHXm6df4aTCFWPP9TfvRmFGhRu9bOz6yj8Ond9/nhBD1Khqz5Jn5m5yr6JQsUPfTZ5Zj5ZvUwm7Hgjdr9i7iEYdmJ9/Gzdj0Qb9i/vDWNAjYwfGYtcIv6D2NTu7NTBLPL3F6tq1bWFbGRMr96k9LxvWeLxUF/mYshuNHT3e1SkojX/D7gjbJ/p+W46zpoWqRMPZ1XsCSxmJIiFZAzXyR5mAiQzeP/dbz+okvD0dQoD6uiU83QeRJVT9va5urfDmosVxFilC+Demz9pYJc9Q118k/aQJ5dwylxQAK2naC6gcLnHfNV95BvcEZ3XNtMQye53PohHh86Sa5olYEKVtTFJUumwUZMU9cpcS+CBm+icFEvlIi80UD/R2pkb6z0myr QxpoXq0E WqA5Ck72FuOwWN8HdOBFpy2e78T2zM1FB01tNbxLDDIVap7jUY3pPOtRXuVkOmB1HduAFvR6w0ChNngSHKO9UpjRnmnnNa8yghCxezTs8vf/QmhqyN55nEWphYLAsHb2/bbO/39rCArQrwVuWhCYOW9tGIYnNNq/qZ3rsqSBpiOjs3QGJ0AXwJP+oIeS1nWGPLK/0sWCKCd+EHMbwagI0WCW4PkzMUJt7AFANMmciz5yIm1LM7xezA9Hl0Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 26, 2023 at 11:02:52AM -0400, Liam R. Howlett wrote: > * Peng Zhang [230726 04:10]: > > static inline > > -enum maple_type mas_parent_type(struct ma_state *mas, struct maple_enode *enode) > > +enum maple_type ma_parent_type(struct maple_tree *mt, struct maple_node *node) > > I was trying to keep ma_* prefix to mean the first argument is > maple_node and mt_* to mean maple_tree. I wasn't entirely successful > with this and I do see why you want to use ma_, but maybe reverse the > arguments here? I think your first idea is better. Usually we prefer to order the arguments by "containing thing" to "contained thing". So always use (struct address_space *, struct folio *), for example. Or (struct mm_struct *, struct vm_area_struct *).