From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03166C00528 for ; Fri, 4 Aug 2023 20:34:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7312C8D0001; Fri, 4 Aug 2023 16:34:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E0EF6B0072; Fri, 4 Aug 2023 16:34:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5817E8D0001; Fri, 4 Aug 2023 16:34:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 457C86B0071 for ; Fri, 4 Aug 2023 16:34:14 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EAA641CA180 for ; Fri, 4 Aug 2023 20:34:13 +0000 (UTC) X-FDA: 81087574386.25.ACAD68F Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by imf23.hostedemail.com (Postfix) with ESMTP id CBC6A140010 for ; Fri, 4 Aug 2023 20:34:10 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ciecLiTN; spf=none (imf23.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691181251; a=rsa-sha256; cv=none; b=us8y/mCOG+GKW2bX1l0hxW3Sps+pcELhhkSED48L5TjWDInb2vOAOb+MYbbpEQ3y+xJPg6 ICZIyp707AYwREa8vcHI2nbFAeOs1lE/CG0p8pDQjINT488LOKno/9QdbEYhMw4qVwEvv+ VgwKjSvcoLOuObH748OrdjyIJ39s0l0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ciecLiTN; spf=none (imf23.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691181251; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PUt6XfM4QVaZmaffnDjDQpnQshBAoyER3wY7WoNtv+c=; b=c1MyetPRfFrs6BPS90Kexxob9O6h8qPBci1hBhJaBSNmZxuaMrcTL6iONxnITyg2aCo+nK ON+SUlcB0HvUlL1duDd7g2QRgsGwWVfvOzYGThYbYhgLvUrVwqol2WhWtZ+EqlkgaJvyYM a0SmNVsn/8LoqfrWAXA5KLCi4590wtI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691181250; x=1722717250; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Ie3+Tp8HSJL5p5a626rZ9+1bzRCSCac0mPMAN935+jg=; b=ciecLiTNkgm4plvH5vhORgfU4tV/7GvnjxOIJGLMgaCmMO+jvVAOgrvW losqzfBhCwaCA2hfUP4By9Czp9bdIleXgx/MU1KqiKU8FNkhppsoJ3jL5 xtND5zgvECCIp8jdslJs1BzlEOAt5uY/YnGKYEHsF+d02UwmM7tnBMR11 ujfD4H7tI3OSlpdAZfP04y18brSDXkrQdZJpT8/3L9DwcqEUeIfygzm3t tPRWdMMtt76hBnU/Kz4/Vdx5l2sANKG6H0lZ3Qk6b/FRAoY4wEFQtSyrA Y35duwOdIyxygfN6EewQ0V72Rqob7D7MxBlIbTmx/T9OCuPuQ4CfMGwsw A==; X-IronPort-AV: E=McAfee;i="6600,9927,10792"; a="456619039" X-IronPort-AV: E=Sophos;i="6.01,255,1684825200"; d="scan'208";a="456619039" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2023 13:34:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10792"; a="680087031" X-IronPort-AV: E=Sophos;i="6.01,255,1684825200"; d="scan'208";a="680087031" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP; 04 Aug 2023 13:34:05 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qS1Up-0070AP-2g; Fri, 04 Aug 2023 23:34:03 +0300 Date: Fri, 4 Aug 2023 23:34:03 +0300 From: Andy Shevchenko To: Rasmus Villemoes Cc: Marco Elver , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Subject: Re: [PATCH v1 4/4] lib/vsprintf: Split out sprintf() and friends Message-ID: References: <20230804082619.61833-1-andriy.shevchenko@linux.intel.com> <20230804082619.61833-5-andriy.shevchenko@linux.intel.com> <71ce8516-21cb-32c6-84d3-b3f9bb3d625b@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <71ce8516-21cb-32c6-84d3-b3f9bb3d625b@rasmusvillemoes.dk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CBC6A140010 X-Stat-Signature: q6japyidhnq6kgno3cyncpnqh8q6qxt8 X-Rspam-User: X-HE-Tag: 1691181250-722964 X-HE-Meta: U2FsdGVkX1/NJIqAs40BAubOwUbWIM3J443Ku/L1kGdyUOPkFV1xxn97FTLuSaptYDtKqaBdkNS5QScZK2zdFoHMWGBynk1jOJuhHljeIiQdeAy9WEbYxYohWfx1ENAx9Un58eZmTIKnfQWmT6jiJw4B0dHxc0bCoMkEgq2xHbPOTqDQoaA4qoLVwj4ar7W/pqWfHtaoBKwGFMFFTqIHDwWoxeojGyzHK+J4RuP2svb+DVjSpMOeoljjf8naHfl+YvfPWJ8GK5O/T+dGwMnSt4M6wwGmGi4d7zUMNc0hsTJgKF9c9j3Rz52di0ARM+VeLa1NfDYQaZAP0U1SGgXjdS8LoW0a+5N1Eby1IgnTSJ2WV5tVxsLpM1+9Wc4eh+gqWdxzxEEt9vdxrlHk6o5LwpgahMEyCXSlEQH68ffZeeNtWFnsW+dQZzoFBK6KBilWlAcwc+yVJrop84Ku21tYdRedS6d3TJwlvzIag03DE0+RuOsMv8RwE5uqydUIRreO78bZ7kAnedf4GVdHqMESrD75+sv0Ikbd9XMUmCojF0ezoGewp81LKKd8+TDHgV2kNE0ver0GZuXnpNnUDCVMPeVPOJhDn6g/uaodbxx+3PaElJFM17EZjcLx6/91sVi5H8JfY3maFbWo0ELGoGa0mp8Mdwb5elNIb81HJxDRXaEzUQPXS3oPusYtdo7UohcrkvDbTR6vW1LTDG6jSLxn3fvncAJ082zCGbDyIwxMV43Er75xHoRJ0L1kJc1zE05w7g8NNaN2ePxwi+BLE1gous3KFcFuPvCV2uvw/JhnlewUyCHstIGd04NNLbcgHcEDdMgzqTEytLvm6+L8XHyB6lbEJKH9ShZFJl86n4b3Jlx21/nUtSxp1ei8d02N5GgcWGLTobhWZtZOtbqKkJ6Bu4/3oj72UQHfZ7uRZ1v+N+KFKFqPe57TFko1if1Ad9zEZBN03yYTX6GwemtTq3Q rKEtxc1w +7OMhi/Gf0+nnrS+491p4GUZxgyB9KPQrknragFCBniYAf40sH1TvlEAYX4ZGFs6exmF+jILgbhepeRrXIkQ66+CU+Z+Y7kgoVLdWCia+NdNp5QT/ak3PrBkVyuu1LaOrA8xI82/0wlSigA+fHbYIz1RaP0vdxnBUyyX3rRw8sgOE/fQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 04, 2023 at 11:31:58AM +0200, Rasmus Villemoes wrote: > On 04/08/2023 10.26, Andy Shevchenko wrote: ... > > +#include > > Shouldn't this at least also include compiler_attributes.h, to make it > self-contained? As I replied in the other email, this is guaranteed by types.h. But if you insist, I can add it. > As Marco said, please just declare no_hash_pointers in this file as > well. Perhaps with a comment about not accessing it unless one has good > reason, but I suppose that's true in general for all kernel global > variables, so maybe not worth it for this one. Sure, thank you for the review! -- With Best Regards, Andy Shevchenko