From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81D68EB64DD for ; Fri, 21 Jul 2023 21:03:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17E788D0003; Fri, 21 Jul 2023 17:03:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12EBC8D0001; Fri, 21 Jul 2023 17:03:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F39908D0003; Fri, 21 Jul 2023 17:03:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E5B3F8D0001 for ; Fri, 21 Jul 2023 17:03:05 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A289A1403CB for ; Fri, 21 Jul 2023 21:03:05 +0000 (UTC) X-FDA: 81036843930.05.BE01E26 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by imf25.hostedemail.com (Postfix) with ESMTP id B9E6FA0008 for ; Fri, 21 Jul 2023 21:03:03 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf25.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689973383; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HmvlwLqe/HyMXG8CYpAUMk+EWmV9FBll7iWhqk+njS0=; b=GLCIRNa9+xAr2CN5RH8RHV2G3/GddUsjvJKt4p6GEZkwDpTgnvfbOMEsaTVNjEWyPc+Uxt vxDzJ1eFltL7860Og2eZrmvRIipy3LFRpMhRl4VqTgg5uQ2czSkapLckzLcRd1fkglmXSM Ba6duuP5xiP8+QazjwFsPf7ePvdjV48= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf25.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689973383; a=rsa-sha256; cv=none; b=eaRlBKf9oi3D3bYEPE81GLdO6TQzpalietXWmg9X5lyHmiRhGHcO12AO+b0bU0IDvcpljS mlkS454FzVH4HKZy3OIwx0N2t2q5STzWnH2EuClCdFJVVG/0c3gcPDqo3Dzlkgl0PRsI6/ Y3v8K4CqCHHQgQTcjVXTaY2OR7MxtYE= Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-77ac14ff51bso99659639f.3 for ; Fri, 21 Jul 2023 14:03:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689973383; x=1690578183; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HmvlwLqe/HyMXG8CYpAUMk+EWmV9FBll7iWhqk+njS0=; b=jrQ9a4fh9HgoU7W6zBBhqrBL/K9J4WOfEa04sSlRvXUC+D1Rx4ah1ULH6RQCl6ZMnb zMFgp83E6NB+mXIcvQZHUxpmJ54SG9FVmwqFCjHppcvSUFwA7fBnyeJaCFj5+VE2xktR 7kpdLZOGAGLkYxIUo9FnVKGM4JIKyZtmghxEcLKGg/GyeYoHiZ9JbhyZuBBbLVOZtutW HA70a5a/qh2o4/mDm95th3PGdQeyPjnXLxuusTq5Iqx2tdi8HZjwxB8kib1cmkFwoTme uEFJHpesAC8khWkBwFP9Yp3PGz1Qgf4m7kd6jeYyXibrmU6JIf0iw0DH3P/yv7Z+0FeU qgxw== X-Gm-Message-State: ABy/qLbOAHTQv9WGFceDVD0zdENZkrMpVY3a42VYmwTrZYilvQ/5uSd0 L5RALq7Jbe4Ol4q77yA3ixA= X-Google-Smtp-Source: APBJJlHvY7wYCfxPaXkagBUxDljWytFJZ72GYd/mI39m8sOcqURPaMnPfIB9a7hJTLRbQsjWXpRx0A== X-Received: by 2002:a6b:6d02:0:b0:783:5e93:1e7f with SMTP id a2-20020a6b6d02000000b007835e931e7fmr1072143iod.18.1689973382836; Fri, 21 Jul 2023 14:03:02 -0700 (PDT) Received: from snowbird ([2601:282:1800:1f50::d356]) by smtp.gmail.com with ESMTPSA id w22-20020a05660201d600b007836a9ca101sm1343263iot.22.2023.07.21.14.03.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 14:03:02 -0700 (PDT) Date: Fri, 21 Jul 2023 14:03:00 -0700 From: Dennis Zhou To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, tj@kernel.org, cl@linux.com, mawupeng1@huawei.com Subject: Re: [PATCH 3/3] mm/percpu.c: print error message too if atomic alloc failed Message-ID: References: <20230721131800.20003-1-bhe@redhat.com> <20230721131800.20003-4-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230721131800.20003-4-bhe@redhat.com> X-Rspam-User: X-Stat-Signature: j7zexkhkibag7bhof4ew9hux3m3fphss X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B9E6FA0008 X-HE-Tag: 1689973383-399166 X-HE-Meta: U2FsdGVkX19p48S7K4732/pqG27zQbONMv4bvKu87wQgv4z4kLaVdFnvuW8gxJFWu13HPxRA6dKUCGcW4TxMkaRF1694g/qJKiCXjc4SEmlH6EWVlBIX2R8l1CogbA7fBUWnh9MX33Kmv1T3rlRdcvpjLc2FIxPCOdvyFVegLBc7nR/skolyQpTxBdpkwjhbFd5mtVc7KgU64hRzXMu4aDfzhSxA3xqkJ3BejNwlclXHdrPZbW0wruNeTUMw8enD4+MT8UgfhpXc5qX7RWuf6p2cvlwjHOZraVPtL8MPMM4h5dQflBeocDllbz7avaK6gKvKQr/Qa7M9kImdr5030NF9lhqSWlTxvP+TDqfGk2I2644rEnp7A6GpGWaBpceu83WRPHAFgIrKED9UOFR3VjoTKFr6KRZ7jkleLOisoDpNNQTCP69mZVftXKOO9dn7TnyHYWltLCRG0cjN+abFJbn63SRwE8MlKvr13gwVoZvXJf5HfYqVgkswGy/n5DL/L50w9hZbgc1qhfqNVxEapcwUSMgqNVASoUbXkZDS90xhEhoG0KKTV41N7X1u2IB75bAYNLi+0Om2bc9mNepgqLstWImvq7nTHp7F/dVIxCdO2f8pCJoMy1E/WJDST1M+1garh0LVy0JvvAxwXdNMJUfo33yMNHLPqYfdc1XKAWqAxVZE59BNHOfiMVxT4KckOt1EDmEXjsC5ORWbRmuHqfXMErVw5f+YskuaGbJYgUvLvMbM1+Uuno5bHYL1GJ8hn6Jg6Klap6dSBORSuVxfNSLzH8TE18mfVTlPK+H/qRsngO+mVAV2WHMYIgZUyFa6+cQn3MtpReGxE/eIDM+0D9Hlb4oacfVBjt2x8rtysICNyJcPl5vgMpwNf/HfO2S+2QBFbdhQ4iR5+d3QHJug1H2L5+IIipsWVvGNIaEstqtwnhtS4vJVcBHucdsmhqHcRr+UI1CXQOe4QacBVPc 9gfbZ56F dboBvCWaFzneFxju28TiyN4J+9XHQ1r9hcm8Fo0vYeLGchWdRsFUiVfHwjmVQ8drNPeIlMdQ85ogcXGgdC8J0oZF88/nf+FoHp+KAUqZTalJTqrPfJy4NK1p4lO+XIMKSUfU2mh3V+SOvIfAXG+WHFaisQPHyCqWdjrCJYyPDKGMuR75zC5KUnapGf4++w8AMwgWUSnzq8oEhLvGH3S14gCRBhkjPvGSYdOOgPiqnQVU58Tv56BC5VYl8Ir1R3mkF0QtXA9E28Gny4aVHOQrfgBQEReoiCVU9YO5+oJyOtoBUmNHRry3ytKdISpd0o2bu5/DZvsc1sELTE4nSjQYzdJYnlScs/vtuDIKH8VWRjhvnFufWi2UQEgE+xgIuBeBEJIny2H9mhniPHXB/+urcVK3GZnIJ8XWr+zdoOa2DbHXQxwrA+IYzmTkd2PQq7xFU2AYHzvzA8Nk896JTNAim3lyUgbYUFjrQJ7lIjOC3p84pysl6Jd0GVwY07w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 21, 2023 at 09:18:00PM +0800, Baoquan He wrote: > The variable 'err' is assgigned to an error message if atomic alloc > failed, while it has no chance to be printed if is_atomic is true. > > Here change to print error message too if atomic alloc failed, while > avoid to call dump_stack() if that case. > > Signed-off-by: Baoquan He > --- > mm/percpu.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/percpu.c b/mm/percpu.c > index c25b058a46ad..74f75ef0ad58 100644 > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -1890,13 +1890,15 @@ static void __percpu *pcpu_alloc(size_t size, size_t align, bool reserved, > fail: > trace_percpu_alloc_percpu_fail(reserved, is_atomic, size, align); > > - if (!is_atomic && do_warn && warn_limit) { > + if (do_warn && warn_limit) { > pr_warn("allocation failed, size=%zu align=%zu atomic=%d, %s\n", > size, align, is_atomic, err); > - dump_stack(); > + if (is_atomic) > + dump_stack(); This should be (!is_atomic) to preserve the current logic? > if (!--warn_limit) > pr_info("limit reached, disable warning\n"); > } > + > if (is_atomic) { > /* see the flag handling in pcpu_balance_workfn() */ > pcpu_atomic_alloc_failed = true; > -- > 2.34.1 > Thanks, Dennis