From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A32EB64DD for ; Fri, 21 Jul 2023 20:55:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2449B8D0002; Fri, 21 Jul 2023 16:55:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CD688D0001; Fri, 21 Jul 2023 16:55:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06F698D0002; Fri, 21 Jul 2023 16:55:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E5A048D0001 for ; Fri, 21 Jul 2023 16:55:17 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9D9F4803C0 for ; Fri, 21 Jul 2023 20:55:17 +0000 (UTC) X-FDA: 81036824274.01.094E05F Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by imf16.hostedemail.com (Postfix) with ESMTP id C787418001C for ; Fri, 21 Jul 2023 20:55:15 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf16.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.166.50 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689972915; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Vwa1pffIAjGAHh+N52+iT2Ub/BHd89kMS2abs0dEss=; b=K0rH9KJIm6jrecIPPXMiEEONpQnT/v23Dr+E3xwSIhWknJKkU3nVOyox8ySbjc+D8HFvM7 W5yR9WMTFm/TvMGCd9/bmN44rA40Zcgz2RVuOClESqmW1LpVghHeYueclt/2+a/5AykGlY v1+vYV9lQPmWRT5VsVtXvnno+LzqS6w= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf16.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.166.50 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689972915; a=rsa-sha256; cv=none; b=h9I2c50/P8BaymzRjeSzvu9byeLvYD2QInTMuUgP7u7EDr0gC1TcwXJupuxV/jcCdNQpbx MkLbVfDiOsExuhSIUObzLVOMRDjzBfUcPnMinQm7nXPR+u6MN/w07nygV1j78G/vbbmUz4 kb43pHDvl2XekPBmrTwEKTnGdGq5/pQ= Received: by mail-io1-f50.google.com with SMTP id ca18e2360f4ac-7835ae70e46so102372239f.3 for ; Fri, 21 Jul 2023 13:55:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689972915; x=1690577715; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4Vwa1pffIAjGAHh+N52+iT2Ub/BHd89kMS2abs0dEss=; b=TrvMSEGHfZaxEkz1yJihrScn/Ix1Oh6rHFCMwc95BJ6bmNLcf1u2NYtsrsJYV9n5pK oGZHmGastTIHtxtYDSg+oQTRme5nFSKPVykTzk0hO7bzsvXbfUau5W0LJRfQ6OSCdqp9 hFLCh5YqqqSZBNPvOV6ApRhcqCHYmQDZt4AC0XHn+PiJBuzdQaCErhLXWRJJGs/a/RK0 bxAnGlKr7G3vv6wjnPqkZj10UVk5eCJpcBgK69PyfCIgJMBAJdftWp3qwUGHJdCLbrmJ 2kexKMkSqdOHE4YuhzKP7oZbBGmPQXTPa41gvjEI/FM1PR5ZMq7nsZZcIlSyQDKXgXTd 6gIg== X-Gm-Message-State: ABy/qLYMKXInkaXPrnsDBBmnT3CsnYmDxRVhMSGCfIKu+3rxEKh0WHj3 HjkqeRfElk9u5d4XP7MIY2Y= X-Google-Smtp-Source: APBJJlGxgroo00JppSotZTG28fuUPsgirAKgpVF0HF0waF1axkvja3KxXfcYkzXP3f2zJ0kYhdGL8A== X-Received: by 2002:a5d:9950:0:b0:785:fbe8:1da0 with SMTP id v16-20020a5d9950000000b00785fbe81da0mr1055579ios.15.1689972914935; Fri, 21 Jul 2023 13:55:14 -0700 (PDT) Received: from snowbird ([2601:282:1800:1f50::d356]) by smtp.gmail.com with ESMTPSA id h9-20020a02c4c9000000b0042b2e309f97sm1216479jaj.177.2023.07.21.13.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 13:55:14 -0700 (PDT) Date: Fri, 21 Jul 2023 13:55:12 -0700 From: Dennis Zhou To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, tj@kernel.org, cl@linux.com, mawupeng1@huawei.com Subject: Re: [PATCH 1/3] mm/percpu.c: remove redundant check Message-ID: References: <20230721131800.20003-1-bhe@redhat.com> <20230721131800.20003-2-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230721131800.20003-2-bhe@redhat.com> X-Rspamd-Queue-Id: C787418001C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: jnmeood8md5uibixmf3thya7oi6tox89 X-HE-Tag: 1689972915-626283 X-HE-Meta: U2FsdGVkX18zelpch8+RRYDt4nsszRMlc7xXtMz+YjBhUNiR2/KrLftANhc/XbYXu16QE6L1sMrEL0U1mpH27cBbj3OpTQHyQ0sPe1bL0NF76p99VgRZpluFdHJmx1t+ege2KdRKSSlzXDUB1x39wvdNoDUVzbLdpuBw+f71JrWEaMPsOJ83zSSx/OVar5gvCW70hfVly4BSAA5V+MXwANyksk2uaTKNhXvcv9zSmzdrepG5+lv+hF/WFCaxJg9aM0PzqL3G67cjkoHhxA6IuJ4CQ/t0+QqS07hBFjEylTvAC4bpIINLTJziD1lb7ta8pXiHv8dxGKdCQp2EW1gLq2poAtAqcazRaf8ScYoopbt1Xifw3wNuvrJ134qcxUCnyAtNOm8WQ6KyuUXUN7BUKla50jF4E9jQzuINu1tLtU4nSbkglCvbWaBmxVLBQ8DQCpDpLMcOYBkan6Fl+QkaSOKqSoYXlwvHJZ6dMvvvhAz2JOqs5NXZUj68dtFsyy0kQHoX9KN4DdRfotUh+2fB48FRojLzrxcdMS08MdGGr931guWA8Xe468/7oEP3POzMAE1g7gw1tY2F+hpXyijXvTfArHHoKAVYg1pJALeAzAFipW8kxxCEUzO8cU5YiWOyH2xxPLFBh3O/wPShNdxXFOZEVFOcOGIkM28OwRMoBmC8J1RE+tXpsvbQACiLY3XyDaUSQjl9hEkAMls7TXIg/zP/uCF6pYEFaqS9dfVnan8w2TX8aF7HJG+C8G57D6lx9nZ8Zg0JFgp1LF/pY5tubxvVe5rMJgNdUl1P9zJN2DxmheWn+GYWPGetT3/TtI/vatgV+YylTKfj46pSmNiP5uvTCCHRFpwMtjjfVO3ycf4elaaEIAHN8TGfTzKSouPw1KpmwvmaU8pzIiU7RDLN0GYHpbgm6HLD8v9NbxMj1jKij4tTfoRFQ34DCKvUvRXbHdJR8FgkyTRVcqMX0Sg RUF9/OdT m/Z9TOMW9Z26yjr0d5g38/UGU12km+D0vjBnhmBBUCjxDNyFUV0mxgf2etBcNRLGc8XJZGrIc1GeaiMhv4VrsIunkMK79mBTE6e8o73Q7vodfXobbfwAKuxSUTUvSvEv79EPbjGQ6aDUzlqUPy7P8CjtWK3UaWr+j4vIwiXfB85wxYRa+K4lF+Y0fu2p8OE/RUP/4+0SGkC63H1SRHWPJNpFu4BLiW90RpY51PQnq5geJ7dIppYDIIrA3KdfJvu0gS3JyAlIYqpHzCmJytb3Eao0ww0tJUjPrbyoQ0tnY/hmX64oxtDpu1XgbzNsRyXBtMTXbw4EJDSczcbY4irSCsmWJp8ar/zbf/qhQOqStbzIuIalRQ+Lq3ncyoScwkSO/+OaNnDrRPUvLmOVNpS/A6lyNDp6dQKRyewj62bZPGOK8OI/XsmLnOes0t1HJ8XeOvNQc4GDW04OV94O90JjXUkCerUqidxc3KgWJ0qr33sPpDNxpsMfk6BexsmIMaRnDjuGYhOvBeTi9VxBRr+0C/nvPt7zlxyX8QxJzDeOlRDyeJss= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 21, 2023 at 09:17:58PM +0800, Baoquan He wrote: > The conditional check "(ai->dyn_size < PERCPU_DYNAMIC_EARLY_SIZE) has > covered the check '(!ai->dyn_size)'. > > Signed-off-by: Baoquan He > --- > mm/percpu.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/percpu.c b/mm/percpu.c > index 28e07ede46f6..1480bf283d11 100644 > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -2615,7 +2615,6 @@ void __init pcpu_setup_first_chunk(const struct pcpu_alloc_info *ai, > PCPU_SETUP_BUG_ON(ai->unit_size < PCPU_MIN_UNIT_SIZE); > PCPU_SETUP_BUG_ON(!IS_ALIGNED(ai->unit_size, PCPU_BITMAP_BLOCK_SIZE)); > PCPU_SETUP_BUG_ON(ai->dyn_size < PERCPU_DYNAMIC_EARLY_SIZE); > - PCPU_SETUP_BUG_ON(!ai->dyn_size); > PCPU_SETUP_BUG_ON(!IS_ALIGNED(ai->reserved_size, PCPU_MIN_ALLOC_SIZE)); > PCPU_SETUP_BUG_ON(!(IS_ALIGNED(PCPU_BITMAP_BLOCK_SIZE, PAGE_SIZE) || > IS_ALIGNED(PAGE_SIZE, PCPU_BITMAP_BLOCK_SIZE))); > -- > 2.34.1 > Acked-by: Dennis Zhou Thanks, Dennis