From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6EADC001DC for ; Fri, 21 Jul 2023 19:27:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E9A38D0002; Fri, 21 Jul 2023 15:27:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 598FF8D0001; Fri, 21 Jul 2023 15:27:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 461628D0002; Fri, 21 Jul 2023 15:27:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 35DF18D0001 for ; Fri, 21 Jul 2023 15:27:10 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0BFC71A03EC for ; Fri, 21 Jul 2023 19:27:10 +0000 (UTC) X-FDA: 81036602220.13.FB8FAE1 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf13.hostedemail.com (Postfix) with ESMTP id 29BDD2002B for ; Fri, 21 Jul 2023 19:27:07 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b="ho7FX/Gu"; spf=pass (imf13.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.210.172 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689967628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D1nGAoqkQE9tORj40d+ZOdFx3TBXwI2iMVqB+EH0J9M=; b=DxvGZdEbgVSOfDT7XpQ4ZGEZxw+52SBKCcjDl8YFGNAl7onvvBDRKAipPoyNtTr/fqu556 E4xzMKjO2tWX0tLtzbPuVoWRI5oDJ7/5xEisC1kZPKFb/7cksDS7gGn36a1b+04kaeGvzz eaj9M+ityFi0C7QavtIsNJZBnrEc7Tg= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b="ho7FX/Gu"; spf=pass (imf13.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.210.172 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689967628; a=rsa-sha256; cv=none; b=R3JXmSoR58BwmsfZvte+f6/EHDUH+OpDJtopimXPrEsuzHbzsLVZnWydTPKS+I82aWFgUL /zN5Ex1dtf/58/a9sYMs9U9wHn1TaooIYwzpRlL8K2ptnZMznUcl83cIe0G7DWoO19Gv7+ ICqHZPtdpCntWXOD6pUyl3TRT6EPSN8= Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6689430d803so1492867b3a.0 for ; Fri, 21 Jul 2023 12:27:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1689967627; x=1690572427; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=D1nGAoqkQE9tORj40d+ZOdFx3TBXwI2iMVqB+EH0J9M=; b=ho7FX/Gu/yFttlKppWHadCl+z3p3hJNnyUWo1gZ62PEyBJbQY6EYc+cgqOF/vQCsNL Mkj3evoOdg5kQNIS2GHTYB2bsdau7no004XCgCzhg70C7hzjuBTgqZBM8fhGLoNoppsr kqTwMYeEw+ixSgRXlOs7lxHbvsOYYXsbxRGJLY9Xj9ZAmOizPWpr0ddjxYm6D/ZBDDur 8kFjVO0kxTqPNd2AEoeDXPQtEpGr6MWERNLupARD7mBgQc27VY17l2Dq7N7guA1ips9f 8Sf/a3XpW02K8gKcfPE6pA/EbZNlePzntRg9/8m15RDd8Lh+iQ3IDCBxkHiaCB8eeHk6 pVoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689967627; x=1690572427; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D1nGAoqkQE9tORj40d+ZOdFx3TBXwI2iMVqB+EH0J9M=; b=X2cxZOGDzhIVnA+eviXuN5NR2mElvZeL1aV/g2A/DWMvy1bnpRvXV8TQnmIRLmbi1f 9yySyUjj3L5g3L2IMhmT6svjF1/Caz5r5wu7ARx3IABPkV7c26dptm8XVtnVXEl8YgAB m5BWlTwESU1xJuMXbd7Upa5FDK1K5p7vZcII5EU+txI5xuZOlh2E2Ydn/pEfQC9swFLb kaHazvemFgXDLjvh00eG0vVEWif/ikIjjyeyO9IHmdxuBkDqH2uSj0HnZKPj6OQPrad8 MAHkEevjNOnOESXXq30Ya4jPifpSWOuV0JbSEOBtlgeQSv4cg/4C1xp34rM1xZCDJNEf rAtg== X-Gm-Message-State: ABy/qLb+t+6yCgwx2LUO2Y/az0cjU4RIxE8px2aBylFlD+JgE7gQugjH rlUFiw7teFQyaHJsUMjREorLMw== X-Google-Smtp-Source: APBJJlEJHy5FiukXEMdXavX4iO5BgBEVLB0I27AjF1BNpwKJMi9kmjgl4tr0TNNlWYEs0Uxb6e5yVA== X-Received: by 2002:a05:6a20:8e1f:b0:122:20c:fbb1 with SMTP id y31-20020a056a208e1f00b00122020cfbb1mr3108454pzj.44.1689967626960; Fri, 21 Jul 2023 12:27:06 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id g2-20020aa78742000000b0066a31111ccdsm3333938pfo.65.2023.07.21.12.27.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 12:27:06 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qMvmK-003IDr-B2; Fri, 21 Jul 2023 16:27:04 -0300 Date: Fri, 21 Jul 2023 16:27:04 -0300 From: Jason Gunthorpe To: Alistair Popple Cc: akpm@linux-foundation.org, ajd@linux.ibm.com, catalin.marinas@arm.com, fbarrat@linux.ibm.com, iommu@lists.linux.dev, jhubbard@nvidia.com, kevin.tian@intel.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, nicolinc@nvidia.com, npiggin@gmail.com, robin.murphy@arm.com, seanjc@google.com, will@kernel.org, x86@kernel.org, zhi.wang.linux@gmail.com, sj@kernel.org Subject: Re: [PATCH v3 3/5] mmu_notifiers: Call invalidate_range() when invalidating TLBs Message-ID: References: <86a0bf86394f1765fcbf9890bbabb154ba8dd980.1689842332.git-series.apopple@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86a0bf86394f1765fcbf9890bbabb154ba8dd980.1689842332.git-series.apopple@nvidia.com> X-Rspamd-Queue-Id: 29BDD2002B X-Rspam-User: X-Stat-Signature: 9x7i63xdur6htwzbnet1ikr3ucfz9nap X-Rspamd-Server: rspam01 X-HE-Tag: 1689967627-466159 X-HE-Meta: U2FsdGVkX18TnjtGSGPnkdswWQIWOkqaJSm5uQ0Xrpm1h9sLsWsPds6rVPsCJWUlIGm3ADJU+tD4j/nQWgyvxbCnLF1F/0BAEdwa2cQxhFU3muqTmHVocv65P6t+Am1c8H/lvIAY3dTg4i/b1lXVwJoMnWhbB0ZXOSQ/dkzWwhskkistrO9yceEDvrn0dnH5/eFaJNACtNPRMC2+UzCnfauinaDE7cLE3THM4hJRdlmcvKNyfJ6v5FACU61soMMDcQ/CnCA/LYKDNWWyOww9ku8zTqqYgltD2DiW+ZTaMu4+84Mk5y+bB7m01LwRQAc3AT1tBuXb/BXqllqKT+QUU1y4I5xaeI6uhfGYjt3gabWd9qq/cIcLGJ/6C16L051Eaci8Wh/fQZBbVooGfnGYAuph62klmLzxbGTIHLzIZUTmN4CPHEPOe8NC4YOTr82ta5N2Jvr7ROutnDnuVph3sODzG+ZJ4nGxjdm3L01czBix8JAkqFZ+vP4XQDr7tD7iNykf9P8pJK3nbA8yadwH5aF9oJFBiBPzLpkk3G4P7mWhEeZB8XdTiMTlG38lEV+9/4YUMjMgw3eUqGVf3EtnCF777Vg56sZZ+RdaE4tZtGFatn/jFoyybDZ8QgFZtell4GHb8LgzFUVMtlFCLx6UXoUaDYZAkcaXBHgvZRitVHd7XN8tlnPXBUVbDMapZNvZ9kdDKO2aYQ6+/BYJfI+H3S+4RebLY5AMheAUaqFCwjPLS/XlLNzVNoaYRIf/06dP4nZ5XdDos2LrNt3mb6hvHiFkYabWf5Y3yD+2+N5hG26eekpEvuEEQqFp4i0MqTKPx+fLzeL8R/0YbZNGVpEOo2b2CTDID9k5jVBlXnH0/l0hkDQAajxbUeIn+oA8vuZHk/HRVa5gdmli6NY3No+jqnZVYdKlezH9MfH6mky5Kn6btkedOcgYTpO3hpDFucA6WQm/VUnQCKo+kEYaRPt VULqb23F Ov9Qa1J8qGDoYyFsModGzEq0+OvRGYwxUrx3+47C824ZnrCHoWDAMUzB8SvbxyYcb9NDzdU3StLb7COEYQKR9JK4Ecnn1veiHIGkKpeXyN64EjNN9E9rLGikJQRodDf/y8axMTKe6TWqlIJPPk/lfKyL60Ke3ampU2XJAQa/q49rVDOAq3K61UgEbMumA4WkvgFFSP6Wbjo9sPJcrFG7avENwyLT7/6mvCAl28cQYpBAUNwJ9S8uACHlRr36VALcHLajuMVaPpOq2NZGWh3Mzt+qSdn56IKPFWhOomAvO/yt3Srh7be+gSWqFqU+2Ac3TCfotaEYmQMWN6or07Q3iz29wACRgl9hdlNi88+VSVyogz04jUmKIh7Q5ZuCuO0Iv6z5BeEU9vUK2IKzegoaKmE7n9uI1MzEvF22+/x2oO2DdWBlFVDNaNvZ+6h9mBbGaHSC3iBY/MPtANrWiILjhoJwTOwLXtCZYOlCpcoKNBcPebrCvOGjDfAwNkQHMKBNyb6VhBpXIbToTQTGrsFWkSXM+jHS+SZZ/7KPNJIKeQMu34lMEaICEnp+KMSrzND3/9dmzKtfhUHsmuzg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 20, 2023 at 06:39:25PM +1000, Alistair Popple wrote: > The invalidate_range() is going to become an architecture specific mmu > notifier used to keep the TLB of secondary MMUs such as an IOMMU in > sync with the CPU page tables. Currently it is called from separate > code paths to the main CPU TLB invalidations. This can lead to a > secondary TLB not getting invalidated when required and makes it hard > to reason about when exactly the secondary TLB is invalidated. > > To fix this move the notifier call to the architecture specific TLB > maintenance functions for architectures that have secondary MMUs > requiring explicit software invalidations. > > This fixes a SMMU bug on ARM64. On ARM64 PTE permission upgrades > require a TLB invalidation. This invalidation is done by the > architecutre specific ptep_set_access_flags() which calls > flush_tlb_page() if required. However this doesn't call the notifier > resulting in infinite faults being generated by devices using the SMMU > if it has previously cached a read-only PTE in it's TLB. > > Moving the invalidations into the TLB invalidation functions ensures > all invalidations happen at the same time as the CPU invalidation. The > architecture specific flush_tlb_all() routines do not call the > notifier as none of the IOMMUs require this. > > Signed-off-by: Alistair Popple > Suggested-by: Jason Gunthorpe > Tested-by: SeongJae Park > --- > arch/arm64/include/asm/tlbflush.h | 5 +++++ > arch/powerpc/include/asm/book3s/64/tlbflush.h | 1 + > arch/powerpc/mm/book3s64/radix_hugetlbpage.c | 1 + > arch/powerpc/mm/book3s64/radix_tlb.c | 6 ++++++ > arch/x86/include/asm/tlbflush.h | 2 ++ > arch/x86/mm/tlb.c | 2 ++ > include/asm-generic/tlb.h | 1 - > 7 files changed, 17 insertions(+), 1 deletion(-) Reviewed-by: Jason Gunthorpe Jason